Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Message-ID: <457f625e-f74f-47da-8bd3-f558956a2ce7@intel.com>
Date:   Mon, 30 Oct 2023 14:53:59 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 4/5] r8169: Coalesce mac ocp commands for 8125 and
 8125B start to reduce spinlock contention
Content-Language: en-US
To:     Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>,
        Jason Gunthorpe <jgg@ziepe.ca>, Joerg Roedel <jroedel@suse.de>,
        Lu Baolu <baolu.lu@linux.intel.com>, <iommu@lists.linux.dev>,
        <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>
CC:     Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        "Robin Murphy" <robin.murphy@arm.com>,
        Heiner Kallweit <hkallweit1@gmail.com>, <nic_swsd@realtek.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Marco Elver <elver@google.com>
References: <20231029110442.347448-1-mirsad.todorovac@alu.unizg.hr>
 <20231029110442.347448-4-mirsad.todorovac@alu.unizg.hr>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20231029110442.347448-4-mirsad.todorovac@alu.unizg.hr>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y3c4TTVnazN5SGx2VnFhT0lKWk9tZFdFUmVuRWF2S0kvL1FmQ3dqYXB4VnNT?=
 =?utf-8?B?Q3hjTDlnaWpNWUpveHk3bHQza1Y1VFcwcUEyd2ZRZmdoZDNqVXFUZkg4VXk5?=
 =?utf-8?B?cWZSVUFoWi9CdGFabE81dGlkYzd6UVNIdmVuTVlDWGlzc1B2SkhZSDRBNHN1?=
 =?utf-8?B?WWdqRmtLTkN4RzYxNFhrbHhVV0RTckxxS0RPTDdDdmJlR0t0WFVJR3ZNdzVi?=
 =?utf-8?B?Vm91aitObEhuL3IxM3JjTU1QZEJ0QmJ6VlBmWUxmK1hyWkdWd1V0RGN0SlI1?=
 =?utf-8?B?UDU3ZFhUNElWSjFMSHBSNmZ5eXZ3dndIOTZ4cTh5SEkyN2htSk9tYVJpZDNZ?=
 =?utf-8?B?YjM2UXBaTE03OVlRVDRuZDFMK2QyZlRMQUFnTXhaa0thTXc5QW92ZG9BTXoy?=
 =?utf-8?B?dVN4QS9iRW8vb0hGeHFMNU81cFJRUlJTVWNkWDlPZ0FKL2VPS2FBcVVVbDF3?=
 =?utf-8?B?aXBSWDlaN2xoTGJQdTA4SHRDQkFJaHFoaW1zTzVhczZDSTdYL0kxVm96TWVM?=
 =?utf-8?B?T20vV1BmbzZadERWcGhRbTliQTFEMWtMTlFLSXNPL2NWc2dkUkJyNGdsdVB1?=
 =?utf-8?B?NlEzallaYzkvckIvenVhWC9nZGNOd01qQ1FWOUZ4ajl5N2RiZW4xaklSeVJE?=
 =?utf-8?B?N2IrSVNBVXdxdDZCV250RHNLQ3RrbWpQVlJpbFJBeDBveGMxZGkrd2gvSWJI?=
 =?utf-8?B?cVl3bUluRjJFZlZha09OSHZidTZXd0N1VTNBM0VxVEhZL21uZUdJRW5tRE1R?=
 =?utf-8?B?VkFLVHJ2L2ZqdUhMaHl2clFXaEtBaXljZ0c4eHBBVWx2UkE2a2pKdlE5RTJP?=
 =?utf-8?B?WjExZDhzL3AyVFVleTZsMU5paGt5MC96WUlNT1FWTzVoL24wbmJNMk5LZE9t?=
 =?utf-8?B?NTl2YjlHUmdEV01Pa0NJYmhEWExyNXBzUFphSHZZMFlaaE1ESUIzcDVERS8z?=
 =?utf-8?B?dDN2Q3MvNUlrY2VPWkVTRHJKajBxdXduZEFyRTMzVHlmZmVSZERwWXIrSGlq?=
 =?utf-8?B?c2diaVpIKzVuMVVTOVRhZ1VVYjYydU5XTlBIOXNaNnlRZGpycVJ6WndmUkZC?=
 =?utf-8?B?aG90ZFpsdjQwVUJKRlViQWlKTWFjd29oTzUwSnQyeVoxK1c3OFNqUTBCSkN1?=
 =?utf-8?B?b05nTkI4cDMrWUhwMnF3c1VJaHlrQUVMVEswaFU3OU41MW12L3J3NnEvb1pu?=
 =?utf-8?B?T0JSNFdFdXluQW1Zek9jRUlYMk9jZnNodCtpRHV0RS90aFhGUDA5VjZiWXAz?=
 =?utf-8?B?T1hudFBvWTFMdWEzcCtjYzUvVUtGeU5wdUNUMmxReHJ2TzRRMm5ZQkhDQUV6?=
 =?utf-8?B?anVaT2tBUlN0QTRBR0piZ0p3K1hvNTYvWjBnd1lrbm9abnA2a3k4Slh3U1I4?=
 =?utf-8?B?dGZoT0g5amJuOHRYMTBpRkpsbUhyVWRtQkxKRnEyMnNHU29Xa2RoZGpUaVBa?=
 =?utf-8?B?MTViSUFlQ0NtZHZYd3ZvaFoxMkpKRlQwZm4vY3BDOHh3aWpOdXFhL2xiMHZV?=
 =?utf-8?B?M2wvZEVJaHhlOU1RQk9jK0tHZE9vekZTVC9qY0paZXQ0aFdwOXFYV25GMVNY?=
 =?utf-8?B?bzJOWmVaZzhJTXhuV08xczY3WGxlVFpEb01jd3pKWWpsVU91OUpjZEZvcTJx?=
 =?utf-8?B?ZlZBdTBBOTdSdS82RTdhb0VVcUVhTUViUEN1bVpTcUREallaWXIrU2ZoZjdT?=
 =?utf-8?B?UjgyRWMyZ2lnVzFKTVNYcWNJWXc5eVdQalZJWlBHKzE5WkQwLzMvVWVmc0lo?=
 =?utf-8?B?MXo4L1ErWlFXcVk1YzU1bWFBQ2FpN3k1SDd6MzJaTzdTYTk3U0ZyNURVMUF4?=
 =?utf-8?B?VUo3M2h0WVFUeDl4cGFBS0kxbFFzanNNYS9idCsxb1RnMVhYVEFaUWhkQm5V?=
 =?utf-8?B?Uk9vK2tLTHBEVGcybFVaemUwSWdBbkV5RURjempnbmY3L2tOSVBKNkt5MHlw?=
 =?utf-8?B?WmtHSUdSdkJHZEd3T1FIZHA0S2gxZllHQUNheXZ3czJ1N3RReUVDcGhRNldp?=
 =?utf-8?B?WTNDN1lRRjd3OWJHT3p2Q0E1cnIwQkxQNG5Da3F4bGdrTXNsUmp5dnVMYm1B?=
 =?utf-8?B?bmh5d0JqN01RR29MNlFtT2JRMzdRcU5ZOTB4MTB0bWVKb3dpajRwQjFvSFB5?=
 =?utf-8?B?Wm4wUEY4b0V1RlFRTCtQKy95Tys0OHFrUDRhWm9UM1dHZElOTUxqS1dNVVd6?=
 =?utf-8?B?QUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2248208c-b0af-4139-6186-08dbd992ba0b
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5095.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2023 21:54:01.4062
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +CdQWw/NPQZp3c3pfGFPncF3p698kGd+A23xLMK++W62AFCVFDPnv67V4AOoN06d/4f6ccFc1T+BLdLJw60Pp1evzxJzMBdAZm2UVbfSEqM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5549
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 30 Oct 2023 14:55:56 -0700 (PDT)


On 10/29/2023 4:04 AM, Mirsad Goran Todorovac wrote:
> Repeated calls to r8168_mac_ocp_write() and r8168_mac_ocp_modify() in
> the startup of 8125 and 8125B involve implicit spin_lock_irqsave() and
> spin_unlock_irqrestore() on each invocation.
> 
> Coalesced with the corresponding helpers r8168_mac_ocp_write_seq() and
> r8168_mac_ocp_modify_seq() into sequential write or modidy with a sinqle lock/unlock,
> these calls reduce overall lock contention.
> 
> Fixes: f1bce4ad2f1ce ("r8169: add support for RTL8125")
> Fixes: 0439297be9511 ("r8169: add support for RTL8125B")
> Cc: Heiner Kallweit <hkallweit1@gmail.com>
> Cc: Marco Elver <elver@google.com>
> Cc: nic_swsd@realtek.com
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: netdev@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Link: https://lore.kernel.org/lkml/20231028005153.2180411-1-mirsad.todorovac@alu.unizg.hr/
> Link: https://lore.kernel.org/lkml/20231028110459.2644926-1-mirsad.todorovac@alu.unizg.hr/
> Signed-off-by: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>