Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <80d913c6-2579-4373-a00b-a6910cbb0b6c@intel.com>
Date:   Mon, 30 Oct 2023 14:54:54 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 5/5] r8169: Coalesce mac ocp commands for
 rtl_hw_init_8125 to reduce spinlocks
Content-Language: en-US
To:     Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>,
        Jason Gunthorpe <jgg@ziepe.ca>, Joerg Roedel <jroedel@suse.de>,
        Lu Baolu <baolu.lu@linux.intel.com>, <iommu@lists.linux.dev>,
        <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>
CC:     Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        "Robin Murphy" <robin.murphy@arm.com>,
        Heiner Kallweit <hkallweit1@gmail.com>, <nic_swsd@realtek.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Marco Elver <elver@google.com>
References: <20231029110442.347448-1-mirsad.todorovac@alu.unizg.hr>
 <20231029110442.347448-5-mirsad.todorovac@alu.unizg.hr>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20231029110442.347448-5-mirsad.todorovac@alu.unizg.hr>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SjNLTTNuaTFsa2YrTnRvR0NGcXhHc2FpYmVmVGZtNGZiWENrUUpxWlpyMU5M?=
 =?utf-8?B?V0x5cENqY1VvNEFwUGc1Zk5VUWlIMHZibkIyTnpSMk9UbzB0UHpmMkQwYyto?=
 =?utf-8?B?WWZYdnh5T2EwUlpZLzZ0QjFFMGYvYjdFWHBZUEhtWVFSTWx3bks2NWVoNVBs?=
 =?utf-8?B?Rld3cS9xQzlGMGNwKy9YdVRsak8wcGFrNTRNN3I4NE01WlZhS0NPNkVZU1FW?=
 =?utf-8?B?UWg2aW9TdjJPc1ZCSEYrL21ZRVJVcE9mZXAxNHJFMlI1ZU1mZXF6TW9qamll?=
 =?utf-8?B?bEdIVkh3K0JMeTFjUVJqSWgxMjVqeXdxV1JPZkhzY1hqSHRLQWVYSlF0VEps?=
 =?utf-8?B?STA4bGExVXVpYUVqenBKYzFpS2l0VUdYWWoxRXpzL3ViaElVcGxyZmd2M2Jq?=
 =?utf-8?B?aTFXMXE2NVUrZmZTQXFDaGJWMTNUR2dyMFQxMmRacFVEM2RmeGFLSTljWVlu?=
 =?utf-8?B?NC9kYWkxTjhXMGU4ZGhTUk0zK3dNcG0xZmV3ZmUwaVRCT0JERW1vekYyQ3Q0?=
 =?utf-8?B?NDRwdFAwOGxad2cwMDZJYUEwOTRBZkRVMmdHUHh6VlE2eGU4MWhTT01acFJk?=
 =?utf-8?B?NVNRVnIrSE5UMlFLeDFZeDIyOUpFSnFCSW5zZmlpRmgzOWd3VGhtZFFwQ05T?=
 =?utf-8?B?ZGYza2pydDFLU0xVcWRtdkR3UFdvVFRoMzNIVWdiZ21CNjJIRkoxYTYyUDNi?=
 =?utf-8?B?cDl3L2s4VURPVkNjRjU3d1ZxM1lkYUlUT3JZK0xVSk1ZKzJ1NlovR21rOFMx?=
 =?utf-8?B?cmVpUmp6dkJBUlpOZGZiZytKNWN5RWtCblRvSlM3NHZwWkhNQ2lFRmVKTnJU?=
 =?utf-8?B?NTZNVXNFRmpISjFSNUdPYTI2a0JwV2VBZGlSYzBsV3d1U2gzcTZ3Yk53UEdF?=
 =?utf-8?B?K3huZDZzNkcyOHBZNGREQVJVNUU0eEthY2NWMHUrSklyUkhiOWU0TEVTTGxJ?=
 =?utf-8?B?eG1iZUliZytSUlBRaUg2K1BFSTQvRi9HYWpOa3B5TnM1ZGs5RkhKcTlUclhS?=
 =?utf-8?B?RWxOQnE3ajFHcERtU09GVmdwUjhBM3Q5M0ZqdEwxK1VOdzluWW1IZytQbUM0?=
 =?utf-8?B?cXlPNjFLTXVOZVpaYTdBSDZEWkxpR0h6UzFXamJLeURncmFBTkxKc0xHYk84?=
 =?utf-8?B?MWw2NXdzSlRmVXl1RDRaSEhBWkM3Qk9Ld3BUQm5NclJZanNkdm1YTDNiWmNY?=
 =?utf-8?B?TzF6WXlQR29wcERuTFpMb3N1WEpDckF3WUU2aW5wMnExMldYL09Zak1SS0lK?=
 =?utf-8?B?Um5ZVTRMNitSWmlrWDdGNEFjSXhZUlRBNkZNN1YxU3VTY21iRTRqMFZsT2Jp?=
 =?utf-8?B?b3VMM2pUS01iVTFiRzVqdUk2KzdCSHVLZi9URFBMQjFsYXU1WXJNSHp5b0ds?=
 =?utf-8?B?V2N4dXhOSnNnSFFaUUlhdmVMaDFDUGJtVFdvT0owUlV0eXBlRzhnUGFJajFm?=
 =?utf-8?B?M3QxbERJL1ovaUVUazR4bmI1M0lCQ0FaSllTa2RpWjdKMjFNTm1HSFNBbjQy?=
 =?utf-8?B?SFZmZnRaRkVPSDZ3NXdyTUloWXRWditPdVJPVk5Zd0U5Z2RCd1JqcnJ5c2Rm?=
 =?utf-8?B?YmJISmJDbWdlYy9mVDl3Q0ZCT1VZVElQVlM4enBPYVhIZG9MOG82dkhCbTFD?=
 =?utf-8?B?dlpmTGhkK2xIMjFkN2ZtSHdoUFNDUStnTGlPQkYrT1Fqdzl0MXRZNFp3dUVn?=
 =?utf-8?B?WHRKdk1FbDJybEJVYkpMSVB4RW1tdDNsSjRVSVhYZFZMV25wMnQzS051Ylp6?=
 =?utf-8?B?T3ZxT0FmNlRRSVF2RTJKWjJXNjBRRFlXcDVVZU9VMEl1OG5KSXlNa2I5elZn?=
 =?utf-8?B?QzZJMEpOdFRoT2FtcW9ORDdHb2dEN3IyNEFSUkJMQUpkQTVSM0krbG9DMnUv?=
 =?utf-8?B?M3lIeVBXdjd4NENXR0lRRURjQnNpWDRiOVNQR1JMZ2hES1d6NVNoSWNkYzdD?=
 =?utf-8?B?K2ZJQmVxbmZ6Mm9RTjhDc1M1c09tdmJuODB0NFZibzdtRVpTb1UxNXJOdDYv?=
 =?utf-8?B?V0JVNVhkR0t1TzcrcEJVMFppaVhSb2ZvYURxNzhNeDNhQUQ0a2Jyazc5aFQ1?=
 =?utf-8?B?R3dYWXcvTjlBeE0yd3JrRksycW5vek9WbnB1TW9jYnBuZ2ZOS3V4TDRBeUhz?=
 =?utf-8?B?QXNQQ0FJSDI0QzVTUEgxRkNTOFowTFg0aVlHcVM1UHJIWlZSUlNVK2hZZk9y?=
 =?utf-8?B?bmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fc406295-84ac-48ab-4950-08dbd992dae9
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5095.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2023 21:54:56.5478
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IzngBYxpmoIZLKwbcb3/XTQzxwfmNwVs9VgvlBcVKWi2QP1Wj6+HWt3PuF5AoubLIgbUk2fjTLt48kEXv+bY83OnzLSvYsqDq4bUbC9rlBE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5549
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 30 Oct 2023 14:56:01 -0700 (PDT)


On 10/29/2023 4:04 AM, Mirsad Goran Todorovac wrote:
> Repeated calls to r8168_mac_ocp_write() and r8168_mac_ocp_modify() in
> the init sequence of the 8125 involve implicit spin_lock_irqsave() and
> spin_unlock_irqrestore() on each invocation.
> 
> Coalesced with the corresponding helpers r8168_mac_ocp_write_seq() and
> r8168_mac_ocp_modify_seq() into sequential write or modidy with a sinqle lock/unlock,
> these calls reduce overall lock contention.
> 
> Fixes: f1bce4ad2f1ce ("r8169: add support for RTL8125")
> Cc: Heiner Kallweit <hkallweit1@gmail.com>
> Cc: Marco Elver <elver@google.com>
> Cc: nic_swsd@realtek.com
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: netdev@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Link: https://lore.kernel.org/lkml/20231028005153.2180411-1-mirsad.todorovac@alu.unizg.hr/
> Link: https://lore.kernel.org/lkml/20231028110459.2644926-1-mirsad.todorovac@alu.unizg.hr/
> Signed-off-by: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>