Received: by 2002:a05:7412:85a1:b0:e2:908c:2ebd with SMTP id n33csp105818rdh; Mon, 30 Oct 2023 15:36:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHxBX+zTjzsud7SnEMb7AkQtQQ0xg20dBkkCanqljEXDBFOK7LA/l+SocyhpjfOPt0aerbm X-Received: by 2002:a05:6a20:2447:b0:134:2b31:e2a9 with SMTP id t7-20020a056a20244700b001342b31e2a9mr10333368pzc.0.1698705410847; Mon, 30 Oct 2023 15:36:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698705410; cv=none; d=google.com; s=arc-20160816; b=vE4UPcPxLBesukUE4T3a9vqZlQpQFHl+BLWfVmetJnYMvz5avjTWftleLjDTDTQBHO GLAJ5ZG4zluMk3AxBz8byXQKHOBQa1Hp7ksLnE1T/s6f/Ubci7JHURh0ORfvn/LjsAQo c5IBYBEHh/BK267oXfItW/E0JSEaarH07WKICvrDjdsMYqcem6U3J1cZV1XtL+TaJhWe KMctvUD4KlrG8579CLEq/8rks7iHbcLS5uI6HClboI+2aPSBXr6IW2Dyej/+1ILvMkvm fUBc9ZuGwjRYQIJK/7kMCjYgc+lFS0IRERoVgBs7GWQhcKM7wGM8pnYmf81T8DQbIWmy bW9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:dkim-signature:date; bh=aGKhGcA7hoykm4opZ2dFmPkeWp+rME4yNLwrlH1CA4Q=; fh=dGSA/iw+yc6GlXS9ru2PSErHn/yeaGf7FR6SD2A8UEE=; b=BqbZDVCEiWkY8Rx66FRFi77ll65AMRr8NXDSkDN7nh4TDPbuygzIauEZbJNQ9ezGBI jV/nSuq81SME5v3spEImY15Yia9D3rt4ATCBEx0PQdn1DQoba5rXk/OL+EAwZ1sAgOpz zQNsWrmMoNGLZRtso5LuUeJNy6MKTum/mUEW6NmX5/ntn5WWQEnskysrSnAQwGl31fzO 1aEqRtKdmput6c9hB7ZtU2bvFXOc+85RVHpgsF7/OeP5SnJRRBh45JduVHfYjmRs2gYQ RKfX38NdVCMxrOIUSatdTGaFeAsBDfLeBKWSvGSdUmYLkywQ+tAP/qox4UULtZW1sIv2 VDnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=PoUuMClX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id fb38-20020a056a002da600b0068fb9c0bb07si53832pfb.13.2023.10.30.15.36.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Oct 2023 15:36:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=PoUuMClX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 6C461807280E; Mon, 30 Oct 2023 15:36:09 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229944AbjJ3WgD (ORCPT + 99 others); Mon, 30 Oct 2023 18:36:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229672AbjJ3WgB (ORCPT ); Mon, 30 Oct 2023 18:36:01 -0400 Received: from out-181.mta0.migadu.com (out-181.mta0.migadu.com [91.218.175.181]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF3A6DD for ; Mon, 30 Oct 2023 15:35:58 -0700 (PDT) Date: Mon, 30 Oct 2023 18:35:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1698705357; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aGKhGcA7hoykm4opZ2dFmPkeWp+rME4yNLwrlH1CA4Q=; b=PoUuMClXCdoxxX6TuVKOZMEUxAGomGwPfc5ZAGnDuZxutO+VlUkE9rrkzJqBpw8/dqSf0U 0F55Lhak0PbjL2xa6QRzY8/dkkf6InOk/g5MBdAL2rMCaU3l47JaL4S9X1B1hJFaEWuinI uSqsA3NMo0LIflvFjOaNuSRjBAfMoZw= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Andy Shevchenko Cc: Andy Shevchenko , Suren Baghdasaryan , akpm@linux-foundation.org, keescook@chromium.org, rostedt@goodmis.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 01/39] lib/string_helpers: Add flags param to string_get_size() Message-ID: <20231030223553.b246qs6qnibudhbv@moria.home.lan> References: <20231024134637.3120277-1-surenb@google.com> <20231024134637.3120277-2-surenb@google.com> <20231024194653.c24qbnk6bx3hep6y@moria.home.lan> <20231026184456.q6ocnmpq6jhqi7zi@moria.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 30 Oct 2023 15:36:09 -0700 (PDT) On Mon, Oct 30, 2023 at 10:07:43PM +0200, Andy Shevchenko wrote: > I don't think I bikeshed here too much. This is the regular asking the > reviewers and/or maintainers usually do, so is it too hard to split? Excuse me? You were objecting to the new approach making it impossible to add _octal_ support, and your proposed patch split was completely broken. Are you trying to be more reasonable now...?