Received: by 2002:a05:7412:85a1:b0:e2:908c:2ebd with SMTP id n33csp120438rdh; Mon, 30 Oct 2023 16:12:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFTRsYA+nxMhiToaBIDUxfcp2Vxy0E5frVogPlPk++Dns3PZyuIlRjkcMXqiS96/A4c/hTT X-Received: by 2002:a05:6a21:328c:b0:159:b4ba:a5bf with SMTP id yt12-20020a056a21328c00b00159b4baa5bfmr11055605pzb.13.1698707552810; Mon, 30 Oct 2023 16:12:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698707552; cv=none; d=google.com; s=arc-20160816; b=SjmFuTd52QtP5J4AOIKiK0ZyZdtSP8vtxjvaS2h4gqSQR5J/4gFCspKViJNIYuuoqn AV+ZHoE4vQWJWGjvOYzVCnFjNbT5dOJvLvQW3gorkuT9ExYYkla0ago6P74t8QZlh3cf 6vsO9B4A+NysQlAF63EBmRzOWft6lv5uMMIX/1cerUopYpYHQAf3rurYuae/uFL1vXl0 q1xk57s6FxsAmXzY3qpbzxXbgPzqHhSG+2RxTYXS6kzv5/vbnoT4LhOXoaI0Wp8zaFh7 0Diucr99Fzi2ZKt5UcBp4rQgk1uYwmGRaaYJB8+AGlW8M178cW3Vuv13i7jByJ5BRgQ9 e5RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=WGr7gy8kOteEp5Y91mfSF0OEQx3erWbimD8/Mcv0sFY=; fh=7sTgL4l5IxDwN+qfPjFbkHPyuOk3OK8dEYGTT0NLMv0=; b=tlUEWhZkV2wM/w1RV/Mhent0whBTQpsAYTFbjqw0I0ArkaxpDgYqy/Tej4WB46BJSR a1LPWo+JCRNHRJTaIubKAEkcuDXfoZ/+URCcslWi5W2lksKVKLfZsv0JiLmxBWoLdPTH YWpcIJBKCm1vSnkfal2wPd0h1RTZgKHnXM6RSxpjDs1W9n+vM3JhLMUcsrZUpUXPXurW h/nn0elEb0R4iSRhPcLDMQN/6LitkZc5etpgaFXm0/djIPWJFD1D67XjZ6y3x4JafN2Q 0XBCdo1Ok0de50k2Wj9aC1ZAuo8cGFPbVlc33oM53xUeKJEIaNxgviFxPkWg5sdON+0c pZRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PpF0uSS5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id n19-20020a637213000000b005b8615b9fe6si113008pgc.287.2023.10.30.16.12.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Oct 2023 16:12:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PpF0uSS5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 6569480B87E6; Mon, 30 Oct 2023 16:12:30 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229849AbjJ3XMH (ORCPT + 99 others); Mon, 30 Oct 2023 19:12:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbjJ3XMG (ORCPT ); Mon, 30 Oct 2023 19:12:06 -0400 Received: from mail-yw1-x112c.google.com (mail-yw1-x112c.google.com [IPv6:2607:f8b0:4864:20::112c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5849DD for ; Mon, 30 Oct 2023 16:12:03 -0700 (PDT) Received: by mail-yw1-x112c.google.com with SMTP id 00721157ae682-5a7dd65052aso51072847b3.0 for ; Mon, 30 Oct 2023 16:12:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698707523; x=1699312323; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WGr7gy8kOteEp5Y91mfSF0OEQx3erWbimD8/Mcv0sFY=; b=PpF0uSS5isybsFqiY9Wj/wQu1OimTVd1wcrpeYZk4SC8V7951zvtLa2KRZGcDEeSUT bxUpDqnQrQUEoJ4/1Cktshv0ovouyStaGscLXLYTRUoG6PY4lbiZfAxrxWoKkpPTXgMb GHmDuVcN+bqsTSfC/BLuhSQ/9ctAgDK+jiMmARhoOpX40bR17bQ4kO6IsQlrHn2n7aps r697GZgq+JztDKPkuEu8xgaaf9rxFiGpJJzAta6G3doEVWTgOMn5DtVfmvKBNuYvGd81 PQlXxmm6XTF1mR2TVv3k7emaICXZEN5G2MGhv9IRQid2T99qUuzaygMAVyT0DhymswUR aPxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698707523; x=1699312323; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WGr7gy8kOteEp5Y91mfSF0OEQx3erWbimD8/Mcv0sFY=; b=OkCaV29gAZx+TXVsJTLxkNd59O2VIQzfFXHeNg+8FSxysVT4mx4vWjaj2nEyZ8icre TQXt0bfAm6yf54jlzb7HpCjC+RscaIZLI0oCfSN3zOvUvjK33cOt3MpuuR8tS8Ah1nUw fkJbCy7Xl98baM7Odlldqa8bUWfPfyKFMq3vaAy/IEiWS2xfNNPE01q4rSYUbN9EZUG7 MINHFYa4wzljI/nxsRaPqssLIXELtawF+xAQE24koHSq/ClWPFd0ili+Ld4QBlJC+cWz JrXn/AzDlaLuNJo1M3o7K1jE1C8lFv3x7kEXCxLEti9Sapk9PzoWYfRsQWkvGh4PtNyQ aiMg== X-Gm-Message-State: AOJu0Yy/+TDkD2QeSODs7HB9WLjYKpTk2hEn0c7xpg8/tpdJTlA4dfEa 12IMxpJIItMti+/uMRx5DNkoxuQuig+5FXkpULXa4w== X-Received: by 2002:a81:c64b:0:b0:578:5e60:dcc9 with SMTP id q11-20020a81c64b000000b005785e60dcc9mr10288103ywj.10.1698707523065; Mon, 30 Oct 2023 16:12:03 -0700 (PDT) MIME-Version: 1.0 References: <20231030-fix-rtl8366rb-v2-1-e66e1ef7dbd2@linaro.org> <20231030141623.ufzhb4ttvxi3ukbj@skbuf> <20231030222035.oqos7v7sdq5u6mti@skbuf> <20231030230906.s5feepjcvgbg5e7v@skbuf> In-Reply-To: <20231030230906.s5feepjcvgbg5e7v@skbuf> From: Linus Walleij Date: Tue, 31 Oct 2023 00:11:51 +0100 Message-ID: Subject: Re: [PATCH net v2] net: dsa: tag_rtl4_a: Bump min packet size To: Vladimir Oltean Cc: Andrew Lunn , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 30 Oct 2023 16:12:30 -0700 (PDT) On Tue, Oct 31, 2023 at 12:09=E2=80=AFAM Vladimir Oltean wrote: > On Mon, Oct 30, 2023 at 11:57:33PM +0100, Linus Walleij wrote: > > This of course make no sense, since the padding function should do noth= ing > > when the packet is bigger than 60 bytes. > > Indeed, this of course makes no sense. Ping doesn't work, or ARP doesn't > work? Could you add a static ARP entry for the 192.168.1.137 IP address? ARP appears to work, and also DHCP then (I reconnect and restart the interface before each test), so it's really weird. I'm trying your suggestion to skb_dump() before/after. Yours, Linus Walleij