Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Date:   Tue, 31 Oct 2023 09:39:10 +0800
From:   Yujie Liu <yujie.liu@intel.com>
To:     Steven Rostedt <rostedt@goodmis.org>
CC:     kernel test robot <lkp@intel.com>, <oe-kbuild-all@lists.linux.dev>,
        <linux-kernel@vger.kernel.org>,
        Yoshinori Sato <ysato@users.sourceforge.jp>,
        Rich Felker <dalias@libc.org>,
        John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
        <linux-sh@vger.kernel.org>
Subject: Re: arch/sh/boot/compressed/misc.c:118:6: warning: no previous
 prototype for 'arch_ftrace_ops_list_func'
Message-ID: <ZUBavpdmbsMvbHrr@yujie-X299>
References: <202310310611.5RteDpO7-lkp@intel.com>
 <20231030183722.21712d18@gandalf.local.home>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20231030183722.21712d18@gandalf.local.home>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YscuTze1MhexXMiJTZgKHMtN9Ww+RHucAoeGhD02+bkM2k3wYX4E2TlPTEhY?=
 =?us-ascii?Q?3qQHF5WaTM7GJN3gOYGMWBvG7VJVbo3Rvp1Ef70X7H23U12pZwkBSAOZrB6H?=
 =?us-ascii?Q?BYyiv5riMY6Zf0jKkx3Vdv1YLGiLMXGI31VKBog/vP3CoPa3Siu3N/Bn5T6q?=
 =?us-ascii?Q?epAxpYaITznYA/BYJkQ3d5l/D2brC8SvHzh6NBaiyIWw7XrtVB10u2nD4BUG?=
 =?us-ascii?Q?HvQo7CliwysFLYIGWi5hsUv0XiiOrYKWnPLPLTu6fT45jHxAlBorO8gfZVqK?=
 =?us-ascii?Q?cII3HSFWYAtkD13zKAmLbuFBdudasU3OYlOsuFh7XFszCH6VMiVcfu9hGl9E?=
 =?us-ascii?Q?Pa8MD2NUcFfZbEfGSebxFdw2l1PskOtzhZC8+3pfzkf8LI3xOTFCj96hFDT0?=
 =?us-ascii?Q?yP2u6zwBEYXBbAgEVCjb5UOc2lOBOKMqYbPQP+y+2BkcAJm0lp4++pfFp+BG?=
 =?us-ascii?Q?+5W/Cz7mywP/bBG1tNvjD42uZHXv9ACqOPwvskXsTNo29W8qkqjuR+5FC/vt?=
 =?us-ascii?Q?LPyOPJAuvSheVK5n/rGujPuBxZHcJg84z4XZiSSJBLcVhkHmiy2MMTGsYCH7?=
 =?us-ascii?Q?SfyHQHNIU773vBzjXdi+VBKGJnkFt0dVR8PFVUsx4vN5Kk8IpoIdZXn+VBAD?=
 =?us-ascii?Q?tL29iJy1u7nIpvDfhCHK1I5Z+T4X0j1Ov+kRXRqIXIsPTs1VPfv2gk7LW86p?=
 =?us-ascii?Q?zIoc4j8EbMMGAXLGtjCLPxRvhGha6v2fF0o0yia/GusfSEC8NnGa8Wrml7nS?=
 =?us-ascii?Q?/6L5+ibx/BcypAl8eNcGdPf1XEeSySAeOyVePgg8venE3UdpVdb/4zi0oAP2?=
 =?us-ascii?Q?XVQluLK5wmksA9Rmuam1kCkqVvwejcditQ2PYUXg7vytgzYsycKlK+OJZUaa?=
 =?us-ascii?Q?S0CGKhltrvvGk4N8HJELnnoYHRsHtOVgPyqZWlBjigC9s9rJJrfNntsmJT2Q?=
 =?us-ascii?Q?e2ZaTIov45iASXXrhMACQOen0xHkIEtgNJNn3/BshgZEdPZ7WT1ymmmQYO+Q?=
 =?us-ascii?Q?fdtBFONVVzg8CvfEnqDxZD4kDnmBXtgiTRBAQXMEShFjZGZ3mMn2FH0h7kXJ?=
 =?us-ascii?Q?eeoTNP9/OgBVE7av3jctuSXQQv+gw0qp/TxmUvKrR7PgvI+YGjhlrMfo5XIR?=
 =?us-ascii?Q?ONID3+z5tF10+b9liPB7Z8oTPcDf7qUPy6IbtvNhzmTqMv2aO27HvZ5O/Wme?=
 =?us-ascii?Q?VK1TFEA6rtVXLSK+B8LVEAO2LoP0lphfeOPaoz4RE1ta0FJBiNTOernlMs/8?=
 =?us-ascii?Q?TK56an5X/UbmEdphSMNz0z1Ys2a5n3pMMEhR2KD2ZkLSoucq5YISsq3iaLKa?=
 =?us-ascii?Q?hp9x9bD24o88NUR79F6N1FdMX/UNQhIgAsiBwpY21wx52lswxdQ5WYwgykE0?=
 =?us-ascii?Q?83CV/wzqm6ZC2mZJGEPKMqHtGJgnMbSx/kCAH/jdFvAIJxX9tVym2rFsCDtN?=
 =?us-ascii?Q?mnj32Hltk4IdjIB45L4kXtqqsnmTz7Dxa3IiZx1raFvgqTmWgHyC2ypVPfBI?=
 =?us-ascii?Q?cxXU6exI1XDW54Aip5aUyHg7NhE2y8vmj/gbFzia1TPqt9Lu0NzDcIpMh7dZ?=
 =?us-ascii?Q?BmPPDGrqZX/PeA69BWrIy9WhV4dO576upBERjtDg?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6dc9f114-e2c5-4105-de9f-08dbd9b2d857
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6392.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2023 01:43:56.9130
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: B6DAXn7bRjLa7YMljz9tQ3TOI1BukdIIYpbfag0L6VSJgwf8VnS0/1wK6YN65rPYXp8T9nK7y+sKdP5lUNNlUQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8230
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 30 Oct 2023 18:44:22 -0700 (PDT)

On Mon, Oct 30, 2023 at 06:37:22PM -0400, Steven Rostedt wrote:
> On Tue, 31 Oct 2023 06:15:04 +0800
> kernel test robot <lkp@intel.com> wrote:
> 
> > Hi Steven,
> > 
> > FYI, the error/warning still remains.
> > 
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head:   14ab6d425e80674b6a0145f05719b11e82e64824
> > commit: 17b251a290ba84a0c2c5c82df9596cb2e7207ca6 ftrace/sh: Add arch_ftrace_ops_list_func stub to have compressed image still link
> > date:   2 years ago
> > config: sh-allnoconfig (https://download.01.org/0day-ci/archive/20231031/202310310611.5RteDpO7-lkp@intel.com/config)
> > compiler: sh4-linux-gcc (GCC) 13.2.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231031/202310310611.5RteDpO7-lkp@intel.com/reproduce)
> > 
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202310310611.5RteDpO7-lkp@intel.com/
> > 
> > All warnings (new ones prefixed by >>):
> > 
> >    arch/sh/boot/compressed/misc.c:109:6: warning: no previous prototype for '__stack_chk_fail' [-Wmissing-prototypes]
> >      109 | void __stack_chk_fail(void)
> >          |      ^~~~~~~~~~~~~~~~
> >    arch/sh/boot/compressed/misc.c:115:6: warning: no previous prototype for 'ftrace_stub' [-Wmissing-prototypes]
> >      115 | void ftrace_stub(void)
> >          |      ^~~~~~~~~~~
> > >> arch/sh/boot/compressed/misc.c:118:6: warning: no previous prototype for 'arch_ftrace_ops_list_func' [-Wmissing-prototypes]  
> >      118 | void arch_ftrace_ops_list_func(void)
> >          |      ^~~~~~~~~~~~~~~~~~~~~~~~~
> 
> As the comment states, this is needed only because the linker script
> vmlinux.lds.h references them, and it will not build without it.
> 
> If someone really cares, they could simply add a header to quiet these
> warnings, but seriously, these functions are just stubs to allow the sh
> boot portion use the vmlinux.lds.h linker script. These stubs are only for
> satisfying linker references and are not used. I'm not going to be the one
> to bother "fixing" it.

Thanks a lot for the details. We've configured the bot to ignore this on
the reported commit.

Best Regards,
Yujie

> 
> -- Steve
> 
> 
> >    arch/sh/boot/compressed/misc.c:128:6: warning: no previous prototype for 'decompress_kernel' [-Wmissing-prototypes]
> >      128 | void decompress_kernel(void)
> >          |      ^~~~~~~~~~~~~~~~~
> > 
> > 
> > vim +/arch_ftrace_ops_list_func +118 arch/sh/boot/compressed/misc.c
> > 
> >    113	
> >    114	/* Needed because vmlinux.lds.h references this */
> >    115	void ftrace_stub(void)
> >    116	{
> >    117	}
> >  > 118	void arch_ftrace_ops_list_func(void)  
> >    119	{
> >    120	}
> >    121	
> > 
> 
>