Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <131c8e8d-94f8-e0e9-5a1a-336b1ef84509@yunjingtech.com>
Date:   Tue, 31 Oct 2023 10:16:57 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH V6 2/3] pinctrl: Add support pin control for UP board
 CPLD/FPGA
Content-Language: en-US
To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     lee@kernel.org, andriy.shevchenko@linux.intel.com, pavel@ucw.cz,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
        linux-leds@vger.kernel.org, GaryWang@aaeon.com.tw,
        musa.lin@yunjingtech.com, jack.chang@yunjingtech.com,
        noah.hung@yunjingtech.com
References: <20230915031123.14515-1-larry.lai@yunjingtech.com>
 <20230915031123.14515-3-larry.lai@yunjingtech.com>
 <CACRpkdbi0bS0yiJ9ac6Z44os0w6FyKm+UsvbgQEYzYKymjww-w@mail.gmail.com>
From:   larry <larry.lai@yunjingtech.com>
In-Reply-To: <CACRpkdbi0bS0yiJ9ac6Z44os0w6FyKm+UsvbgQEYzYKymjww-w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dHBtNXdGSmZwVjdoSy94bFlmM3VBVER3YkFjV1VEdUNZWU1sdzBtS3ljLzR0?=
 =?utf-8?B?VjBiQ0xWSHZUeGNDR0tXZENhaU5RVnR6VjQxaWlIQ2ovU3NjeG15b3pwdGpl?=
 =?utf-8?B?L3V1UTJaWm5mMGNKVG9HSDRWOVVrZUhYbkluR0xYSzhoUGRLbzJNOEpta3I0?=
 =?utf-8?B?cHBuUk9yQWZ4Q2hkWEx6TTI0djhEN0dPR1BFNHBadWpBVU1qcmR0ZzJvcVVN?=
 =?utf-8?B?TmM0ZGZHdC9zT09hR1BKR1BML0c2T1lTNDFUWXp1aDVtVGxGMUYvYWV2Tyt6?=
 =?utf-8?B?NkY4RzdLdzFwaHlwTjVmQ1prS2NFSUxySFIreWEva1NJVWxkQkpWd1NLeEtj?=
 =?utf-8?B?OVVhcTR1V1lhMm1qRGY2K1Nham1hcXBDQ3BOeGhnVW5mdEJwRy9hVk5kQkYr?=
 =?utf-8?B?eVVNVWsxUjFsa1ZzL3FCS0U5amRzYTRxWDVVTjh1UHdNSVpGQzQ1YnNGUzVp?=
 =?utf-8?B?dW5rQ2QrVER5a2ljb2lBcUdrNjdKTW45ckNZYk05V3JIOThCdFBQUzRwVDMz?=
 =?utf-8?B?YXRmb2xsQmY0S0ZzeUpualFIMm4wSkdWWXVRcERXeDVTcjZxNXNHd3FPNnhK?=
 =?utf-8?B?Z1dkVTBFcnFIeVE3bGhVbmtLUE1TcTBOcmFaMWNqQVJwcGkxVWhJNmF1bmZi?=
 =?utf-8?B?eHBhdXZYYXQ3MkpZb1hPV1ZUeFAxNjNoTGxzZFZ0S01iTzQ3NkFPTWpKSTF4?=
 =?utf-8?B?OTlxaStpYkFkcDVhdGRmMElxYzJ1S2JuNnU5M1RpNUcrcWQzc2dobFNuYWVS?=
 =?utf-8?B?cUQrd1RjTXlWdzBiNEV1NVEzMmJqZkF4Yjk2YVBleTcza0ZaeGVSKzc1amxN?=
 =?utf-8?B?ZWxWdUJoclpWTC9JVWFhblIrMS9jVGlLVlhQaHd3a1ZGa3RxVUFLUDBWSFYy?=
 =?utf-8?B?SmJQWmJQOXJJSTcwQWhyVkxpVGNDVUlDTngxaENaNTJVdC9vUWZYOEZkbW5N?=
 =?utf-8?B?YnRkQnh5b0ZkU2ROaE1rTnNMbjVDMThlSjN4OS90WWZyVENmVnhZQTA3RDI2?=
 =?utf-8?B?UGtCTEhtU0NhaFNiYU5zRlQ1M1JvZ0c0T01OMTNLUFNwMGN0aGgzSWR1cWdx?=
 =?utf-8?B?c0pyd25Nc0hlakhycmZSV1dzWUo0T3E3Qldad2diakprZWx4Q01iaHVYVXRa?=
 =?utf-8?B?VzZCeWgxalpaUEcrYlNTVGovWDZXdjFoRUZ0R0IyTFNES2NEQmwyZ0xGQ29z?=
 =?utf-8?B?L21UVXViMDFBWTNjMXppd1JacG0zdG92U3QrUE1YQ1FvTDVtZzlpUGZ6dFRH?=
 =?utf-8?B?bURucFBvWDl1ZWc2VHp3SGFyUWZHYzNrQ3p0MURHMWFmNHlTNmROcFpQWEwv?=
 =?utf-8?B?bDJqU0s3NkdkR2ZaSzd3QktuS1BQRmk1cVN4Y3hUaUVrNGxmNWlPcmk0VUs2?=
 =?utf-8?B?QnorSm1zS244SXNUbm1HNUgzb0J6OTRyM3hmd0hxRk9xam9IUksxTk9vYzlj?=
 =?utf-8?B?bzFndENOM3BVSEtHaVZNTUNBOUJSWGRuOXBKNEM2WnFjSWF1VnRadWZaYXJI?=
 =?utf-8?B?SXhqSHJBUzNLQjdNbGpWVEk3Q055TUsvRjhnUXZzZW15L3V0b21YK01uZkFZ?=
 =?utf-8?B?Si8wcWRGQmFVdHB4NkEycWN4MFJ6ZGFmRndSdXFpTGdDTDZhQ0lkVG1RNC9J?=
 =?utf-8?B?Syt6TG52Y2xNOUcyODhwK0tBY21obzZrSlVZWWR4NU1RZUNTRUkrNTBPTUpQ?=
 =?utf-8?B?VmZLaFVVc3JOaWdwT05VcitodXBKV3IxekIyZ3VCS0k2aXB4eDZrSlp6cHlx?=
 =?utf-8?B?Y1l2RGhjSjdFeThMTDZZTWw4cmxtNjRlUDZzR2EzR0pJZlZHVGVHc2Z1dmxv?=
 =?utf-8?B?a0JGeEdFV0V0ZWRPaVpzOXN4NkYzUXdXQlB2ZG5obGFmR0hqRkpmZVMxRGYv?=
 =?utf-8?B?VHlTVjBpRyt0TlRmTTZaRHB0b0dORGtSTnZKcC9NdHRoaGdHZmxOVTV2dVNm?=
 =?utf-8?B?VmN3bEoyMDdTeHh3Y2tvR01UM2ladFlYano2alhRelBWRS85UHB3bEFUaDdG?=
 =?utf-8?B?UkhUN09TRGpwdzRVbm5xRSt5VDIxemFWeDdrQit1eWdmM1lZVE80YlFoeWFS?=
 =?utf-8?B?M0hIR2habjlrdGt0RHdnSm1HRmZwQzQ1b3AyZEd3U0tJMmJRV3A4eCtzV3dl?=
 =?utf-8?B?QVorZWk3dW9zMEkyUHBpVVZpZmhKNm1NV2NUUlAzQ1V6WlVpcjkwbmVMY0dS?=
 =?utf-8?B?aUE9PQ==?=
X-OriginatorOrg: yunjingtech.com
X-MS-Exchange-CrossTenant-Network-Message-Id: da3a3755-6211-4807-ff44-08dbd9b77731
X-MS-Exchange-CrossTenant-AuthSource: SEYPR06MB6507.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2023 02:17:00.6538
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: be2d5505-f7e6-4600-bbe2-b3201c91b344
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MGV+swqsDBA3YfPTMyq8YKencTcUTM14EYlrx4vPyL8Wn3C9ilzWepBe9REBopOpOPD3/h9iqv4oFW5+svaWn4ZI7fJCdbHYKrnlFsXlEOo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB3987
X-Spam-Status: No, score=-3.5 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLACK
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 30 Oct 2023 19:17:21 -0700 (PDT)

Hi Linus,

	Cause we replied the wrong email-format to you last time.(Lee informed
us that format is hard to read), so we send the comment again, thanks.

On 15/9/2023 17:02, Linus Walleij wrote:
> On Fri, Sep 15, 2023 at 5:12 AM larry.lai <larry.lai@yunjingtech.com> wrote:
> 
>> The UP Squared board <http://www.upboard.com> implements certain
>> features (pin control) through an on-board FPGA.
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Gary Wang <garywang@aaeon.com.tw>
>> Signed-off-by: larry.lai <larry.lai@yunjingtech.com>
> 
> This v6 overall looks good to me!
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> Can the patch be merged on its own?
> 
>> +#include "core.h"
>> +#include "intel/pinctrl-intel.h"
> 
> Didn't notice this before. But if Andy is OK with it, I'm
> OK with it, I guess there is a reason? Perhaps it warrants
> a comment explaining why you do this?
Need struct intel_pinctrl gpp information to control dedicated Raspberry
Pi compatible GPIOs.
These products (Up boards) are Intel approves foundation kits.

> 
> Valid reasons:
> - You are using Intel-specific HW features also found in this
>    FPGA
> 
> Invalid reasons:
> - Using nifty macros or helpers, then either make them generic
>   or (if they are small) duplicate them.
> 
> If it was that thing I asked Andy to keep locally because I didn't
> agree with its generic usefulness, maybe I should be told to
> reconsider.
> 
> Yours,
> Linus Walleij