Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
MIME-Version: 1.0
References: <CA+g2S9pkFLRV1foEHpEkaRwjMKOVQTxJrM=-sQsqoud92_WNFw@mail.gmail.com>
In-Reply-To: <CA+g2S9pkFLRV1foEHpEkaRwjMKOVQTxJrM=-sQsqoud92_WNFw@mail.gmail.com>
From:   Jeff Xie <xiehuan09@gmail.com>
Date:   Tue, 31 Oct 2023 11:06:22 +0800
Message-ID: <CAEr6+EB=zLULsL7whcS1aaCjctec2iasQ2+B1NXDxMXEKkTBoQ@mail.gmail.com>
Subject: Re: Update objtrace usage in Documentation/trace/events.rst
To:     renhai_lenovo <kean0048@gmail.com>
Cc:     linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-trace-kernel@vger.kernel.org, bagasdotme@gmail.com,
        "corbet@lwn.net" <corbet@lwn.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi renhai,

On Tue, Oct 31, 2023 at 10:46=E2=80=AFAM renhai_lenovo <kean0048@gmail.com>=
 wrote:
>
> Documentation: trace/objtrace: Move the line entering the trace
> directory to the first step, so that the commands in the first step
> can be executed smoothly.
>
>     Signed-off-by: Renhai <rh_king@163.com>
>
> diff --git a/Documentation/trace/events.rst b/Documentation/trace/events.=
rst
> index 52ac8ca8ab64..d5fadf7966de 100644
> --- a/Documentation/trace/events.rst
> +++ b/Documentation/trace/events.rst
> @@ -583,6 +583,7 @@ The following commands are supported:
>
>    .. code-block::
>
> +    # cd /sys/kernel/debug/tracing/
>       # echo 'p bio_add_page arg1=3D$arg1' > ./kprobe_events
>
>    Secondly, we can get the value dynamically based on the object:
> @@ -597,7 +598,6 @@ The following commands are supported:
>       # echo 'objtrace:add:arg1,0x28:u32:1 if comm =3D=3D "cat"' >
> ./events/kprobes/ \
>         p_bio_add_page_0/trigger
>
> -     # cd /sys/kernel/debug/tracing/
>       # echo 'p bio_add_page arg1=3D$arg1' > ./kprobe_events
>       # echo 'objtrace:add:arg1,0x28:u32:1 if comm =3D=3D "cat"' >
> ./events/kprobes/p_bio_add_page_0/trigger

Thank you for your interest in the objtrace function. I am currently
busy with other things.
I will come back soon to update this function. When I update it, I
will add your suggestions.

--=20
Thanks,
JeffXie