Received: by 2002:a05:7412:f589:b0:e2:908c:2ebd with SMTP id eh9csp1069rdb; Mon, 30 Oct 2023 20:38:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEd9e3Nwnv2X1+3JHMoB5TU/F3MrUcX1QXfh+ysHVQFsjJmt4dRBfPXShf4SItdWgVXhLf8 X-Received: by 2002:a17:903:68d:b0:1ca:7439:f74f with SMTP id ki13-20020a170903068d00b001ca7439f74fmr10692735plb.60.1698723491786; Mon, 30 Oct 2023 20:38:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698723491; cv=none; d=google.com; s=arc-20160816; b=g9pp0yDiufkNLlHnbLQVyb4r627v2uxTp7MeewDAr9M30YONaHIO9kKGo+3HgaLOHR R+8ZGe+gLv68sXzhfP/xDxOhaeqWkzL1CUciZVrnPgzY8e5M0je3xASgQ+CZYUpCwGns cgv/hZrSRFXod+/tPSuOq1sNimVugiXTfLOFiF7EDzNoItVoSQhOppRDnvmzoAzQIzlL OZkuTF9mn06rEEwLq3ak6+Aejee4hTr1dUhkbmasL+bxIU+y8bMeuENO5RAiJH0TfGOj PboAO7dHQr1M/5xQhWfTNyVGdU97U0nfn8PyBNW8/8UNcqKmvhKOggf+p81sdU//59qe sYPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=zvYVTOxygpDMFxEkA+0MFbz5lSVNPQro1gFBUZN0XI0=; fh=1AQU5DnzwTxAkf4UZhcdiEYCfu4wUMyhuUDgRJ4psVQ=; b=JI6AP0CEr4lrhw+Z/45lZaJtPXi3+Xw1/LMPZRN+UKPt7Fp0mR8cigCB9GRlJOYh2J inqUwsDj7UeudL4HCBYM7tQFzrxJ4HcLw7uTcMnz0ifbst02pi4gExkT7ECGctR0YVw4 yU+x2UEhPpO7rwYkwlqYya7wvSHIKceCIeJGDmTGpW7sREt/ZRDlniHm/JqbAoYkwxi5 WgGcfr6c5hzHXhE3gECesNSNibu/85ukT+OIKkIf6VXBiB1H8p8pNIapRPiQ0+InnLED RPicUVwUQZgLU28+mbBfAvfXr4nphIEWt0NLBAv9ielMF/6uDJy5Mao1qZ8ZSVR6arFa 3xUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=gtNj++HV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id v12-20020a170902f0cc00b001cc662945e1si359710pla.589.2023.10.30.20.38.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Oct 2023 20:38:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=gtNj++HV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 8EA1880AEB04; Mon, 30 Oct 2023 20:38:09 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234748AbjJaDh6 (ORCPT + 99 others); Mon, 30 Oct 2023 23:37:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230084AbjJaDh5 (ORCPT ); Mon, 30 Oct 2023 23:37:57 -0400 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E70FBD8; Mon, 30 Oct 2023 20:37:54 -0700 (PDT) Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1cc1ee2d8dfso34673105ad.3; Mon, 30 Oct 2023 20:37:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698723474; x=1699328274; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zvYVTOxygpDMFxEkA+0MFbz5lSVNPQro1gFBUZN0XI0=; b=gtNj++HVI+K+uUAfToiLMex6al1Y570sFOiiZSjqIJ0+aSfVJNQyoZGTFTyG4Mf7Zm BYOCGxYZKKGfjCdrtk5JX+d3sYBi9x4wfqC87KkBPv+ZB7i3Gsimb1M/t1NqY7q4j2vc Gp6YxHn/jW0x07YdN+E4aEv7QGX6MQ9KmSCpHPR3yBLWCB3I4mmT76GPdBXofmLh8x6H SjejTZBPpEvMaa6e8vkU1M3ffIVnglIcoNtuKBMaUO2pnbmLA/1Y9yAhWV6wBaQTEBKW PmAzlB/N8Bb5rZVS+3SzhYEugOY302PzPYG1SpsYwmaLd338DLByaGSN8LgGUgz1+C4u L1Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698723474; x=1699328274; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zvYVTOxygpDMFxEkA+0MFbz5lSVNPQro1gFBUZN0XI0=; b=ncgKc9oCtEv1rNXniBGPY4fRJWJvzYdK72m0/sKmGsoo4WaG6Ge6msvOVRihc/fkGd LVAl5r5nGvAk34POn/KW/2nq96Lx5yDoiUUUiaUfPpS5fv3tKwKLN7TdBNg71Yeh8xPl pxTKYhuF43g0BD+t8KBznVmqzXZEzXwU2pQ0goMZwreJHWxEP9/VuuIng7Pi+SboiYbK dEtYxBWTuBQG5bkS3/hE8fi35yEhzO/NhHBxl+lEMgHR934cACdoegVWnnTibnTMlvlP N7iyzNVF5Eg79Yhx/rzDmtCyZd32fCWkSDcNcbrHFfQRQKTQobRqKsIVsx0z/jl2089w LOKQ== X-Gm-Message-State: AOJu0YzfUVy1GH5Ddselq+1Qxud10Ug/lgEo3aBs4FKZ0hEmw6uTNhqv kbTStrVgsOqbK0qcfVaJ+cU= X-Received: by 2002:a17:903:32c3:b0:1cc:45d0:470b with SMTP id i3-20020a17090332c300b001cc45d0470bmr6573426plr.7.1698723474158; Mon, 30 Oct 2023 20:37:54 -0700 (PDT) Received: from [192.168.1.3] (ip72-194-116-95.oc.oc.cox.net. [72.194.116.95]) by smtp.gmail.com with ESMTPSA id ja1-20020a170902efc100b001b895336435sm239276plb.21.2023.10.30.20.37.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Oct 2023 20:37:53 -0700 (PDT) Message-ID: <0d4cd98f-6f5f-4fc3-b55d-c1351054b667@gmail.com> Date: Mon, 30 Oct 2023 20:37:51 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v2] net: dsa: tag_rtl4_a: Bump min packet size Content-Language: en-US To: Andrew Lunn , Vladimir Oltean Cc: Linus Walleij , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231030-fix-rtl8366rb-v2-1-e66e1ef7dbd2@linaro.org> <20231030141623.ufzhb4ttvxi3ukbj@skbuf> <20231030222035.oqos7v7sdq5u6mti@skbuf> <20231030230906.s5feepjcvgbg5e7v@skbuf> <494a8bb7-7ca1-40bd-b3a7-babeadfd88a0@lunn.ch> From: Florian Fainelli Autocrypt: addr=f.fainelli@gmail.com; keydata= xsDiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz80nRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+wmYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSDOw00ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU8JPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJw== In-Reply-To: <494a8bb7-7ca1-40bd-b3a7-babeadfd88a0@lunn.ch> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 30 Oct 2023 20:38:09 -0700 (PDT) On 10/30/2023 5:37 PM, Andrew Lunn wrote: > On Tue, Oct 31, 2023 at 01:09:06AM +0200, Vladimir Oltean wrote: >> On Mon, Oct 30, 2023 at 11:57:33PM +0100, Linus Walleij wrote: >>> This of course make no sense, since the padding function should do nothing >>> when the packet is bigger than 60 bytes. >> >> Indeed, this of course makes no sense. Ping doesn't work, or ARP doesn't >> work? Could you add a static ARP entry for the 192.168.1.137 IP address? > > Probably the ARP, since they are short packets and probably need the > padding. Does this also mean that there is a general problem with unicast packets, and that broadcast packets happen to work by accident? Could you check whether a broadcast ping (ping -b) size sweep is immune to what you are reporting? -- Florian