Received: by 2002:a05:7412:f589:b0:e2:908c:2ebd with SMTP id eh9csp45780rdb; Mon, 30 Oct 2023 23:10:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGLibnHqKUmIhaXcxem/6Brj74wJ4oBm78KHjT/LSZbO+BgAvJG5f4GDMUpyPPgXREv+qgt X-Received: by 2002:aa7:c494:0:b0:53d:e5d7:4148 with SMTP id m20-20020aa7c494000000b0053de5d74148mr10767935edq.1.1698732650496; Mon, 30 Oct 2023 23:10:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698732650; cv=none; d=google.com; s=arc-20160816; b=LdqjgLmo/Qpvoom3SKKnCDbg9T5M/k/RrRIK9D3M73yet+fiu4Wsg5Wt7+Noux06aT aaOhdAjrMt3jSC/I+oIv9JmAnSbE0Y12ULbBMb03snhw4HfBcI+crcWbspltSnnRMBd+ FI3/69/4vpdLlWzajbYuk7PprSvRr9oHTPcqldlTxjelE9a1AUsq/CwYEj0zhwr71iBE EIW/+iFVhinPhPxK0SYmK8fDd4Z9ASZ5i1iL5jvxg4Kfls97TwX8hN+5HS3U6GhYmNKB cqHqDZmMi/ZsI+gVIb3CgG48inatb/2ut+IW/i/ZZMESH9knrK3cVJwgta7dLgZfaLhC Yo3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=DPYAI3OuD48IXFujPT/dWxo6Xl29Z+USlDXrQHPBx9c=; fh=4tCpQkH797KO+tOQH9no1d5LcxDK7XxkMtUYlTQmJK0=; b=tC/ERJ483H5q6/w5Z8s+14xyZe5o/LvH7mxxOofT3I7W+LPI54fHizgYSmLxxy9Zqf nUGNpDlI0TUSSzCxpWSe6ZQaIZ1w8V7tSnVCrYgXclYtoeFSwcx7WzTPCS9s2c5Gow2x PEiXAdGFrGRRnu8eZmb6Nws+IZ1+igNhSvaXyAjWv1asEnB4DUj+AKXf9DZ2DnDFJLp9 xrc4D4fzprFuk1x8khK0nOEcb7LSCVUPgrKr8g2HwvVoFUuwVjQJ+dyDmDHFzb6w5AeF 1WvBW8k/BdJM2uRPUPx0rXrwkXycyLUmKpSxD2ssyq/mIMbB5pyS4EalVLlnucV6xOPS RKUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="eYeN/Zvw"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id r28-20020a50d69c000000b005435375e2a0si327518edi.137.2023.10.30.23.10.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Oct 2023 23:10:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="eYeN/Zvw"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id B20EA80978BD; Mon, 30 Oct 2023 23:08:14 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235237AbjJaGIK (ORCPT + 99 others); Tue, 31 Oct 2023 02:08:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234888AbjJaGII (ORCPT ); Tue, 31 Oct 2023 02:08:08 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57DF0C0 for ; Mon, 30 Oct 2023 23:08:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698732486; x=1730268486; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=9ANZeDcgmHx9iL3ddFW3DF4jmJ3lz3vvm7zaz2lgJJ4=; b=eYeN/ZvwsyiH/0V8KEO60DdIkQv170G8WZhAv4dbKNKZlSj7X/4kFNf5 FDXROcKIi1Tl+mg1iydDVOdQR0uhaE7iLAXCd9iVmkj8mzkfiUh9ko7rQ KueOzzdqa+QYzNNUN1z7WzNhSjrHJ9r0YKF22ICRg2tsmR3mCsKPxzGue I5S0lXuFcOEeW2twgdRA6XPCeAs3T4UTOOcltKVFDg6qRBKXEWundEZzn CZLicsSWOFmNqW21DKPV6XM+QshtpIY49CYeF5TJimGFaF/Il9unV6qaa U+bAowXjAWpc0F5oMZL2NzZBKllLDDQZxFC7CFDOIR9aL2AMq5GnPm8Ik Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10879"; a="1069938" X-IronPort-AV: E=Sophos;i="6.03,265,1694761200"; d="scan'208";a="1069938" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2023 23:08:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10879"; a="904229084" X-IronPort-AV: E=Sophos;i="6.03,265,1694761200"; d="scan'208";a="904229084" Received: from esukhov-mobl2.ccr.corp.intel.com (HELO box.shutemov.name) ([10.252.34.41]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2023 23:08:02 -0700 Received: by box.shutemov.name (Postfix, from userid 1000) id D054E10A2BD; Tue, 31 Oct 2023 09:07:59 +0300 (+03) Date: Tue, 31 Oct 2023 09:07:59 +0300 From: "kirill.shutemov@linux.intel.com" To: "Edgecombe, Rick P" Cc: "Lutomirski, Andy" , "dave.hansen@linux.intel.com" , "thomas.lendacky@amd.com" , "Reshetova, Elena" , "linux-kernel@vger.kernel.org" , "mingo@redhat.com" , "Christopherson,, Sean" , "tglx@linutronix.de" , "Cui, Dexuan" , "Yamahata, Isaku" , "mikelley@microsoft.com" , "hpa@zytor.com" , "peterz@infradead.org" , "bp@alien8.de" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "x86@kernel.org" Subject: Re: [PATCH v2] x86/mm/cpa: Warn if set_memory_XXcrypted() fails Message-ID: <20231031060759.xkiwmwuihqvqjizr@box.shutemov.name> References: <20231027214744.1742056-1-rick.p.edgecombe@intel.com> <20231030082714.pbma2bg2p354cuft@box.shutemov.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 30 Oct 2023 23:08:14 -0700 (PDT) On Mon, Oct 30, 2023 at 04:58:37PM +0000, Edgecombe, Rick P wrote: > > It intended to get upstream alongside with the caller fixes to leak > > memory > > on failure, right? Maybe get it into one patchset? > > Why do you think? Since the callers are smattered across various > drivers, and those changes are now disconnected from the changes to > CPA, I thought to just follow up each area separately. For example I > was going to put all the hyper-v related changes together, but that > part is RFC due to the fact that I can't really test it. The MS folks > said they could help out there. So the different areas were feeling > like separate series. I am okay with doing it separately. I just was not clear on your plans with the fixes. -- Kiryl Shutsemau / Kirill A. Shutemov