Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
MIME-Version: 1.0
References: <20231030083222.28509-1-msuchanek@suse.de>
In-Reply-To: <20231030083222.28509-1-msuchanek@suse.de>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Tue, 31 Oct 2023 15:08:53 +0900
Message-ID: <CAK7LNAQRQ41bXiBFViXE94gObx+3qu5xQxWTXKfO6NYj=v0=9A@mail.gmail.com>
Subject: Re: [PATCH] kbuild: dummy-tools: Add support for -fpatchable-function-entry
To:     Michal Suchanek <msuchanek@suse.de>
Cc:     linux-kbuild@vger.kernel.org,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Nicolas Schier <nicolas@fjasle.eu>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        Naveen N Rao <naveen@kernel.org>,
        Michael Ellerman <mpe@ellerman.id.au>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Oct 30, 2023 at 5:32=E2=80=AFPM Michal Suchanek <msuchanek@suse.de>=
 wrote:
>
> dummy-gcc does not produce the output
> gcc-check-fpatchable-function-entry.sh expects. Add a base64 encoded
> output of the second test.
>
> Fixes: 0f71dcfb4aef ("powerpc/ftrace: Add support for -fpatchable-functio=
n-entry")
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> ---


I prefer this one
https://lore.kernel.org/linux-kbuild/20231030113416.5208-1-jirislaby@kernel=
.org/T/#u


Does it work for you?


>  scripts/dummy-tools/gcc | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>
> diff --git a/scripts/dummy-tools/gcc b/scripts/dummy-tools/gcc
> index 07f6dc4c5cf6..8ab81a905cc2 100755
> --- a/scripts/dummy-tools/gcc
> +++ b/scripts/dummy-tools/gcc
> @@ -73,6 +73,25 @@ if arg_contain -Wa,--version "$@"; then
>         exit 0
>  fi
>
> +if arg_contain -fpatchable-function-entry=3D2 "$@"; then
> +       base64 -d <<-EOF
> +       CS5maWxlCSI8c3RkaW4+IgoJLm1hY2hpbmUgcG93ZXI4CgkuYWJpdmVyc2lvbiAyC=
gkuc2VjdGlv
> +       bgkiLnRleHQiCgkuYWxpZ24gMgoJLnAyYWxpZ24gNCwsMTUKCS5nbG9ibCBmdW5jC=
gkudHlwZQlm
> +       dW5jLCBAZnVuY3Rpb24KZnVuYzoKLkxGQjA6CgkuY2ZpX3N0YXJ0cHJvYwouTENGM=
DoKMDoJYWRk
> +       aXMgMiwxMiwuVE9DLi0uTENGMEBoYQoJYWRkaSAyLDIsLlRPQy4tLkxDRjBAbAoJL=
mxvY2FsZW50
> +       cnkJZnVuYywuLWZ1bmMKCS5zZWN0aW9uCV9fcGF0Y2hhYmxlX2Z1bmN0aW9uX2Vud=
HJpZXMsImF3
> +       byIsQHByb2diaXRzLC5MUEZFMAoJLmFsaWduIDMKCS44Ynl0ZQkuTFBGRTAKCS5zZ=
WN0aW9uCSIu
> +       dGV4dCIKLkxQRkUwOgoJbm9wCglub3AKCWFkZGlzIDksMiwuTEFOQ0hPUjBAdG9jQ=
GhhCglsd2Eg
> +       MywuTEFOQ0hPUjBAdG9jQGwoOSkKCWJscgoJLmxvbmcgMAoJLmJ5dGUgMCwwLDAsM=
CwwLDAsMCww
> +       CgkuY2ZpX2VuZHByb2MKLkxGRTA6Cgkuc2l6ZQlmdW5jLC4tZnVuYwoJLmdsb2JsI=
HgKCS5zZWN0
> +       aW9uCSIuYnNzIgoJLmFsaWduIDIKCS5zZXQJLkxBTkNIT1IwLC4gKyAwCgkudHlwZ=
Ql4LCBAb2Jq
> +       ZWN0Cgkuc2l6ZQl4LCA0Cng6CgkuemVybwk0CgkuaWRlbnQJIkdDQzogKFNVU0UgT=
GludXgpIDEz
> +       LjIuMSAyMDIzMDkxMiBbcmV2aXNpb24gYjk2ZTY2ZmQ0ZWYzZTM2OTgzOTY5ZmI4Y=
2RkMTk1NmY1
> +       NTFhMDc0Yl0iCgkuc2VjdGlvbgkubm90ZS5HTlUtc3RhY2ssIiIsQHByb2diaXRzC=
g=3D=3D
> +       EOF
> +       exit 0
> +fi
> +
>  if arg_contain -S "$@"; then
>         # For scripts/gcc-x86-*-has-stack-protector.sh
>         if arg_contain -fstack-protector "$@"; then
> --
> 2.42.0
>


--=20
Best Regards
Masahiro Yamada