Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <fc113f51-35e9-49ff-8299-e7fc11b81c31@siemens.com>
Date:   Tue, 31 Oct 2023 07:24:41 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] drm/bridge: tc358767: Support input format negotiation
 hook
Content-Language: en-US
To:     Aradhya Bhatia <a-bhatia1@ti.com>,
        Tomi Valkeinen <tomba@kernel.org>,
        Jyri Sarha <jyri.sarha@iki.fi>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Robert Foss <rfoss@kernel.org>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Boris Brezillon <boris.brezillon@collabora.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Francesco Dolcini <francesco@dolcini.it>,
        Sam Ravnborg <sam@ravnborg.org>
Cc:     DRI Development List <dri-devel@lists.freedesktop.org>,
        Linux Kernel List <linux-kernel@vger.kernel.org>,
        Nishanth Menon <nm@ti.com>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Devarsh Thakkar <devarsht@ti.com>,
        Jayesh Choudhary <j-choudhary@ti.com>,
        "Bajjuri, Praneeth" <praneeth@ti.com>
References: <20231030192846.27934-1-a-bhatia1@ti.com>
From:   Jan Kiszka <jan.kiszka@siemens.com>
In-Reply-To: <20231030192846.27934-1-a-bhatia1@ti.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TWQxaGxUaDZPU1lBVXo1RHFTc1llWmhsL1lKRkV2QmJ6WTJ3RXVQZXlmVlc4?=
 =?utf-8?B?OHhTVXcvSGJOdzNkWHR2ODR2elhXTjlOMGh1d3JLWUYxcGh2SUU1VllWV3lP?=
 =?utf-8?B?VXRiRkRyN0ZsaHlJZlVUbThoM0JZUEc3NFFZNGYrYnlBZ2dTUTJFMXRxLzk0?=
 =?utf-8?B?Ni96NUVQNVZvS0VZUjZMQnM5LzBDbU5KOUhVZWhrNGlDUytjY2ZDbDFkV2Q4?=
 =?utf-8?B?QXR1bkoyWDUvMEdhNVo2emJIeXltNUFtRHg2NlpicWNoY2NHazdqYmxGWU96?=
 =?utf-8?B?QXVxV1UwTy9DUkh4Y1NpU1hPNm1YRldaa1VZSXd6Tm5BZFRLdmU4a0tXZklF?=
 =?utf-8?B?UEQ1WTEyUmVRWUpaUG90eTI0ZDRNKzNnYzNjSjRMd09sK0ppUm1uckEwVEt4?=
 =?utf-8?B?cVBITU9RTkdvSGo2aVZXSlQ5OHJPK3E4WkNOTXh4N1cxRVZYSzA3b0Urc1Fy?=
 =?utf-8?B?bTR1eFB3Ri9VWkNrM1dnQjN6VStjeHhaeHlRM3pvREs4ZTl3MkFHVjAxbHVM?=
 =?utf-8?B?dG1JZVRxQ2hNNllmRTg2R09OZU1pcmYzcTYxd2pWdXdmT0p4ZTlBK1Z1TlVw?=
 =?utf-8?B?SFcwVFBzWVAybmVzZS8yTFBzL3o3dkI2WlpkZkgzSFB3bThjMVhHMEJnU1lm?=
 =?utf-8?B?U2JucEhsYWpwYjJiWVVxTGx4ekpMVWxEM1RRQzNoK005dDdPVWg3L0h4akc5?=
 =?utf-8?B?OUhITFJSNXM0NlIzQldyaXd4NFRVMnZoMEZPbWRMZnN2VFdvbFBQTlpnT1lh?=
 =?utf-8?B?LytYM3QvSVNQVE54VVkyU0t0dzZEN1ZpcEhZd3h4bk5UOHdKSk1BYTYwbldF?=
 =?utf-8?B?SjM3Q0N2YmxyT01zR3B5M2JxdUQ1OE1yREdObFBYZjJleGk0WW5JOW1Mczhk?=
 =?utf-8?B?K0MwQW1OdTVya085WE5KdUlmWXUxbmx4VTd1VmtwSk1HcnM0Z2tQaHhOMGhq?=
 =?utf-8?B?TFRkQVBIT1ZhTXptQnBnVWpQOFBUbU9EZ0EwdnQxZjN6eWd6WFlqOFhJR0F3?=
 =?utf-8?B?Z2lWQ0dvMUdxS0NNUWdJS3BGSXU2eHcxeGxSRi9CZStNakZqUEhSaEFDK3lj?=
 =?utf-8?B?YWZiWGduOTlVdlUwemJFN1Y3eHJ5bUpCU3V6OHFEZmI3SHM0SDV6YXU3ZDd2?=
 =?utf-8?B?eDR2M1NxS2V0UldJN0ZqME5OaHlCUWYwWlBEMWJ3dldoSkVIUmxpME5HOHRI?=
 =?utf-8?B?OUUrQXltUm1nc2Nua3BobUtmUDRYWEFWdDNyRG5kMkYyQ0RlbThrUXBBT05V?=
 =?utf-8?B?K2l1WDU2cWZEMDlJSnpzQzhVdlB0cnVGWUJSeHdRdUNOM2FmSHFLcGtPS3p4?=
 =?utf-8?B?T0VjN3ZNYUFFNW52d2NzY0R6elNPWmFmM2FpYXQ0UTNqRS90RUFmTTJKeGZV?=
 =?utf-8?B?QTAzQ2pwYWNlVzQzMGEwMG1HUHBGbEdDV0N5M2xZRlZ2N3JZVkVIanp3U1gy?=
 =?utf-8?B?UERvMlA4UGRUZGszcHhoUXZDd2ZhTERQRll0RkZCYU55bFhsa3NjeENCWk1l?=
 =?utf-8?B?NUNpdnRSS2ZsWjIwM21jbzhqeHNCRERtcDdqVE1wdm4xMU95NXhKc3Y1MStM?=
 =?utf-8?B?dDBSVmU2YkpZTFZoN1lOeEVES2ZZdk5ibmU4eUhNWGZVS3RCQmxZSStiNVhl?=
 =?utf-8?B?YlZDNGJSMlRwZWVCU0N5WXN5SURoQU5md3RVRlFsbnFRTkhhaTNnVnhSaGMz?=
 =?utf-8?B?TjRnVHJsNU0vZkh5WHRWUk4xNFdkUTFCUE1OemZqM015L1lxcTJ6eUExTFBB?=
 =?utf-8?B?SHcwaHF4Z2dkdXM5Z0EyaFVoc2xDR2FWY24wSkxBRmg3TXJESFJLQjhlQ055?=
 =?utf-8?B?ek9JKzluSUo0cmwvNmZxNmFmWmZObCtPaEFrSHdPVmp2eEw5TkpmTjRCMGNI?=
 =?utf-8?B?cS91R2dnZHM1MjZrSGJWOUhHTnlGblVhL1Qrbll5Y09Wamo4MWV6TE1EMXd5?=
 =?utf-8?B?SjN0R0UvNkJjcTRqT3hReEM3UDFTT2dxcUlSM25PczVKWlpHakplT3g1Z3Yx?=
 =?utf-8?B?YjV4NDJBR3NFSWVYeGcreVhtN2szcmNYTFRDY2FUSTByMmhPYjFmYTJPTE9v?=
 =?utf-8?B?OXRaK3cvajdrRkh6eElybHJ6WExvUUhhNm5ZUGJleXhBMFlycFRUcXM2aG9h?=
 =?utf-8?B?ZnUzbE9BM1NvSGNtTm9ha3dUYkhhckpKNzVRR2hzQTVKTzRCUXhIZDF2TDNw?=
 =?utf-8?B?U2c9PQ==?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 83a71d4d-e6c4-47c4-43d5-08dbd9da1316
X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2023 06:24:45.0961
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EduTjyWHcPSQgQi6ljzRxqgo+1iR264k9TuGe4ovFDm68+VFC1yvrfkyd+S1NtiyPAIOmyfApxVrx7bbgC3yRA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR10MB5937
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 30 Oct 2023 23:25:08 -0700 (PDT)

On 30.10.23 20:28, Aradhya Bhatia wrote:
> With new connector model, tc358767 will not create the connector, when
> DRM_BRIDGE_ATTACH_NO_CONNECTOR is set and display-controller driver will
> rely on format negotiation to setup the encoder format.
> 
> Add the missing input-format negotiation hook in the
> drm_bridge_funcs to complete DRM_BRIDGE_ATTACH_NO_CONNECTOR support.
> 
> Input format is selected to MEDIA_BUS_FMT_RGB888_1X24 as default, as is
> the case with older model.
> 
> Reported-by: Jan Kiszka <jan.kiszka@siemens.com>
> Signed-off-by: Aradhya Bhatia <a-bhatia1@ti.com>
> ---
> 
> Notes:
> 
>   * Since I do not have hardware with me, this was just build tested. I would
>     appreciate it if someone could test and review it, especically somebody, who
>     uses the bridge for DPI/DSI to eDP format conversion.
> 
>   * The Toshiba TC358767 bridge is not enabled in arm64 defconfig by default,
>     when it should be. Hence, I sent a quick patch[0] earlier.
> 
> [0]: https://lore.kernel.org/all/20231030152834.18450-1-a-bhatia1@ti.com/
> 
>  drivers/gpu/drm/bridge/tc358767.c | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
> index ef2e373606ba..0affcefdeb1c 100644
> --- a/drivers/gpu/drm/bridge/tc358767.c
> +++ b/drivers/gpu/drm/bridge/tc358767.c
> @@ -1751,6 +1751,30 @@ tc_dpi_atomic_get_input_bus_fmts(struct drm_bridge *bridge,
>  	return input_fmts;
>  }
>  
> +static u32 *
> +tc_edp_atomic_get_input_bus_fmts(struct drm_bridge *bridge,
> +				 struct drm_bridge_state *bridge_state,
> +				 struct drm_crtc_state *crtc_state,
> +				 struct drm_connector_state *conn_state,
> +				 u32 output_fmt,
> +				 unsigned int *num_input_fmts)
> +{
> +	u32 *input_fmts;
> +
> +	*num_input_fmts = 0;
> +
> +	input_fmts = kcalloc(MAX_INPUT_SEL_FORMATS, sizeof(*input_fmts),
> +			     GFP_KERNEL);
> +	if (!input_fmts)
> +		return NULL;
> +
> +	/* This is the DSI/DPI-end bus format */
> +	input_fmts[0] = MEDIA_BUS_FMT_RGB888_1X24;
> +	*num_input_fmts = 1;
> +
> +	return input_fmts;
> +}
> +
>  static const struct drm_bridge_funcs tc_dpi_bridge_funcs = {
>  	.attach = tc_dpi_bridge_attach,
>  	.mode_valid = tc_dpi_mode_valid,
> @@ -1777,6 +1801,7 @@ static const struct drm_bridge_funcs tc_edp_bridge_funcs = {
>  	.atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state,
>  	.atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,
>  	.atomic_reset = drm_atomic_helper_bridge_reset,
> +	.atomic_get_input_bus_fmts = tc_edp_atomic_get_input_bus_fmts,
>  };
>  
>  static bool tc_readable_reg(struct device *dev, unsigned int reg)
> 
> base-commit: c503e3eec382ac708ee7adf874add37b77c5d312

Doesn't help, callback is never invoked. There must be more missing.

Regarding test setup: Maybe your colleague Preneeth can help to give you
access, he just received some devices from us. Otherwise, drop me
instrumentation patches.

Jan

-- 
Siemens AG, Technology
Linux Expert Center