Received: by 2002:a05:7412:f589:b0:e2:908c:2ebd with SMTP id eh9csp54788rdb; Mon, 30 Oct 2023 23:37:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHadZe9bQKMNnUtCrFxYqlmQeiNkZ4YD0aD6iS9hq5ZZKnL4MuF3etG5pYAmfaUTfm37n8A X-Received: by 2002:a05:6871:6004:b0:1eb:e8b:7206 with SMTP id qx4-20020a056871600400b001eb0e8b7206mr14429110oab.14.1698734269347; Mon, 30 Oct 2023 23:37:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698734269; cv=none; d=google.com; s=arc-20160816; b=Rv/OWpDgOG3wlzbrxn1I0vUQn1HbhVRiUHLxt2Zp+Ahu9KkAQpE2WVHZgB4kXcyfeD R/CeTUZ8m/Ub9/P6F1xYn+C61PoJHu9x3O8CVxg6P+fS4XOTOB3RQBrBHv2suACtWPhm x2qggWvWpbW1jv7kncmBEDBfLmlXUw+gjIDbHha8MHdRQVxNewq4gweNJEt47/nfKA4R ATCb18s3e+wOHI202UWMcWdqp67Ayd7bKPUn83ym7E9YCqdLW5adLFAWCTcuiFr3QL4w 7rYYqCH05OLnXy81N/cMABQpJ+O5xprk2LyENtDz6Q+s55aZymCa8XWgymXOJsQv1Fte MUBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=+d1uJbHf809zly5E0/vfOt0r1EqovuQmUzXCB6ZY4A0=; fh=DMw9LMHpggyuZUEsZcPNzGP7rx9C4+R9R1wX+JxjXFc=; b=zDGlM7hv8zIR0L8wPxno7DobR8U3zdOG+tAgqkYbdT407XhuluJjjtb+oa8upBl4w8 eNwFCiL8HExY1DrhRSp9Q42BaN8E2LSRmeMhKmnKudMjdq1XXV04I+WqlBNwpiCs/nbg o4O1tttc96R9UGqbdl/0I7tGbrZU5+XGBmneUXaLx+N8PUdicHcKKkMsFcuqtR2ot6FT ghnF5IO6HoB8bXxE/RLJm3EvxnFBSbG0+GFzvHb+tj+0ZItUNVFBDIJmr5hm0Yf+jtyC v3rcJkK9G7tsu9RmxaAgEVCjKL8ozCSfvW2IcGFyjuYt+/a+9TaxymGVO4bOcB0Vbmsr JKDg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id z190-20020a6333c7000000b00578e0ff59bbsi602203pgz.865.2023.10.30.23.37.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Oct 2023 23:37:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 4FCA4803D5A9; Mon, 30 Oct 2023 23:37:43 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236218AbjJaGhZ (ORCPT + 99 others); Tue, 31 Oct 2023 02:37:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233629AbjJaGhY (ORCPT ); Tue, 31 Oct 2023 02:37:24 -0400 Received: from cstnet.cn (smtp81.cstnet.cn [159.226.251.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C59DC1 for ; Mon, 30 Oct 2023 23:37:16 -0700 (PDT) Received: from localhost (unknown [124.16.138.129]) by APP-03 (Coremail) with SMTP id rQCowABnxp6XoEBldh7SAQ--.36923S2; Tue, 31 Oct 2023 14:37:11 +0800 (CST) From: Chen Ni To: lee@kernel.org, andriy.shevchenko@linux.intel.com, mika.westerberg@linux.intel.com Cc: linux-kernel@vger.kernel.org, Chen Ni Subject: [PATCH] mfd: intel-lpss: Add check for platform_get_irq Date: Tue, 31 Oct 2023 06:36:42 +0000 Message-Id: <20231031063642.3041682-1-nichen@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: rQCowABnxp6XoEBldh7SAQ--.36923S2 X-Coremail-Antispam: 1UD129KBjvdXoWrurW7XryDCF1UJry7ZFWrXwb_yoWfGwb_C3 Z5u3Z7GrWIkrsYvr1Ivw1a9rySvrs2gr48XF1IqaySyryUJryUWrZ8ZFs8J3WUu34jkr9r Gr1DWrW3C3WayjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbckFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AKxVW8Jr 0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj 6xIIjxv20xvE14v26r126r1DMcIj6I8E87Iv67AKxVW8JVWxJwAm72CE4IkC6x0Yz7v_Jr 0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxkIecxEwVAFwVW8 AwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r 1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij 64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr 0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF 0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0JUeHq7UUUUU= X-Originating-IP: [124.16.138.129] X-CM-SenderInfo: xqlfxv3q6l2u1dvotugofq/ X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 30 Oct 2023 23:37:43 -0700 (PDT) The platform_get_irq() might be failed and return a negative result. So there should have an error handling code. Fixes: 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS devices") Signed-off-by: Chen Ni --- drivers/mfd/intel-lpss-acpi.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/intel-lpss-acpi.c b/drivers/mfd/intel-lpss-acpi.c index 212818aef93e..42b14a80b989 100644 --- a/drivers/mfd/intel-lpss-acpi.c +++ b/drivers/mfd/intel-lpss-acpi.c @@ -186,7 +186,11 @@ static int intel_lpss_acpi_probe(struct platform_device *pdev) if (!info->mem) return -ENODEV; - info->irq = platform_get_irq(pdev, 0); + ret = platform_get_irq(pdev, 0); + if (ret < 0) + return ret; + + info->irq = ret; ret = intel_lpss_probe(&pdev->dev, info); if (ret) -- 2.25.1