Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <8f1b5075-6b12-4fa8-a173-804d4657415e@amd.com>
Date:   Tue, 31 Oct 2023 13:23:12 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1] platform/x86/amd/pmc: Get smu version before reading
 dram size
To:     Mark Hasemeyer <markhas@chromium.org>,
        =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc:     LKML <linux-kernel@vger.kernel.org>, stable@vger.kernel.org,
        Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <markgross@kernel.org>,
        Sanket Goswami <Sanket.Goswami@amd.com>,
        platform-driver-x86@vger.kernel.org
References: <20231027212916.1035991-1-markhas@chromium.org>
 <2b8335a7-4b9b-825-c1b8-84158aaf2c42@linux.intel.com>
 <CANg-bXCcNPjmQC9vgd1JJcV4QoruhhbeEg8o=S9K-22kb746kQ@mail.gmail.com>
Content-Language: en-US
From:   Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
In-Reply-To: <CANg-bXCcNPjmQC9vgd1JJcV4QoruhhbeEg8o=S9K-22kb746kQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TDNxcUU4RGRZU2E5c2xQdnc2L0tjR1VsclNEOHY3RXpRaE5GWnhkWTJ4QmN0?=
 =?utf-8?B?MGUzQ3dUU2Z6dU96dGltQ0hsQm1PdnBpd25BQ0lucGxFWWVQY0ZuYitLdkt0?=
 =?utf-8?B?Mmxrc3RyNmVDbVhKazdoRVQyRUQ4bjZ1NG1lbjEwM3F5ODF3czRXVGQxWnpU?=
 =?utf-8?B?NzNQSGN4N3RUd1kvY1pSbHo1ek5XckFPdmdYUmN0M0hic0k4T1BZSGtUdnZQ?=
 =?utf-8?B?akNqT0hxNHhqUTduS042aGxRSGlKN296QnYxR3B1SHB1a0ZhMnFTaGNvc0J5?=
 =?utf-8?B?QnJ1ZGRSMzJGTVZLVVlhV1BWQkhkN3pISUVmeUxvdkQzWWw5WVRHOHlVeEtR?=
 =?utf-8?B?RGhDN3o3eUlvY2RqR0VRTUdCUHdrdS9EdWQrRGJpd0h3bURHWmpqNHFRb3ky?=
 =?utf-8?B?Z3dvNjhuQWlMMUNxeENPV3FHd2RzWU92QzlzQnhuSGtEZGtvVjBkMzZ1R2lU?=
 =?utf-8?B?S2VRVWhtcVFEbU1VVVFKK2Y0U2JDeXg2ZDdlZUtJVmh3SFJuWjloaWd0UWNF?=
 =?utf-8?B?RVdmMkNNeXZOVm0zM2JPZGgvMHIrdk1BWEJMT253T0pxTU0zTlMwd2Q3WUs4?=
 =?utf-8?B?WlVUd3lIVXFsUXNNUy8zL2NFVFpjVld3ZXB3enlHcHlOZ1UvSjY4RkZ6SGo3?=
 =?utf-8?B?OFN6d1ZjNzE2aTE1OTNyMEc4VDdQTGtvNlFiWEtmd2dZRUhpb3JCQ1dmQSsx?=
 =?utf-8?B?UWpYVU9FMVVzNkFrZHAxOXZYVXNzSHRDb05qU0FYZm5saEhVR2RIQ1prTnV6?=
 =?utf-8?B?SVNoZktwcXpENzNKTTZHT1NiNjJvMnloOXlEdHA5bHAzSzJOZHQ0Z0IrSEJY?=
 =?utf-8?B?K0R3bFZrWGduRC84NE5mNjdNeTBoa3ovemVLc1dlc0V2M0VZc3FhNWF4azFR?=
 =?utf-8?B?RUNJdFREL2xGc01FQWNYRmhOM3dFQkpZRncyR04wdUtDbk8wTXA0Uml3SVQ5?=
 =?utf-8?B?V3ZBQzhGenl5NURzZEhlVytkVERZbGlPK1dYc3o0U0hHTFFRYWdHenMwdGhD?=
 =?utf-8?B?NDVxSklYMFJhZldUYlhtQnRla3B5MHVnQ3RYSGNLQnhpQjJSdVRiZFFyS0lW?=
 =?utf-8?B?VDRSdTFDaVNNdlUyZ1dwYTNycXNVQ3JVRjJCaExnTGYyNlpMRisvcCtmL0JE?=
 =?utf-8?B?R1JCRjdtQWQ5ekFIVTN4cEtBRTd0VkxNMDFlQUIrS25RWXY4aktWZWk3WllT?=
 =?utf-8?B?MkRkRkUrNlVnVkNDekk2N3l5ZnN1Q1Q3WStwQW8veVZ2MjJ0VDFGRzkwVHp4?=
 =?utf-8?B?bmNqMzkrQWFmQkgwL3RRMDVaQXFMMUZzUHM5T01CalhTb1I0S3h0cjhjM3F3?=
 =?utf-8?B?d0l4Q3k0OThCNzBOcUxpZ1BvVm1rcHNPMy9DTUFnaTlwaE5xVlNlQkhZdU14?=
 =?utf-8?B?SCtuTTNKT3NJMHdGOC9tUzFYR0RsMmtmSWU0ZjB1UWZ3Zm5LVmpzc29tUEhx?=
 =?utf-8?B?S0xmZmhIejhSZ0g3ckNFMlVzWmIrTFo1dFMrVFhRbzRQRk14NHdoYWl0V0h5?=
 =?utf-8?B?Z3ExcDJqSXhxNkhvN3NKMmZhQUdORWYxN1Q0S3E0OGltQ0VLc2FVTFREL2tC?=
 =?utf-8?B?ZnVrWHoyVGl5K1k1bzFvVFJ6cVlmck5oOWprNTdsZElIYnNYUXVSVHpwTmYx?=
 =?utf-8?B?cE8zdTExZzkzSXkrMHNlVENGL0FvcW1qWWc1anI2Vm9jRUpoYUNvV2c2S1p2?=
 =?utf-8?B?aysrenJ3SURUb1pKL1cvcFh5eUE1WldyZG1oMGIxT2ZxUGZYNTRVb3RrejRm?=
 =?utf-8?B?WHFnWWpvazJoZDFaZHR3YWUreU5oMDN5NGVqbGUvYUhwMml4cEJpSkFZSjRH?=
 =?utf-8?B?UW5Jenlsek9MRnVUT2tma0FHTTEwb1VtQTNFZ25ocTJXSVNxYVRZSlY4a3p3?=
 =?utf-8?B?RkJIVXZ4aWZHMU5oZC9XWlBpSmllTWNMQWpYemxZNFhIL1pxdTNheFdaemFt?=
 =?utf-8?B?WTJjZWVHWW9PcURlbUxsVU4rNDR6TlYzak5DNzl3dnlBa2pPVzJ6RmZZVlNS?=
 =?utf-8?B?WjJzRHFlclRXRWVRcGtjNjRMSE5UR0U0TUp5dmlwbUZ3KzNBYlNZRktVdkNv?=
 =?utf-8?B?cGxVWitweEMvR3NoOGl0Undoa0hENWJGa09kOHBCN1BwU1RvTytkM0lLQzJP?=
 =?utf-8?Q?3nIMKV8A8RLBW9r6D8YoDob+T?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e6ff52b2-b58f-420b-ea07-08dbd9e6736f
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5176.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2023 07:53:20.8650
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: O1p3MJZxk43UiHNj01hp19gXFSP284OyfLhgNRsi+sDa1OcqAVSdfkRi52QqV5mwyOfOx4wFUcqkestxiwjTEw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7890
X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 31 Oct 2023 00:55:09 -0700 (PDT)

Hi Mark, Ilpo,

On 10/30/2023 9:39 PM, Mark Hasemeyer wrote:
>> Hi,
>>
>> Thank you for your patch. This has already come up but no acceptable patch
>> has emerged since. Please see this thread for what needs to be done if you
>> want to provide one (or maybe Shyam already has one which has just not
>> been sent out yet):

Yes. Was talking to FW team before I respin.

>>
>> https://lore.kernel.org/platform-driver-x86/3b224c62-a1d8-41bd-aced-5825f5f20e66@amd.com/
>>
>> (Since this dram size is on an init path that always needs SMU version,
>> the SMU version can just be called by the init unconditonally rather than
>> adding more of this lazy initialization everywhere).
> 
> Thanks for pointing me to that thread. I think Shyam/AMD can come up
> with a better long term solution, but it may be worth pushing this
> patch through for a couple reasons:
> 1. Probing of the driver currently fails on STB enabled systems with a
> Mendocino SoC. A slower boot time is better than the driver failing to
> load IMO.
> 2. This patch only affects Mendocino SoCs, and was a suggested
> solution from Mario in the thread you mentioned.
> 

I have a patch in place that should address the problem you are
mentioning. I will send that out next Monday after some tests.

Thanks,
Shyam

> That said, I can also just disable STB for now...