Received: by 2002:a05:7412:f589:b0:e2:908c:2ebd with SMTP id eh9csp98863rdb; Tue, 31 Oct 2023 01:44:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG9ZXezuY+UICVfEEsk8TMXbAWZm3rihlXLPIKXVrjFsY8bwEz7e8/wW375T+YR7je+ywXD X-Received: by 2002:a05:6358:7e08:b0:169:5bdd:9023 with SMTP id o8-20020a0563587e0800b001695bdd9023mr9469742rwm.28.1698741870177; Tue, 31 Oct 2023 01:44:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698741870; cv=none; d=google.com; s=arc-20160816; b=iL0uHn6me/DWpE1ldLA1IUuWTdVyFz3aTeFV251N9wLZDRSHujdcVk75ymE6KJ8//b Sa2GEK9mmu/h3a4jc0oH1wn3WiwS9diLh2NFVVAm/1RZQJP5Ok4bBoWd7MgyjhCbrUcz 6/ANWAcOSJ7YjpwDcDRkX/cOTE0oprreJ45e/arQnt5M7kp/sJUVeIOqC8xS40SQsTiP C6nzCaj8nj3hEHb+cuBXNlBU5n+icUIfsq+dAIodsHHCEW9EDrPvAMl+44psBieJWfvS NJjBdmcrGfvNOES+lfk5osobNPUB/Mv7SSXk0kdQOqXCBVSTjm/lUuno2Eudo0PYBs0z /WbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=YZyTDgOu+Mk84MW1y8TY9+DV7jPCPdy2MJyiStmLRmc=; fh=4dB70KV+JfgISNHHh5yfGYUPuuJod4AYjwAErbkRTDA=; b=uSA5WVRTEd8Z6cYeTdwTS5rj+rfARK5+M2s0dtXIofPPcZai2rvH6bYaLE9GkJPNiE jd8lO20sJtCRIKkLVazZUoQd0LMHzZR3/NQOvFydOkdRWcIm5KWSbcwyGqNhlfTVYvoc jgH20pwe7U7x2yq4JBVOXIisgONhQ1QhLuRqntx4ZzraJmckPfa+iQ63To5ulvLswNDa lap0U7KxpvLVx5adi0vy9kHBfYL4WZFyzeOKEaAZWeytyMcWsxwWeuovDj2daIn3a1Qi 1XLUdiWJXhjb+hfoGqEzE8ZmWUYO/0vKw2kXFEG+xWcruYDqsfhHvmc8JYqrl5K8i7dm 9hpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wteoQUuS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id x190-20020a6386c7000000b0058afac51c12si401519pgd.545.2023.10.31.01.44.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Oct 2023 01:44:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wteoQUuS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id E5A388027679; Tue, 31 Oct 2023 01:44:28 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233735AbjJaIoT (ORCPT + 99 others); Tue, 31 Oct 2023 04:44:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235618AbjJaIoP (ORCPT ); Tue, 31 Oct 2023 04:44:15 -0400 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46960C1 for ; Tue, 31 Oct 2023 01:44:13 -0700 (PDT) Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1cbf47fa563so41788715ad.2 for ; Tue, 31 Oct 2023 01:44:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698741853; x=1699346653; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YZyTDgOu+Mk84MW1y8TY9+DV7jPCPdy2MJyiStmLRmc=; b=wteoQUuS/mcbK96HWeBn6VsU3LJA4ZC11ZPSxAQreZjuQcceCTeHStrIq22y1/4+c1 7hAYNeK3kfNAxIcJBHED1JH+s3z/ECfnvDxHdRH0kCinE298Sv9wJg+/FWL9f13isKzS 0C264Zy8PULh7zEEdgYeYUQcVE9ToFgqzNZf/1xUYCjc6PT/aB+u60F2z9gI8SFFQqBl r+QLTHs+5YFbPXtIIen7CQfJoEhEpVU5/Mgk9du6J+RgiGePrE7nUvioqR0ZCa4JR6Bz 8Y5TBMsxHNc1XdzkIdS9vFTdDbdeMyuAmqAUAihYXwhlfAETkkeSygkwS8qQevfaSfKB mrBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698741853; x=1699346653; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YZyTDgOu+Mk84MW1y8TY9+DV7jPCPdy2MJyiStmLRmc=; b=Tlp6X9koEAvsGxKUNOU4WG4uVHBaWDG2Er4tDJXB+CAiJTMrL4P+B10HfIQTBCZ8gm RSDvKsO9b5R+tMZegmaFua3BZLDg7w7wwYRR5qlLL9yLx5PF82IN+s/TUjCcNUZ1V6jH hkajvV9a5H8SLbd/ZpJELJQ+9KSQnJpwaiQcIAlSFXzvJErVdfXR187j6TARpKmdd34z vokws4wCzEwqu+Z9hgXpyklYn6rXAusu06xbAcBvqvDJHI4n/RBAyO5ZljdPSTwyIZBe zXJ1a4WrZkt5wJ8XTu6oomegd6sQf0HoIoxLaq+UsooQMYVOynQC1c7K5PEagUL1idJ+ JAmw== X-Gm-Message-State: AOJu0YyfkRsje31dywn5DPhbDXxLxEPOJ5eedQOeBPJ2/lhlyID1i285 vkROlxRrjF8w4k+WBnVrYvfQyQ== X-Received: by 2002:a17:902:ab81:b0:1cc:e66:3732 with SMTP id f1-20020a170902ab8100b001cc0e663732mr8974222plr.19.1698741852707; Tue, 31 Oct 2023 01:44:12 -0700 (PDT) Received: from localhost ([122.172.80.14]) by smtp.gmail.com with ESMTPSA id 6-20020a170902c10600b001ca4c20003dsm812711pli.69.2023.10.31.01.44.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Oct 2023 01:44:11 -0700 (PDT) Date: Tue, 31 Oct 2023 14:14:09 +0530 From: Viresh Kumar To: Varadarajan Narayanan Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, rafael@kernel.org, ilia.lin@kernel.org, sivaprak@codeaurora.org, quic_kathirav@quicinc.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v6 0/2] Enable cpufreq for IPQ5332 & IPQ9574 Message-ID: <20231031084409.x5kqcs4ubmd5jh47@vireshk-i7> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 31 Oct 2023 01:44:29 -0700 (PDT) On 31-10-23, 12:41, Varadarajan Narayanan wrote: > This patch series aims to enable cpufreq for IPQ5332 and IPQ9574. > For IPQ5332, a minor enhancement to Stromer Plus ops and a safe > source switch is needed before cpu freq can be enabled. > > These are also included in this series. Posting this as a single > series. Please let me know if this is not correct, will split in > the subsequent revisions. > > Passed the following DT related validations > make W=1 ARCH=arm64 -j16 DT_CHECKER_FLAGS='-v -m' dt_binding_check DT_SCHEMA_FILES=qcom > make W=1 ARCH=arm64 -j16 CHECK_DTBS=y DT_SCHEMA_FILES=qcom dtbs_check > > For IPQ5332: > ~~~~~~~~~~~ > * This patch series introduces stromer plus ops which > builds on stromer ops and implements a different > set_rate and determine_rate. > > A different set_rate is needed since stromer plus PLLs > do not support dynamic frequency scaling. To switch > between frequencies, we have to shut down the PLL, > configure the L and ALPHA values and turn on again. So > introduce the separate set of ops for Stromer Plus PLL. > > * Update ipq_pll_stromer_plus to use clk_alpha_pll_stromer_plus_ops > instead of clk_alpha_pll_stromer_ops. > > * Set 'l' value to a value that is supported on all SKUs. > > * Provide safe source switch for a53pll > > * Include IPQ5332 in cpufreq nvmem framework > > * Add OPP details to device tree > > For IPQ9574: > ~~~~~~~~~~~ > * Include IPQ9574 in cpufreq nvmem framework > > * Add OPP details to device tree > > Removed 2 patches from V1 as they have been merged > * dt-bindings: cpufreq: qcom-cpufreq-nvmem: document IPQ5332 > * dt-bindings: cpufreq: qcom-cpufreq-nvmem: document IPQ9574 > > v4: Included a patch to fix 'kernel test robot' build error -- > https://lore.kernel.org/r/202310181650.g8THtfsm-lkp@intel.com/ > > v5: Use devm_clk_notifier_register > Merge IPQ53xx and IPQ95xx cases with APQ8096 for speed bin selection > Add reviewed by tags > > v6: Except these 2 patches, rest have been merged... > Rebased these to latest top as they don't apply cleanly > (https://lore.kernel.org/linux-arm-msm/20231025062508.vccrmkem45p3fnwe@vireshk-i7/) > > Varadarajan Narayanan (2): > cpufreq: qti: Enable cpufreq for ipq53xx > cpufreq: qti: Introduce cpufreq for ipq95xx > > drivers/cpufreq/cpufreq-dt-platdev.c | 2 ++ > drivers/cpufreq/qcom-cpufreq-nvmem.c | 12 ++++++++++++ > 2 files changed, 14 insertions(+) Applied. Thanks. -- viresh