Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
MIME-Version: 1.0
References: <20231025104457.628109-1-robimarko@gmail.com> <20231025104457.628109-2-robimarko@gmail.com>
 <CAOX2RU4MBvDZZ767RPS9XKj0U2L3gviVG5cyR8NKyO4LD+sfYQ@mail.gmail.com>
 <20c8cfde-3f55-45c5-bc23-21979ac9680d@linaro.org> <CAOX2RU5-XFZhGzjigNtu-qFnPWDd2XkpGpY=HXWigRa5SXw4TA@mail.gmail.com>
 <ef377506-4132-4805-a76e-18f241afe319@linaro.org>
In-Reply-To: <ef377506-4132-4805-a76e-18f241afe319@linaro.org>
From:   Robert Marko <robimarko@gmail.com>
Date:   Tue, 31 Oct 2023 10:01:47 +0100
Message-ID: <CAOX2RU4K67evm10giQvF1rcfqTfR+e--KQT3ZePoHQoqASv_fg@mail.gmail.com>
Subject: Re: [PATCH 2/3] clk: qcom: ipq6018: add USB GDSCs
To:     Konrad Dybcio <konrad.dybcio@linaro.org>
Cc:     agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        mturquette@baylibre.com, sboyd@kernel.org,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
        Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, 30 Oct 2023 at 22:12, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
> On 30.10.2023 21:37, Robert Marko wrote:
> > On Mon, 30 Oct 2023 at 20:37, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
> >>
> >> On 29.10.2023 12:04, Robert Marko wrote:
> >>> On Wed, 25 Oct 2023 at 12:45, Robert Marko <robimarko@gmail.com> wrote:
> >>>>
> >>>> IPQ6018 has GDSC-s for each of the USB ports, so lets define them as such
> >>>> and drop the curent code that is de-asserting the USB GDSC-s as part of
> >>>> the GCC probe.
> >>>>
> >>>> Signed-off-by: Robert Marko <robimarko@gmail.com>
> >>>
> >>> Unfortunately, after testing on multiple devices I hit the same GDSC
> >>> issue I had a long time ago
> >>> that was the reason I did not send this upstream.
> >>> It seems that USB3 port GDSC (USB0 GDSC in code) works just fine,
> >>> however the USB2 one
> >>> (USB1 GDSC in code) it is stuck off and USB2 port will fail due to this:
> >>>     1.607531] ------------[ cut here ]------------
> >>> [    1.607559] usb1_gdsc status stuck at 'off'
> >>> [    1.607592] WARNING: CPU: 0 PID: 35 at gdsc_toggle_logic+0x16c/0x174
> >>> [    1.615120] Modules linked in:
> >> Can you dump GDSCR (the entire 32-bit register) at boot and when toggling?
> >
> > Sure, here it is:
> > [    0.023760] qcom,gcc-ipq6018 1800000.gcc: reg: 0x3e078 val: 0x8222004 init
> > [    0.023782] qcom,gcc-ipq6018 1800000.gcc: reg: 0x3f078 val: 0x8222004 init
> > [    0.988626] qcom,gcc-ipq6018 1800000.gcc: reg: 0x3f078 val:
> > 0x8282000 before toggle
> > [    1.202506] qcom,gcc-ipq6018 1800000.gcc: reg: 0x3f078 val:
> > 0x8282000 after toggle
> > [    1.207208] qcom,gcc-ipq6018 1800000.gcc: reg: 0x3e078 val:
> > 0xa0282000 before toggle
> Any chance
>
> .en_few_wait_val = 0x2
>
> (turning BIT(19) into BIT(17))
>
> will make a difference?

Sadly, it makes no difference and GDSC status bit newer comes up which is
rather weird as USB0 one seems to work just fine.

Regards,
Robert
>
> Konrad