Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Tue, 31 Oct 2023 10:16:35 +0100
From:   Pavel Machek <pavel@ucw.cz>
To:     Andreas Kemnade <andreas@kemnade.info>
Cc:     bcousson@baylibre.com, tony@atomide.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: omap4: embt2ws: add LED
Message-ID: <ZUDF8zuKdYp/k0ox@duo.ucw.cz>
References: <20230819143109.471615-1-andreas@kemnade.info>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="F0bfpAw7xJvIBZth"
Content-Disposition: inline
In-Reply-To: <20230819143109.471615-1-andreas@kemnade.info>
Precedence: bulk


--F0bfpAw7xJvIBZth
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> Add LED since the driver is now available.
>=20
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>

Is it one LED or three LEDs?

If it is one, we should use multicolor...

BR,
										Pavel
									=09
> @@ -206,7 +207,31 @@ &i2c3 {
> =20
>  	clock-frequency =3D <100000>;
> =20
> -	/* TODO: BD2606MVV at 0x66 */
> +	led-controller@66 {
> +		compatible =3D "rohm,bd2606mvv";
> +		reg =3D <0x66>;
> +
> +		#address-cells =3D <1>;
> +		#size-cells =3D <0>;
> +
> +		led@0 {
> +			reg =3D <0>;
> +			color =3D <LED_COLOR_ID_GREEN>;
> +			function =3D LED_FUNCTION_STATUS;
> +		};
> +
> +		led@2 {
> +			reg =3D <2>;
> +			color =3D <LED_COLOR_ID_BLUE>;
> +			function =3D LED_FUNCTION_STATUS;
> +		};
> +
> +		led@4 {
> +			reg =3D <4>;
> +			color =3D <LED_COLOR_ID_RED>;
> +			function =3D LED_FUNCTION_STATUS;
> +		};
> +	};
>  };
> =20
>  &i2c4 {

--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--F0bfpAw7xJvIBZth
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCZUDF8wAKCRAw5/Bqldv6
8mWnAKCiBU5Ff0xWIgBXzcW1R+AgdHju8gCgkai3U4j4/etK2ZP+ugVFix21tec=
=yOLR
-----END PGP SIGNATURE-----

--F0bfpAw7xJvIBZth--