Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Tue, 31 Oct 2023 10:33:52 +0100
From:   Mehdi Djait <mehdi.djait@bootlin.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     mchehab@kernel.org, heiko@sntech.de, hverkuil-cisco@xs4all.nl,
        krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
        conor+dt@kernel.org, linux-media@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        thomas.petazzoni@bootlin.com, alexandre.belloni@bootlin.com,
        maxime.chevallier@bootlin.com, paul.kocialkowski@bootlin.com,
        michael.riesch@wolfvision.net
Subject: Re: [PATCH v9 2/3] media: rockchip: Add a driver for Rockchip's
 camera interface
Message-ID: <ZUDKAB+zQYS9aLpB@pc-70.home>
References: <cover.1698666612.git.mehdi.djait@bootlin.com>
 <f7367726eb077d43446c83591ecbf9acbc77ef5f.1698666612.git.mehdi.djait@bootlin.com>
 <ad346052-ec62-4d68-903e-fccd7ad989bd@wanadoo.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ad346052-ec62-4d68-903e-fccd7ad989bd@wanadoo.fr>
Precedence: bulk

Hello Christophe,

On Mon, Oct 30, 2023 at 01:47:17PM +0100, Christophe JAILLET wrote:
> > +	/* Create & register platform subdev. */
> > +	ret = cif_register_stream_vdev(cif_dev);
> > +	if (ret < 0)
> > +		goto err_unreg_media_dev;
> > +
> > +	ret = cif_subdev_notifier(cif_dev);
> > +	if (ret < 0) {
> > +		v4l2_err(&cif_dev->v4l2_dev,
> > +			 "Failed to register subdev notifier(%d)\n", ret);
> > +		cif_unregister_stream_vdev(cif_dev);
> > +		goto err_unreg_media_dev;
> 
> Should there be another label with cif_unregister_stream_vdev(cif_dev); if
> an error occurs here?
> 
> CJ

cif_subdev_notifier() is the last function call in the probe with error
handling. So it will undo the last successful register:
cif_register_stream_vdev and use the goto to unregister the rest.

I can add a label err_unreg_stream_vdev but it will be only used in the
error handling of cif_subdev_notifier() and I don't see the benefit.

--
Kind Regards
Mehdi Djait

> > +	}
> > +
> > +	cif_set_default_format(cif_dev);
> > +	pm_runtime_enable(&pdev->dev);
> > +
> > +	return 0;
> > +
> > +err_unreg_media_dev:
> > +	media_device_unregister(&cif_dev->media_dev);
> > +err_unreg_v4l2_dev:
> > +	v4l2_device_unregister(&cif_dev->v4l2_dev);
> > +	return ret;
> > +}