Received: by 2002:a05:7412:f589:b0:e2:908c:2ebd with SMTP id eh9csp127513rdb; Tue, 31 Oct 2023 02:56:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHtiybQuJf6JcGW/yV8mW0eyTG8PugGN/JpjuLAksuFEwGvGfnoYvMuQhanX3FuyuzoAaFs X-Received: by 2002:a05:6870:2b11:b0:1bb:83e9:6277 with SMTP id ld17-20020a0568702b1100b001bb83e96277mr15757124oab.33.1698746185113; Tue, 31 Oct 2023 02:56:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698746185; cv=none; d=google.com; s=arc-20160816; b=u0AItfVmJLGS7xWqDakuop3rle2kAID+eU/oSPUCNFyYR+Au4E2KvWD2n2tdEedjjp GaIUhNxvFiZHQZE6mvvTcYLOjaNH696UZhwJ4RB8ucWBR+mVweCxhFKjYL+0xf72ImNY pzYNmvQpT/f7iqmrIcsf1N9A0oHV54xMKoZhc+A0VOjV+Z08EmpYPyQdg+DPTJw0RrUr VyCXZ7ESDloBUpkDOKZNzi9AMUeYL+XEBM9LqIp3B6rZRSHHyUykoO7Ffi425TuMnJgP 4SNbZ0w+t9LftZ/FBLME+ZyeLCZrA0Ws5+5beKGPOr2fTcqn/AJaLcCPRjpzyA6U0a3q A1UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=AiYZVx3GOT8EznjFnDKfN8wW+8MrAYI+JYHj3fNOMU0=; fh=4YDblQPgHXFh0ZBWkLux5ys2B4pZr0MfbRgtYFDkJ/o=; b=r4q5/JszI/unGcRRVRRUsvDBcUlSZ64AghB8PTVwzvuG2VLdKGDBJf7Ayg/UEFXDFr wQm2AmFxUxvOh7q7VepYoHL5ACyxCc27GLU3hiSoT+mZLknjPlYO9S8/8lOOn3f0Od+4 gm/GxfZRBa2nGXct6gn94CNikerwXqjkA1RkuSd6pBgiiLCL5vSaoiEShE73+x6Miy2c Vw9Gc2hbNey/Xy1zRpqndV8zW4g6SXyxia3PGpKcZX9XDokfombjYT3ocd6n0FMAX6JH XwunQ0ikS4DDNNqa8gcvXCU9fJfAmYuwrL5C9+Q6E2ZZi81SAS/9sN/aINkktnI6IDLK b5nA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=eD0XQvyw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id bw33-20020a056a0204a100b005b96e90348csi829988pgb.725.2023.10.31.02.56.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Oct 2023 02:56:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=eD0XQvyw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 726D48086519; Tue, 31 Oct 2023 02:56:16 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234871AbjJaJ4K (ORCPT + 99 others); Tue, 31 Oct 2023 05:56:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230464AbjJaJ4J (ORCPT ); Tue, 31 Oct 2023 05:56:09 -0400 Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C12D2C1 for ; Tue, 31 Oct 2023 02:56:06 -0700 (PDT) Received: by mail-qt1-x82e.google.com with SMTP id d75a77b69052e-419b53acc11so192221cf.0 for ; Tue, 31 Oct 2023 02:56:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1698746166; x=1699350966; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=AiYZVx3GOT8EznjFnDKfN8wW+8MrAYI+JYHj3fNOMU0=; b=eD0XQvywf+yWTJ+9LgOXQ851gThJeUgu0mtAt0xFEWBji3f5AbBUA/pv6Otr8G7PeN m99d9hAsR8Ds+Ru09JePhHEb0b3UsoLS8L8jXnYUCXUmwRo+temRgiUQdT5XMytL9yqv dMIIKqNEPpq8d0cWull9/ZGtoLWXWwgfEas0YJfPgptIZPSt/qAFXJifJ//gAkHGchCL Kh28lVGRWA/lVViFbuCUw+x7kTNyMMt2UwouBghRdUi6RvUoN0qP7CSOp2++B4xhpxhv J7sJ51hHXBMlCtMzjEmq3867JqbpUWGaEcih7BXgpyktUkBSPJZE9UqZcGTAUBQAd6Oe Uphg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698746166; x=1699350966; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AiYZVx3GOT8EznjFnDKfN8wW+8MrAYI+JYHj3fNOMU0=; b=vyEAzRGBJnzLzn/7zlWLHtqrF/IqnAasPWNUbVHmA6MB/OsZ697nLrYc13xxboKtvc QJFnyReET8UQdNMllsSo8Fc/BEQwA4A63w9Ja7rc1lur43PfiZ8kA05cBRSDjv9HG3/M jg6vBFvFn0ps0LZFnAvXNIv2QXG6daEBa0f/ckVhCGNxTkCthNzrBZhnVfHDOZHNfq2T 6mQAD6RIZUd0HxzGqiAGQEuL0dMjxhnEq3rFgY447noRfWvIMWB03yorYf6kkHXDzI91 xhUB8t7G+6bok0c8lhZyDuP7XmcmTlZX04FiOxvaW/WGBVIQOOWRXqmxmRF0ZLBuWoOc caOA== X-Gm-Message-State: AOJu0YwFD1Uwn+68JX+VldfBgtlemvCX41KOK7dOGamqwkHN/JItF10z grwtdl3Dhf9AhRTODHPF3ouAXNS84JzJglAfp7bEBQ== X-Received: by 2002:a05:622a:2898:b0:3f0:af20:1a37 with SMTP id ke24-20020a05622a289800b003f0af201a37mr139557qtb.15.1698746165645; Tue, 31 Oct 2023 02:56:05 -0700 (PDT) MIME-Version: 1.0 References: <20231027132213.3817924-1-jackmanb@google.com> In-Reply-To: <20231027132213.3817924-1-jackmanb@google.com> From: Brendan Jackman Date: Tue, 31 Oct 2023 10:55:53 +0100 Message-ID: Subject: Re: [PATCH] mm/page_alloc: Dedupe some memcg uncharging logic To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, yosryahmed@google.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 31 Oct 2023 02:56:16 -0700 (PDT) On Fri, 27 Oct 2023 at 15:22, Brendan Jackman wrote: > Signed-Off-By: Brendan Jackman > Change-Id: Ibe0f9941b6b24fc98ea2510a75d0a0d1066a2a2e Agh, sorry, it just jumped into my head that I neglected to run checkpatch and of course the commit message is garbage. I will leave this a few days in case there are other comments before I send a v2. FWIW I did at least run the mm kselftests via QEMU, results are the same with and without the patch.