Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Tue, 31 Oct 2023 12:02:43 +0100
From:   Robert Richter <rrichter@amd.com>
To:     Dan Carpenter <dan.carpenter@linaro.org>
Cc:     Davidlohr Bueso <dave@stgolabs.net>,
        Jonathan Cameron <jonathan.cameron@huawei.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Terry Bowman <terry.bowman@amd.com>, linux-cxl@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] cxl/hdm: Fix && vs || bug
Message-ID: <ZUDe09oTQFz1gSsW@rric.localdomain>
References: <60028378-d3d5-4d6d-90fd-f915f061e731@moroto.mountain>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <60028378-d3d5-4d6d-90fd-f915f061e731@moroto.mountain>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Av4yI9Cd8JGyQe18psjQeU3D5Svey7lSxmxSDXVwli0xbbL6PIKNsjjf1hSj?=
 =?us-ascii?Q?FuMT1MyzS38BHJEkDVbTIkFIKWMxswn54zrrqZXADQ1HbHLwq6RgRQRVpVoU?=
 =?us-ascii?Q?1gcdnQ5HkUGLdCLxuynF4wntwPQuIbE2EqjYCRvcSTxQjp/iGho2JkGZefAG?=
 =?us-ascii?Q?wWO0zYhSn5e5dOXcUyjzMsGaPI/1k4WMQL1dOW4617J860kyLyTKPnIYEnOp?=
 =?us-ascii?Q?VtSzVUC/XuicVCYMHEK903IycE9/jUQDQZlJEonD1tKkbvpmPBddgw12ZNy+?=
 =?us-ascii?Q?YJ/bP5y3abhw7tg2LdCO/vwxBDSGwQvEddj9kLcPP/yCO2NmRy6tspXHoQJu?=
 =?us-ascii?Q?zzslQlGiR/7r+znRdrvI8phwzsmUPa/0RtbmzrfZXFDXH+vWC8Ko/79QsjKd?=
 =?us-ascii?Q?RWIvrLPf86OX9pMlpLSi2AwgA4WoqUWxIwSBRCGSkCgkBGy82P81+hp//Q+4?=
 =?us-ascii?Q?gEY8fpUtk4FYk1S5Rt3kzplYZovuQGv4aPGmILzq48JTFFxpR1HyGkyw9gQ1?=
 =?us-ascii?Q?cYKDGkbzSCgWp/BU0qeGA6ORwgauLFmHeut1OOxMdbrFJa37MG5hot/VlYFs?=
 =?us-ascii?Q?P6Ni1AnrgzJe+HzVcycOp+cD2QcBmnKv/jNnh05sVLghW8AhruXWSaI/iI30?=
 =?us-ascii?Q?3CEDHo1hDGwByVItgOtglIAT6PJKJKa4FDXeZQmLAhH0Z2N+6YgY0+P/4z8e?=
 =?us-ascii?Q?pHbEEucX18TXgGgJxYnwvT9nNqRGgwWN5rk1A6atQQzJlLaMpUrGSSjAQ6Ej?=
 =?us-ascii?Q?dT1PCKEUlzonJ34xdTf/SqJlWtQKqLJlPhMtzcIo73Ruj+a8iCYZCmfpSDT3?=
 =?us-ascii?Q?tSRllq4nylp2ccDc+fJVab+Ws23UtpVfx028xoTKcjjvHAYGEyHdF5UOI2ly?=
 =?us-ascii?Q?6S3Q0UfGotTX78Jv417J384UQnGh93B/xmCpk+i0aUJ+MsLu7QtE43R+ekg9?=
 =?us-ascii?Q?e7V9u1LPf6Dlwzl6bI0RwfEVnfAZL1+0xP+JeO4BgTD5aw7flEoFvGEqMvzq?=
 =?us-ascii?Q?Kwr9PGKR5LD6lX6CgaTDYGwkf5mYw7GONlunj0K8tnlTMOcTuEqBS3rzEQL9?=
 =?us-ascii?Q?hfdsf325pgxhs87gT+1txAQP2QsXlWY0NIoC6CZ1btj2FdT7bOkaKOBGTWG0?=
 =?us-ascii?Q?bJS3b0zXwk39I8n5LmUZT7TAjmPBqiaYytjHQsBdfPhxJHiXjc98KMLLTiYH?=
 =?us-ascii?Q?p8prhmsD5F7VU29H08REp3g6iXUk7Oyv1CqcJOGxM9uKtEQNt3w4XQgVxWnq?=
 =?us-ascii?Q?2lBpmNR6WvwB46MVDSYLu8MHNfVpDvwyhJKzziK7Dponj6A3LmvdCOV/2guD?=
 =?us-ascii?Q?na1WTubBrO7ymOQQJB0g4U+2uBMn4gYORs9trFHBVetdi44at7J1Sa0drCXP?=
 =?us-ascii?Q?M1B3ZsBLZCSVJarZb8CNAr2ILVmWJvKVlCfT0/XlUSnPrapB6QumWxIROrqq?=
 =?us-ascii?Q?AxUzJ4LQYydVMMmCHg/QEzDV8m/0pDLiJ7pOoRyseWKxgJ5L0w4GdqYcGs6s?=
 =?us-ascii?Q?SZOeFKxTDhTA/rwEN+l3rIbt0L372WjajNpuHwCseY44W0TQEa6C7v2bv9Mf?=
 =?us-ascii?Q?S+CtIHDVU7uFKv3z9+usABRJw5rO6naOrivgbi8y?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1324f7bc-7277-42ee-00ca-08dbda00eb93
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3657.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2023 11:02:49.2763
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pNiCKPTNCHXuiW2ZLG2Lc5YUmSgzikOZgAVab9tznFvHaAdZ54e2oTuUInajVsOi/AutJkvhA+F6fJE4VrzS/Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB9125
X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 31 Oct 2023 04:03:15 -0700 (PDT)

On 31.10.23 12:53:52, Dan Carpenter wrote:
> If "info" is NULL then this code will crash.  || was intended instead of
> &&.
> 
> Fixes: 8ce520fdea24 ("cxl/hdm: Use stored Component Register mappings to map HDM decoder capability")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
>  drivers/cxl/core/hdm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cxl/core/hdm.c b/drivers/cxl/core/hdm.c
> index bc8ad4a8afca..af17da8230d5 100644
> --- a/drivers/cxl/core/hdm.c
> +++ b/drivers/cxl/core/hdm.c
> @@ -146,7 +146,7 @@ struct cxl_hdm *devm_cxl_setup_hdm(struct cxl_port *port,
>  
>  	/* Memory devices can configure device HDM using DVSEC range regs. */
>  	if (reg_map->resource == CXL_RESOURCE_NONE) {
> -		if (!info && !info->mem_enabled) {
> +		if (!info || !info->mem_enabled) {

Right, there was a bug.

Reviewed-by: Robert Richter <rrichter@amd.com>

>  			dev_err(dev, "No component registers mapped\n");
>  			return ERR_PTR(-ENXIO);
>  		}
> -- 
> 2.42.0
>