Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <3d8af1e1-e969-4489-90dd-59de1050f39e@siemens.com>
Date:   Tue, 31 Oct 2023 13:18:52 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] drm/bridge: tc358767: Support input format negotiation
 hook
Content-Language: en-US
To:     Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
        Aradhya Bhatia <a-bhatia1@ti.com>,
        Jyri Sarha <jyri.sarha@iki.fi>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Robert Foss <rfoss@kernel.org>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Boris Brezillon <boris.brezillon@collabora.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Francesco Dolcini <francesco@dolcini.it>,
        Sam Ravnborg <sam@ravnborg.org>
Cc:     DRI Development List <dri-devel@lists.freedesktop.org>,
        Linux Kernel List <linux-kernel@vger.kernel.org>,
        Nishanth Menon <nm@ti.com>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Devarsh Thakkar <devarsht@ti.com>,
        Jayesh Choudhary <j-choudhary@ti.com>,
        "Bajjuri, Praneeth" <praneeth@ti.com>
References: <20231030192846.27934-1-a-bhatia1@ti.com>
 <fc113f51-35e9-49ff-8299-e7fc11b81c31@siemens.com>
 <9e801f88-a15e-48f1-b103-0305c5807143@ideasonboard.com>
From:   Jan Kiszka <jan.kiszka@siemens.com>
In-Reply-To: <9e801f88-a15e-48f1-b103-0305c5807143@ideasonboard.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L1VkZ05WQ08vQWdSV2l3OXZwcDJJRnNCaWpUR0NhZVAyTmlKRkxzSkRVRU5P?=
 =?utf-8?B?UUs0MEpZdUF5YTNVNU44UmpVWnhsY3NTd2RyOXVJanVxUmNwQW1aM0lBWkth?=
 =?utf-8?B?a3ZnUGpqaThuWTNaWHVLWmNIYndmNW43d1N1YUhiSTJNb1NjWkQwVzZQL0lV?=
 =?utf-8?B?S1RMUndHS2VpOG1Ia0NQd3BNTnVSc2VtWGNCUXBZZndjZjh1ODJsSGF1bjc2?=
 =?utf-8?B?ZkJmZE81SEZ2TmRSRTZFd2h1TXJHTmlwaENVUGV4ZStWRFE5dk4wcm1pSmQ3?=
 =?utf-8?B?UGtoOTJhTkEwb3psWGNFWG5vUFBCM0Nta2JLSWxNby9lelFRRWVlc3VCdDN3?=
 =?utf-8?B?Nk5LblNMZ1R1ZlJqU3lYaGRWK0huaFg2U3A5Zm1GYmJES2dzRDhyczE4QW9p?=
 =?utf-8?B?czN5clk0dmhYck9oVExtRzkzQ1Y1WnJmSElna2JWR1U2VGVkZ1V2ZU5wZ1VZ?=
 =?utf-8?B?V1NRZHhNWnFSNHJmeU0wdXVwOUJSMWpJay8zTTMwQmpvWWkrTFRHam52NTVq?=
 =?utf-8?B?NzRISVgwUkhRTy9aYzNJSzd5MDlnMnJzOW9PTXZBK25UcWxXTnNYaWY5a2hD?=
 =?utf-8?B?ZHYxQUJTZXU5MzhTZVdpb1U5c0VWZ1NiZ3U5ekp3dCtaQVZuWUFjQXByYjQ3?=
 =?utf-8?B?UUlZclpyQUp0bmQ0T2pYYkxBTmVtbmh3S3Y3NU1ua1RKUW9DVWlpM2ZmNnZN?=
 =?utf-8?B?dS9MTEtTRndwcENxY1owalRNS0svb0oveUR3MjBKLzBHNHYrNVZKOTRmd09D?=
 =?utf-8?B?NCswQUd6QXpmR2FFS1BFTGxuQ245VXpscXFWVVppNHZzZ0VPVW9CQlFWRUZD?=
 =?utf-8?B?dlo1c3VqRElIOWlyTFVjTEpRWFB1dEFrdms4dHRDMVk2SzBoYXIxTmVMMkxI?=
 =?utf-8?B?VFAweVA5TTJIclkvc2U5UzV6Nkc0akkrcXRyS3AzSU5ONVlybklNNWdqQUZW?=
 =?utf-8?B?T3Q1K08yYjZlZmNaVzQzTlFSNmpxNlpRWHdmTGNBK3lDcXdLRXBCcVA3eVNy?=
 =?utf-8?B?QU9EWThPVnQyQ3FTUGZ5bGVSVHNzdHJBMU0wTUpqV0Y1NkdHSUhQRnBmVHU2?=
 =?utf-8?B?TlNSbitZb2I2aHpUWEVmTy9XWVdGaFRjQllkaW5RdlI2dGhFRm9hYTJXaWUz?=
 =?utf-8?B?Q0s0eGhrM0c0UFZvNTJlQ2NBemdIMHFCdWdYanFqQVNxZnBJcFk1MkJXQldw?=
 =?utf-8?B?eEIyVVFRMEtRRUZDaWlKNStpQnhhM20zV1RnUVRxYVEzN054VFRXTlFNM05P?=
 =?utf-8?B?Wm1kc1hRbWZ6aWphOUxwM3FpV1NVZDd5TkRMVjhzK2RSNzgrTmN0T1JQZVpa?=
 =?utf-8?B?djVvM0poRDgrMzlHOUtOUFFRZ3BxaEw3TVNZRjRvRzBrVC85TC9qRTh5VTBG?=
 =?utf-8?B?ZDEzb1N3cXNWVSsxbjZ1cHdIMjFNMkROem9wcEY2NVR4aWpvWlRJS1BmQmJq?=
 =?utf-8?B?TlJUUENXL1pHdFpzRFFUR0t2SnlDODJHRjNaM2dRMGU1TU5raVlVV0ZpcWxw?=
 =?utf-8?B?UHAyMVVPOHNDRnNya1dHMnZRcjZWZ0Nyc2xnZ1RiRmdQMDFZMk9qQkRFeGtw?=
 =?utf-8?B?V3hwTy9GNFFoMjRzOXBSQ0pkZDJFOXRQaXdEUi9maGkwclIzNzM2dXRhUXky?=
 =?utf-8?B?N2lhNklwYnBUb2Erb0hlL3hxZWNIWlk2aEN1RXlpWU1PT3JReHpNSXorbWp4?=
 =?utf-8?B?YWVPQUoxZUFETU9US2h2Rkl2d1ZJQVZnQ3Z3LzRCbzVjUG00b213SEpaTVQz?=
 =?utf-8?B?Y0dWYnM0UnpCM2I5Y0JzWXd3ZXF4dm5paitydGJGTWVlcTE3RVJ5OWhDVGM4?=
 =?utf-8?B?NG1uc2MyMnFRWkw1YkFNM3pwMll0bzA2TWNnUVovZUY3OFMrbEFJOXVMS3E3?=
 =?utf-8?B?dGdreHE0TVVVbG1VZDVZdXBLeTZVRUhBSllTM0ZpeERMaHZtaWJBRGN0cWtD?=
 =?utf-8?B?NmJ0dzE0cXY5TGdaUWc3d09aai9IWndVVE1CdGhkK2N5N2xsUEtPKzIxQ1Ro?=
 =?utf-8?B?TVB2ajQ1WFpaejU4L1ZBeW9GRUgxYWl0N09CMzhVY2RXWnVUc3J0NmRsVDBD?=
 =?utf-8?B?bzdOQXlySkhoMzlIRENHZG5MQUkrT01oTXZuejZ5Y0Zra0VmVGEvN3I5TjVj?=
 =?utf-8?B?YnhOQjl3UkpLMVFYS3J6WllRQ0tTSGJ6VDBuUGNZa0didjUzb3czY2JsOFJ6?=
 =?utf-8?B?enc9PQ==?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4d28c0f2-89f5-4830-b326-08dbda0b8e03
X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2023 12:18:56.6282
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TK7HMtwSTy/QRYOESAY8g2FnwrZTfY5n5+J+nyAlya2wkETuI4LGN+m9IECxXOt1gHMA8vvTthT0FH9lRTqoqQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR10MB3876
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 31 Oct 2023 05:19:19 -0700 (PDT)

On 31.10.23 11:53, Tomi Valkeinen wrote:
> Hi Jan,
> 
> On 31/10/2023 08:24, Jan Kiszka wrote:
>> On 30.10.23 20:28, Aradhya Bhatia wrote:
>>> With new connector model, tc358767 will not create the connector, when
>>> DRM_BRIDGE_ATTACH_NO_CONNECTOR is set and display-controller driver will
>>> rely on format negotiation to setup the encoder format.
>>>
>>> Add the missing input-format negotiation hook in the
>>> drm_bridge_funcs to complete DRM_BRIDGE_ATTACH_NO_CONNECTOR support.
>>>
>>> Input format is selected to MEDIA_BUS_FMT_RGB888_1X24 as default, as is
>>> the case with older model.
>>>
>>> Reported-by: Jan Kiszka <jan.kiszka@siemens.com>
>>> Signed-off-by: Aradhya Bhatia <a-bhatia1@ti.com>
>>> ---
>>>
>>> Notes:
>>>
>>>    * Since I do not have hardware with me, this was just build
>>> tested. I would
>>>      appreciate it if someone could test and review it, especically
>>> somebody, who
>>>      uses the bridge for DPI/DSI to eDP format conversion.
>>>
>>>    * The Toshiba TC358767 bridge is not enabled in arm64 defconfig by
>>> default,
>>>      when it should be. Hence, I sent a quick patch[0] earlier.
>>>
>>> [0]:
>>> https://lore.kernel.org/all/20231030152834.18450-1-a-bhatia1@ti.com/
>>>
>>>   drivers/gpu/drm/bridge/tc358767.c | 25 +++++++++++++++++++++++++
>>>   1 file changed, 25 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/bridge/tc358767.c
>>> b/drivers/gpu/drm/bridge/tc358767.c
>>> index ef2e373606ba..0affcefdeb1c 100644
>>> --- a/drivers/gpu/drm/bridge/tc358767.c
>>> +++ b/drivers/gpu/drm/bridge/tc358767.c
>>> @@ -1751,6 +1751,30 @@ tc_dpi_atomic_get_input_bus_fmts(struct
>>> drm_bridge *bridge,
>>>       return input_fmts;
>>>   }
>>>   +static u32 *
>>> +tc_edp_atomic_get_input_bus_fmts(struct drm_bridge *bridge,
>>> +                 struct drm_bridge_state *bridge_state,
>>> +                 struct drm_crtc_state *crtc_state,
>>> +                 struct drm_connector_state *conn_state,
>>> +                 u32 output_fmt,
>>> +                 unsigned int *num_input_fmts)
>>> +{
>>> +    u32 *input_fmts;
>>> +
>>> +    *num_input_fmts = 0;
>>> +
>>> +    input_fmts = kcalloc(MAX_INPUT_SEL_FORMATS, sizeof(*input_fmts),
>>> +                 GFP_KERNEL);
>>> +    if (!input_fmts)
>>> +        return NULL;
>>> +
>>> +    /* This is the DSI/DPI-end bus format */
>>> +    input_fmts[0] = MEDIA_BUS_FMT_RGB888_1X24;
>>> +    *num_input_fmts = 1;
>>> +
>>> +    return input_fmts;
>>> +}
>>> +
>>>   static const struct drm_bridge_funcs tc_dpi_bridge_funcs = {
>>>       .attach = tc_dpi_bridge_attach,
>>>       .mode_valid = tc_dpi_mode_valid,
>>> @@ -1777,6 +1801,7 @@ static const struct drm_bridge_funcs
>>> tc_edp_bridge_funcs = {
>>>       .atomic_duplicate_state =
>>> drm_atomic_helper_bridge_duplicate_state,
>>>       .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,
>>>       .atomic_reset = drm_atomic_helper_bridge_reset,
>>> +    .atomic_get_input_bus_fmts = tc_edp_atomic_get_input_bus_fmts,
>>>   };
>>>     static bool tc_readable_reg(struct device *dev, unsigned int reg)
>>>
>>> base-commit: c503e3eec382ac708ee7adf874add37b77c5d312
>>
>> Doesn't help, callback is never invoked. There must be more missing.
>>
>> Regarding test setup: Maybe your colleague Preneeth can help to give you
>> access, he just received some devices from us. Otherwise, drop me
>> instrumentation patches.
> 
> Can you try with this change:
> 
> diff --git a/drivers/gpu/drm/bridge/tc358767.c
> b/drivers/gpu/drm/bridge/tc358767.c
> index 0affcefdeb1c..137a9f5e3cad 100644
> --- a/drivers/gpu/drm/bridge/tc358767.c
> +++ b/drivers/gpu/drm/bridge/tc358767.c
> @@ -1579,6 +1579,13 @@ static struct edid *tc_get_edid(struct drm_bridge
> *bridge,
>                                 struct drm_connector *connector)
>  {
>         struct tc_data *tc = bridge_to_tc(bridge);
> +       int ret;
> +
> +       ret = tc_get_display_props(tc);
> +       if (ret < 0) {
> +               dev_err(tc->dev, "failed to read display props: %d\n",
> ret);
> +               return 0;
> +       }
>  
>         return drm_get_edid(connector, &tc->aux.ddc);
>  }
> 
>  Tomi
> 

Yep, that does the trick.

Thanks,
Jan

PS: Your mail client is mangling tabs - was already suspecting our
server would reformat again.

-- 
Siemens AG, Technology
Linux Expert Center