Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Received-SPF: Pass (protection.outlook.com: domain of topic.nl designates
 13.93.42.39 as permitted sender) receiver=protection.outlook.com;
 client-ip=13.93.42.39; helo=westeu12-emailsignatures-cloud.codetwo.com; pr=C
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=topic.nl;
Message-ID: <b5b3abbd-1551-34ac-65b4-4fb14e24d3f2@topic.nl>
Date:   Tue, 31 Oct 2023 13:27:21 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
From:   <mike.looijmans@topic.nl>
Subject: Re: [PATCH] clk: si5341: fix an error code problem in
 si5341_output_clk_set_rate
Content-Language: en-US
To:     Su Hui <suhui@nfschina.com>, mturquette@baylibre.com,
        sboyd@kernel.org
CC:     linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
References: <20231031020159.587686-1-suhui@nfschina.com>
Organization: Topic
In-Reply-To: <20231031020159.587686-1-suhui@nfschina.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Microsoft-Antispam-Message-Info-Original: LwVPB9zk5oLmykwmRAbu3Q/9GIBrS8wbs4KcFV2JOxwLgnv1x/DSogOLOyb3/a7JuwkgOQ0OF7j6lUXsmof1zHMXo4WFfdabwKVQWLkHrWxFA0UXNcQQ2v34OGyJ1RFyZdlC7KwJXJggUOyQDrLUCUSyRfVxkA1qWqvIhfIwnmQYxF1rr0YsoGsDhD68SP4BvGYcg50/6WESElH4o2TI9gbPru1KbHou0DfxrRRW1R7/KaDH6CYD4olNv8uEmdK27NOzNlIWaCWoKktfoEtjYb806bc7/x2tMevT7mcMHkupC5HGpVVAZBURSb8ccOqS8vKej1i9uBNuD9/t55fBaTMaDaFR9TU/UODun5BbA9RLBGKKcbfPzwdroSThKVwdyM6JL/fhf3PHTLMBxFi4M1ARIoMdmf7jD+ctYesdayQprBbPUQRH4an7HIeiTF6g3s6gAQ983NDhHaWegd9xtplvlYB/Fv4dSbQ5sZ61KCo7+Jjn0E+yeEMRPLirlSB+3It9JGAc9OyNRr2j5T6yfNCnq2enrB1Ncrozs7ndgemsRoE7F6I8mOziws4Vhwia032SnTwpeHxwAqBjmnfBQH8orj0U12bYTp/gJDAcJlU4PzSJsyOZapxfLfjjwupWHMiIDXbVw5nRwEVXe5F1HQ==
X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB7471.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(396003)(39830400003)(366004)(136003)(376002)(230922051799003)(186009)(64100799003)(451199024)(1800799009)(26005)(6506007)(2616005)(6512007)(53546011)(478600001)(9686003)(52116002)(83380400001)(36916002)(38100700002)(2906002)(6486002)(31696002)(86362001)(66476007)(66556008)(316002)(8936002)(4326008)(8676002)(36756003)(41300700001)(66946007)(15974865002)(5660300002)(38350700005)(31686004)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7368
X-CodeTwo-MessageID: 0bd4834c-02fa-4747-bae5-8da0e61484c3.20231031122725@westeu12-emailsignatures-cloud.codetwo.com
X-CodeTwoProcessed: true
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM2PEPF0001C70A.eurprd05.prod.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs: 1b730248-a5d8-4c01-ea79-08dbda0cbbff
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 3ephGz5ozVnNksIX87Sxi9fx2p7g2HJie59wndjAtJnMLYAnjPhu5Z9a4REj9FBuCTkkLD79GBSyKh1SzlGGFEBQrE3dBxFrct1+JzYRuyd7mkKj3uSOlxG9ggvwWtYefCzEmiNXOBgfCb0+WSocE74JJRd4BSwLP2JE7TMlOhPmJz79iJhzLhbocBn+2V3W2MMcEJRQtKulevupgxCqg/9pZndDsE7yLOmqdVj9IAHENCewVHKcoJzarQu5UvXdHZtl6ff78hwJWDr1LGGwVJFPrGAfTQlyZIQaQYq8+1o0ZL7Z9EtTH/gS9l6mXLr3QlEXN4/h0wouYHSz607cZNAs25hr87iA5GEv0odi/2N4M29DeO7WGDrTquwB7QKV+yD0B0Vc9l/lcTzicUt3g0ot1TKDzkcdFKfAiUtRNV3jgYXIHL7bFsN0nIaY4ctDRldfeHOErbn8EdGdWicyKMTcNbRl4MCDckH6F+N9aES423MiWP9zlRlsjVXJYfWUCumsvJTHO6Czo61oqMSzgN+JjsJE5njPZ/y/bmqsoFJtLlcEpgRaqL+Fbj4Jyp9YuSQdxMPxR3/XReIae5seiX4Z5055/bJF4PgBYJ+GJS+2r3wUbYr7tsp2GPShUIwSiN/AfR5FykTv+NfRBR0mU0VpSULeQr3ZG4suKQKPDNf73/M2lTK5Bwxm74Whusl2YcKY7STejwGhUtjRHGrVLq3XczGsEaNe+hlvtVap9OrCsqv1ejwohu3D5VAZCl1GJuLI/U1q96b5CWOjmYpJXg==
X-Forefront-Antispam-Report: CIP:13.93.42.39;CTRY:NL;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:westeu12-emailsignatures-cloud.codetwo.com;PTR:westeu12-emailsignatures-cloud.codetwo.com;CAT:NONE;SFS:(13230031)(4636009)(396003)(346002)(39830400003)(376002)(136003)(230922051799003)(186009)(82310400011)(451199024)(64100799003)(1800799009)(36840700001)(46966006)(356005)(7596003)(7636003)(6486002)(70586007)(70206006)(31686004)(47076005)(6512007)(53546011)(36916002)(6506007)(36756003)(478600001)(26005)(83380400001)(336012)(2616005)(4326008)(316002)(8676002)(8936002)(5660300002)(15974865002)(40480700001)(86362001)(2876002)(2906002)(41300700001)(36860700001)(31696002)(43740500002)(18886075002);DIR:OUT;SFP:1101;
X-OriginatorOrg: topic.nl
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2023 12:27:26.9727
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 4338eca5-4d78-4af9-607f-08dbda0cbe4c
X-MS-Exchange-CrossTenant-Id: 449607a5-3517-482d-8d16-41dd868cbda3
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=449607a5-3517-482d-8d16-41dd868cbda3;Ip=[13.93.42.39];Helo=[westeu12-emailsignatures-cloud.codetwo.com]
X-MS-Exchange-CrossTenant-AuthSource: AM2PEPF0001C70A.eurprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9099
X-Spam-Status: No, score=-3.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 31 Oct 2023 05:27:43 -0700 (PDT)

FWIW, you have my gratitude...

Acked-By: Mike Looijmans <mike.looijmans@topic.nl>

One remark, maybe just "return regmap_...." straightaway and skip the=20
"err =3D " assignment.

M.

On 31-10-2023 03:02, Su Hui wrote:
> regmap_bulk_write() return zero or negative error code, return 'err'
> rather than '0'.
>
> Fixes: 3044a860fd09 ("clk: Add Si5341/Si5340 driver")
> Signed-off-by: Su Hui <suhui@nfschina.com>
> ---
>   drivers/clk/clk-si5341.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/clk-si5341.c b/drivers/clk/clk-si5341.c
> index 9599857842c7..9b1cc5a83b5b 100644
> --- a/drivers/clk/clk-si5341.c
> +++ b/drivers/clk/clk-si5341.c
> @@ -898,7 +898,7 @@ static int si5341_output_clk_set_rate(struct clk_hw *=
hw, unsigned long rate,
>   	err =3D regmap_bulk_write(output->data->regmap,
>   			SI5341_OUT_R_REG(output), r, 3);
>  =20
> -	return 0;
> +	return err;
>   }
>  =20
>   static int si5341_output_reparent(struct clk_si5341_output *output, u8 =
index)


--=20
Mike Looijmans
System Expert

TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: mike.looijmans@topic.nl
W: www.topic.nl