Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Date:   Tue, 31 Oct 2023 12:53:14 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Artur Weber <aweber.kernel@gmail.com>
Cc:     Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Florian Fainelli <florian.fainelli@broadcom.com>,
        Ray Jui <rjui@broadcom.com>,
        Scott Branden <sbranden@broadcom.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@broadcom.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Stanislav Jakubek <stano.jakubek@gmail.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 6/6] regulator: bcm590xx: Add proper handling for
 PMMODE registers
Message-ID: <63356933-3da7-4068-ad77-0f0e8d8915be@sirena.org.uk>
References: <20231030-bcm59054-v2-0-5fa4011aa5ba@gmail.com>
 <20231030-bcm59054-v2-6-5fa4011aa5ba@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="JwakjBWjo5Y6WgSv"
Content-Disposition: inline
In-Reply-To: <20231030-bcm59054-v2-6-5fa4011aa5ba@gmail.com>
Precedence: bulk


--JwakjBWjo5Y6WgSv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Oct 30, 2023 at 08:41:48PM +0100, Artur Weber wrote:

> +	for (i = 0; i < pmctrl_count; i++) {
> +		ret = regmap_write(regmap, pmctrl_addr + i, mode_mask);
> +		if (ret)
> +			return ret;
> +	}

Why not a bulk write?  What happens when the new values are partially
written, both if there's an error and just transiently?

--JwakjBWjo5Y6WgSv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmVA+LkACgkQJNaLcl1U
h9Cn4Af/avvAKVxZeTeXLPlGXQMqtb8I4zu45eiTGPiemTnzPESQOjREO+R8XzqM
jw6zhgziB7wn+dWLfhlZ+rgKu2NPzOiclg8qtHn9iG2IMTWdvxxqD5T1BAWR07yJ
gSEKdMu3eMa1G+3BHCVVh50OtZcIw00ZjsJmtMQddwv9PJH39gy59vHnRPlju8VR
Fi1HECtOyj0YY6sH+qH0QlsJjWwGO2uCDRKHUNke9HKMn+qCKWsZ5INdY3+c61yC
ybW8Z0EGWsVewY53n5XNnGEJoAUSoMjyBlHO62/4vd8j/Tsy8ZsCxq/01JCkofL1
MDTD84p/0r379datrbXKRu6c1RCKjg==
=ph1+
-----END PGP SIGNATURE-----

--JwakjBWjo5Y6WgSv--