Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Date:   Tue, 31 Oct 2023 09:39:01 -0400
From:   Hugo Villeneuve <hugo@hugovil.com>
To:     =?ISO-8859-1?Q?Th=E9o?= Lebrun <theo.lebrun@bootlin.com>
Cc:     "Russell King" <linux@armlinux.org.uk>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        "Jiri Slaby" <jirislaby@kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-serial@vger.kernel.org>,
        "Linus Walleij" <linus.walleij@linaro.org>,
        "Gregory CLEMENT" <gregory.clement@bootlin.com>,
        "Alexandre Belloni" <alexandre.belloni@bootlin.com>,
        "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
        "Vladimir Kondratiev" <vladimir.kondratiev@mobileye.com>,
        "Tawfik Bayouk" <tawfik.bayouk@mobileye.com>
Message-Id: <20231031093901.aa085ec1316ab0d008cb0080@hugovil.com>
In-Reply-To: <CWMITJ9VX9IP.1WPQCX981VRDE@tleb-bootlin-xps13-01>
References: <20231026-mbly-uart-v1-0-9258eea297d3@bootlin.com>
        <20231026-mbly-uart-v1-6-9258eea297d3@bootlin.com>
        <20231026105329.0ee9603563202bd2157a7d27@hugovil.com>
        <CWMITJ9VX9IP.1WPQCX981VRDE@tleb-bootlin-xps13-01>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH 6/6] tty: serial: amba-pl011: Parse bits option as 5, 6,
 7 or 8 in _get_options
Precedence: bulk

On Tue, 31 Oct 2023 10:35:29 +0100
Th=E9o Lebrun <theo.lebrun@bootlin.com> wrote:

> Hello,
>=20
> On Thu Oct 26, 2023 at 4:53 PM CEST, Hugo Villeneuve wrote:
> > On Thu, 26 Oct 2023 12:41:23 +0200
> > Th=E9o Lebrun <theo.lebrun@bootlin.com> wrote:
> >
> > Hi,
> > I would change the commit title to better indicate that you add support
> > for bits 5 and 6, which was missing.
> >
> > Maybe "Add support for 5 and 6 bits in..." ?
> >
> > > pl011_console_get_options() gets called to retrieve currently configu=
red
> > > options from the registers. Previously, LCRH_TX.WLEN was being parsed
> >
> > It took me some time to understand your explanation :) Maybe change
> > to:
> >
> > "Previously, only 7 or 8 bits were supported."
> >
> > > as either 7 or 8 (fallback). Hardware supports values from 5 to 8
> >
> > Add bits:
> >
> > "5 to 8 bits..."
> >
> > And indicate that this patch adds support for 5 and 6 bits.
>=20
> I agree the whole commit message is unclear. Let's rewrite it. What do
> you think of the following:
>=20
>    tty: serial: amba-pl011: Allow parsing word length of 5/6 bits at cons=
ole setup
>=20
>    If no options are given at console setup, we parse hardware register
>    LCRH_TX.WLEN for bits per word. We compare the value to the 7 bits
>    value (UART01x_LCRH_WLEN_7). If the hardware is configured for 5, 6
>    or 8 bits per word, we fallback to 8 bits.
>=20
>    Change that behavior to parse the whole range available: from 5 to 8
>    bits per word.
>=20
> Note that we don't add support for 5/6 bits, we only update the parsing
> of the regs (if no options are passed at setup) to reflect the current
> hardware config. The behavior will be different only if the inherited
> value (from reset/bootloader) is 5 or 6: previously we guessed 8 bits
> word length, now we guess the right value.
>=20
> What's your opinion on this new commit message?

Hi,
that's fine with me.

Hugo.