Received: by 2002:a05:7412:f589:b0:e2:908c:2ebd with SMTP id eh9csp261525rdb; Tue, 31 Oct 2023 06:59:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGj9Qo6jiQ5bF+s19b6KRjeI7ZsnwG/A5n16/fW32EkHMDwgN86uQTs97HUMEPLk2ViNArV X-Received: by 2002:a05:6358:6f9a:b0:168:e621:e3b6 with SMTP id s26-20020a0563586f9a00b00168e621e3b6mr13163321rwn.28.1698760747661; Tue, 31 Oct 2023 06:59:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698760747; cv=none; d=google.com; s=arc-20160816; b=tWWsRhnxFhENhUoc9DOjvpMWjlhxN2ue8+W6l/YvlSte8+rsgA5sTqy/XuEzTzrB8u 3jdNgNBarzC45I6ZTOCe0tYtegO/hHoB52CPDuZVLNXIyAljR8E4DugJYk3UVDhGmGHa X8FQbeR77h0cYCTanhMsEVBQofGk3iHwplhN42BlBJEVFL04zxgSJD3R2Bgh0qaMXnIC TO4izRCr6vBUboGnGqYIwi+WSWiSAg7IsssjW/jV2JZAXPSlJuetjKmaZalBn1rX2aJn 7CwnBhwivUQwuJzeifODwUdxasJEBuWiJ7MuvdOOb9IKvQQhPuttAWWUACzfgfD4FMe9 k0lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:to:content-language:subject:user-agent:mime-version :date:message-id:sender:dkim-signature; bh=nFSzN0qB/rDlQmVQqenx5aRuN9j+757zSYTQcoa06Co=; fh=k+liGYM5Ae8JoBrgjtmn3PPpME3ubtrJCJZtfo+8u+w=; b=oAUDrxumpaenN3AkINgLDyu5tJtrOECut29dcMSVw9DrxW5x96UA730y8niAByr+Ik 3LaUDdydB/yEu9eeivY0rAPmWG0POGdoGFVPYYKZxhBl+Hc95pV7b+ASmALhv4y4X/fH TOODfOw3hxAp7hOZ9zvbrAwXOoWrK5fKa6aZvWHdGcVyckyCHSoYP8p89ivuV54cyHEa lx06O1YVFGCLTC/hSCNKRsS4nnWctVt+U4q5+HsoeCJh+XQTwNCVUY0lhcLGYsRzbZ+U K2f6VSwjthh9AVLn0Ge7IAhEs1uMaPBsBc5PxlFbN4clKEyCs/D7N36pqUjDyAk58Mgv LYXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=KBG+MTlt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id c17-20020a6566d1000000b005b9483bf765si1058400pgw.25.2023.10.31.06.59.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Oct 2023 06:59:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=KBG+MTlt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 8AD228053FA2; Tue, 31 Oct 2023 06:59:04 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344693AbjJaN66 (ORCPT + 99 others); Tue, 31 Oct 2023 09:58:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344719AbjJaN6y (ORCPT ); Tue, 31 Oct 2023 09:58:54 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68618E6; Tue, 31 Oct 2023 06:58:51 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-6c10f098a27so1832043b3a.2; Tue, 31 Oct 2023 06:58:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698760731; x=1699365531; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=nFSzN0qB/rDlQmVQqenx5aRuN9j+757zSYTQcoa06Co=; b=KBG+MTltFaMNiD3lBhJcyhsC2NueYnX1NunlLiAXBT/3gJF7lgE2rtMh+8lavHU9br rbKFHjf7jnj1vSYQjS/TeVWelQJGsWct5OH3aZKUDe66w/4/cDZW9r3eE8XlazQ+6XQI KZ2CDaLD7Bye0bAOWQMdRXt6ji0Cozc4crc60sqMnbFp3d2PoGgqe6a9jjILo2rYr6+b mykrAongvIwD7W2IcYx8kLMj+IBK+r2ABihO5xKejqKyrdUMjJlqVlI3yIYddsXhLkIn MWtKgoV9H8GB0jaXPiXp/UuJq0Eu0ofXpj1McBB0XwZ3zPOe0sawbWxH4GFFqehL7ZEj 3ZBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698760731; x=1699365531; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nFSzN0qB/rDlQmVQqenx5aRuN9j+757zSYTQcoa06Co=; b=YeqdSdOYbbOcBru5vcOln4AiFwtN3ydRJZEBv5Orbk781gRRCBerOJ2a1Df2gTb+tR oqcP0t4gFLwOLhrn+l2tKeKoEUmpFjD3SNrIQj4ppbymWFsm93XhDh18ueS25yhAXKSx VRI6r4kNAN6pV1Y6ZLacqQQtwYbYppi9IzEwxZaPPLm4vW9XzrGHfJ74WvAtexD62pwO LiYwt6mwldytoo7/knj27XQIheZRxglyer5hQu5AdVY3FgS2/29o2w4aX/BpiR27Splx B1BwuhvoYVqo/deGG+N8JeabH2I9+py88SKWIS1C602Qhrv+RtBV7WOQirMQboMmPTdZ q4zA== X-Gm-Message-State: AOJu0YwfLh9NFggSEHzhnHkPJJB/3UpcR4tTueoR7WkNFGPismQAipkv x8/UYLwaaDoEl+48J7JAvEc= X-Received: by 2002:a05:6a00:2d16:b0:68e:351b:15b8 with SMTP id fa22-20020a056a002d1600b0068e351b15b8mr10845531pfb.12.1698760730668; Tue, 31 Oct 2023 06:58:50 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id c11-20020a056a00248b00b0068fb783d0c6sm1322685pfv.141.2023.10.31.06.58.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Oct 2023 06:58:50 -0700 (PDT) Sender: Guenter Roeck Message-ID: <7cc209b6-c762-4cd2-bbac-bc6b0cc36166@roeck-us.net> Date: Tue, 31 Oct 2023 06:58:48 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] drivers: rtc: max31335: initial commit Content-Language: en-US To: "Miclaus, Antoniu" , Alessandro Zummo , Alexandre Belloni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jean Delvare , "linux-rtc@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-hwmon@vger.kernel.org" References: <20231030115016.97823-1-antoniu.miclaus@analog.com> <20231030115016.97823-3-antoniu.miclaus@analog.com> From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 31 Oct 2023 06:59:04 -0700 (PDT) On 10/31/23 04:23, Miclaus, Antoniu wrote: [ ... ] >>> + if (status != MAX31335_STATUS1_DEFAULT) >>> + dev_err_probe(&client->dev, -EINVAL, >>> + "Unable to read from device.\n"); >>> + >> >> That is misleading. The device returned an unexpected status. >> I don't know if this really reflects a problem, but it is not >> "Unable to read from device". >> > > Since the device lacks an ID register, I found this as a suitable > replacement for checking that the communication with the > device actually works before the probe function finishes > successfully. > But the register read was successful. Also, why would you want to not instantiate the driver if the chip runs on VBAT, if the oscillator is running, if VBAT is low, or if some interrupt is pending for some reason ? Guenter