Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Tue, 31 Oct 2023 10:45:05 -0400
From:   Kent Overstreet <kent.overstreet@linux.dev>
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Linus Torvalds <torvalds@linux-foundation.org>,
        linux-bcachefs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] bcachefs for v6.7
Message-ID: <20231031144505.bqnxu3pgrodp7ukp@moria.home.lan>
References: <20231030145540.pjkggoiddobyjicq@moria.home.lan>
 <CAMuHMdXpwMdLuoWsNGa8qacT_5Wv-vSTz0xoBR5n_fnD9cNOuQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAMuHMdXpwMdLuoWsNGa8qacT_5Wv-vSTz0xoBR5n_fnD9cNOuQ@mail.gmail.com>
Precedence: bulk

On Tue, Oct 31, 2023 at 01:47:02PM +0100, Geert Uytterhoeven wrote:
> Hi Kent,
> 
> On Mon, Oct 30, 2023 at 3:56 PM Kent Overstreet
> <kent.overstreet@linux.dev> wrote:
> > The following changes since commit 0bb80ecc33a8fb5a682236443c1e740d5c917d1d:
> >
> >   Linux 6.6-rc1 (2023-09-10 16:28:41 -0700)
> >
> > are available in the Git repository at:
> >
> >   https://evilpiepirate.org/git/bcachefs.git tags/bcachefs-2023-10-30
> >
> > for you to fetch changes up to b827ac419721a106ae2fccaa40576b0594edad92:
> >
> >   exportfs: Change bcachefs fid_type enum to avoid conflicts (2023-10-26 16:41:00 -0400)
> >
> > ----------------------------------------------------------------
> > Initial bcachefs pull request for 6.7-rc1
> >
> > Here's the bcachefs filesystem pull request.
> >
> > One new patch since last week: the exportfs constants ended up
> > conflicting with other filesystems that are also getting added to the
> > global enum, so switched to new constants picked by Amir.
> >
> > I'll also be sending another pull request later on in the cycle bringing
> > things up to date my master branch that people are currently running;
> > that will be restricted to fs/bcachefs/, naturally.
> >
> > Testing - fstests as well as the bcachefs specific tests in ktest:
> >   https://evilpiepirate.org/~testdashboard/ci?branch=bcachefs-for-upstream
> >
> > It's also been soaking in linux-next, which resulted in a whole bunch of
> > smatch complaints and fixes and a patch or two from Kees.
> >
> > The only new non fs/bcachefs/ patch is the objtool patch that adds
> > bcachefs functions to the list of noreturns. The patch that exports
> > osq_lock() has been dropped for now, per Ingo.
> 
> Thanks for your PR!
> 
> >  fs/bcachefs/mean_and_variance.c                 |  159 ++
> >  fs/bcachefs/mean_and_variance.h                 |  198 ++
> >  fs/bcachefs/mean_and_variance_test.c            |  240 ++
> 
> Looking into missing dependencies for MEAN_AND_VARIANCE_UNIT_TEST and
> failing mean_and_variance tests, this does not seem to match what was
> submitted for public review?
> 
> Lore only has:
> "[PATCH 31/32] lib: add mean and variance module."
> https://lore.kernel.org/all/20230509165657.1735798-32-kent.overstreet@linux.dev/

It was later moved back into fs/bcachefs/, yes. I want to consolidate
the time stats code in bcachefs and bcachefs, so I'll be sending a PR to
move it back out at some point.

Can you point me at what's failing?