Received: by 2002:a05:7412:f589:b0:e2:908c:2ebd with SMTP id eh9csp297928rdb; Tue, 31 Oct 2023 07:51:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHDJV6AqM/CfPN1RAqrVxfpVyvuj95XAPJ4APrclgAAqghOg64AvZbmWxEcpATrtqtoezpF X-Received: by 2002:a05:6358:897:b0:168:e370:6986 with SMTP id m23-20020a056358089700b00168e3706986mr13617415rwj.26.1698763900255; Tue, 31 Oct 2023 07:51:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698763900; cv=none; d=google.com; s=arc-20160816; b=EWAP2eZ0xT/ytVPtsit0EwQQukZwgRMA295oXFEJzKiLc4ARZnDlu8b4X4Uio06Lh7 0tbFvu5PzxnaRCrksPc/DDUBYMZS/pDctSCfElMdehY5kXCSrM5+ySsT1bsWdmUgZXwY aRbMbYVE5YFJhnbjEoloDzK/iZhPMmMNnrybr/ymM1jB3tObB/fPRsprLK/Tey4fh5Wd m60aItrD+9jUjDmkvN7OagauvNkZzRwG/bx/j9NrlsPyErEk0W9X5uD5K26AgUOkcO1z pyTfJJvqQjccvRpGGynF8YAhLWeFZSJ1/kCPY3sTTR5tE8RoBiBLtIar2hVIPWN4yn7y TorQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:sender:dkim-signature; bh=90p+Ev9PObByrmKNOtd680aQ56JEMH8qyqlYgw5xuYw=; fh=He7Hf//wiXGr7SZDT0mE+6npVchqCSHDtoguqlEKCWc=; b=tRWlyz3Lh+9Bcg5znbexpHlT3SeijHi7XcvS5/dyISKm+8uakzy3y4EKlLLM0oHy/f L1doQAMCKawFkWk7FONnoUNkVL1AZTxJjIi/supWAswYWW61dEAyzH9JYkVOpuR7a9vV R/RDF2/+g0iu37WK7fSYKy3ZHL9IgQ9i4mwGWhLqbo6+jGV1Va6yJvPugFKRkrbxpetV Tbh5mgwhanPdDuLIzeuw8FCaNZjfb55nH4t+DXmWKqKKIwMvUbd5+yW0wrJcQO4oPgcN OGwLLlbznuLV0sIHApyAmU3HafBnG6eg5IaMkqAfshPUG4oFZjU92xGmg2OYpdPZ0qpU LgQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Ka13Y3Fy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id t71-20020a63814a000000b005ab05858e70si1119851pgd.782.2023.10.31.07.51.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Oct 2023 07:51:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Ka13Y3Fy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id EA231805DC0A; Tue, 31 Oct 2023 07:51:38 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344572AbjJaOvi (ORCPT + 99 others); Tue, 31 Oct 2023 10:51:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344518AbjJaOvh (ORCPT ); Tue, 31 Oct 2023 10:51:37 -0400 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFFD4ED; Tue, 31 Oct 2023 07:51:34 -0700 (PDT) Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1cc3bb32b5dso26381085ad.3; Tue, 31 Oct 2023 07:51:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698763894; x=1699368694; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=90p+Ev9PObByrmKNOtd680aQ56JEMH8qyqlYgw5xuYw=; b=Ka13Y3Fy7gtiBt43Gr204NlYO6zPa40IND9S9cP96SH6VYQ1OBrcMtrWcBHp1+NM3k tYCNAcnwoxd5RYH/BnAkE5taW1eAkkfPDV3ejPmKGBj054gfqSaLcpRxnh/eC3Wy2zJa R2hxWKww4aTlE2OkzUtBcbmh64KXeFbfLfLd+YOsElZg5rVYb2HNwvV02UzvhpfDtC51 ibIS+6rz/G0PsdIorQYagQbdBbHn0/iPzQc2puQ0JvywBhtKv03jVDSVoeE2+edYfs2p peaMy7vNvCPp4xxr7qeS2prN0aGd8bklcfw7SXbPuWma8SmT4ZMnK0JufDZVGcZndx5W db+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698763894; x=1699368694; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=90p+Ev9PObByrmKNOtd680aQ56JEMH8qyqlYgw5xuYw=; b=uxP7oFZBBfPoB1PfL8xHnVDdJ0EICbdC+RhMHLTgKqhihUyFk05QcNdeoVlj3Xkygr HwU0Xrt3KFyfgcOtiJt0P2wh7hydKkxekDdC/eXAbNHNG9J6ZecSHiVwxoXws4q3nZqv TCAaRS2YuvCUaCdfAm/RfTRnIsiItUqR91TsJ+Wdz1mjuz0kq5Tj1X5on3dz85BtdRk0 pIIWlZEq7N6r29Dge6bpo0a0mTNZAJlW4S5BDXbzORHzLx93Wu4SOTrBqvk3P22bBU4R /FldNaeSXMioOoHSEke/QtqhcVdkOxnwcUWxhTKDlGPX7DbfZ7O1QbCXhRo8Ix68UXT+ AG6w== X-Gm-Message-State: AOJu0Yx1bvI+xHgtcufM3fQ5cPuuVwJRGvuh4tl0BHlvj9FnoT/eha0r ETLCt9rU6Og2KjOeNKCdY3U= X-Received: by 2002:a17:903:245:b0:1c3:6d97:e89e with SMTP id j5-20020a170903024500b001c36d97e89emr16539909plh.58.1698763894412; Tue, 31 Oct 2023 07:51:34 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id c24-20020a170902d91800b001c611e9a5fdsm1418836plz.306.2023.10.31.07.51.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Oct 2023 07:51:34 -0700 (PDT) Sender: Guenter Roeck Message-ID: <4ab27937-df39-44bf-967c-0f8ddc987879@roeck-us.net> Date: Tue, 31 Oct 2023 07:51:32 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] hwmon:Add MEC172x Micro Chip driver for Lenovo motherboards Content-Language: en-US To: David Ober , linux-hwmon@vger.kernel.org Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, jdelvare@suse.com, corbet@lwn.net, dober@lenovo.com, mpearson@lenovo.com References: <20231031120942.4404-1-dober6023@gmail.com> From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: <20231031120942.4404-1-dober6023@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 31 Oct 2023 07:51:39 -0700 (PDT) On 10/31/23 05:09, David Ober wrote: > This addition adds in the ability for the system to scan the > MEC172x EC chip in Lenovo ThinkStation systems to get the > current fan RPM speeds and the Maximum speed value for each > fan also provides the current CPU and DIMM thermal status > > Signed-off-by: David Ober > > v2 fixed mixcased naming > v2 add mutex protection > v2 removed references to ACPI as it is not used > v2 added comment to explain why returning a -1 is needed > --- > drivers/hwmon/lenovo-ec-sensors.c | 81 ++++++++++++++++++------------- What is this patch based on ? I don't see that driver in drivers/hwmon/, and based on the patch I would be surprised if I had accepted it. Guenter