Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
From:   Sarah Walker <sarah.walker@imgtec.com>
To:     <dri-devel@lists.freedesktop.org>
CC:     <frank.binns@imgtec.com>, <donald.robson@imgtec.com>,
        <boris.brezillon@collabora.com>, <faith.ekstrand@collabora.com>,
        <airlied@gmail.com>, <daniel@ffwll.ch>,
        <maarten.lankhorst@linux.intel.com>, <mripard@kernel.org>,
        <tzimmermann@suse.de>, <afd@ti.com>, <hns@goldelico.com>,
        <matthew.brost@intel.com>, <christian.koenig@amd.com>,
        <luben.tuikov@amd.com>, <dakr@redhat.com>,
        <linux-kernel@vger.kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
        <devicetree@vger.kernel.org>, <corbet@lwn.net>,
        <linux-doc@vger.kernel.org>
Subject: [PATCH v8 02/20] drm/gpuvm: Helper to get range of unmap from a remap op.
Date:   Tue, 31 Oct 2023 15:12:39 +0000
Message-Id: <20231031151257.90350-3-sarah.walker@imgtec.com>
In-Reply-To: <20231031151257.90350-1-sarah.walker@imgtec.com>
References: <20231031151257.90350-1-sarah.walker@imgtec.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CFJeGopJ2IXOW38TQ+LKzVM7ATOWHJ6P9g8Q7pEp9rDIaU55ZGGtDmtKw9O/?=
 =?us-ascii?Q?fnsa9p5T6jP8JPWDI7cAIHMJwcxwnL9b3svt9rOsGLeM5CVpCBMqz4iYiHi5?=
 =?us-ascii?Q?thaVRKTNc7yxI2v6bm65JkBFDD6rux3x8jjIe2KHeyaoFgApI7kSw3sxtj2+?=
 =?us-ascii?Q?8L3tFNDzwe1sNd/3UliL4tEHxIhko5tu7YF4lZlzeDamwGXolDUZw8fZOaT8?=
 =?us-ascii?Q?uKoSyq+eJa4gY+omkWWcyHD0DLfUlYEWgp++KBPEC3H6CGT01hNWf8mGEhZO?=
 =?us-ascii?Q?AQ4w0b89dCmYcCDuNHdgd3Ks/DNvPaPWnxohRPtyNbDFbkUDZEsu+8ehNKZT?=
 =?us-ascii?Q?Rw9aNNpPC/zDqB0XyiLigkc9H0qweDYTciihr8czcO8voz8T9yGg+9wHmyAX?=
 =?us-ascii?Q?X8U+RaFgN5X2OZhvm2+G3XZdIqkK2MZaJ4ETsmMg01rcf41U8NveWBraPqcG?=
 =?us-ascii?Q?see1+NiKhesCwuBENmQWllYcRBHFnjqi0xHQcMUW/dwnDTbshK3tdPlzLlrJ?=
 =?us-ascii?Q?Nih3rrn815ws/0sMZv/kLVMEkSWcHRWFCrCNUblQhyjGxXmgE/LJE9CAnL2X?=
 =?us-ascii?Q?jmFR/ez9OfSpnKLANqdOT5eW8zZ3KEs6E1x1jbSJS0Oq//fnTq2UbuEXE67F?=
 =?us-ascii?Q?8UlevBnE7mQtIdH6LSw84Edgub2H5LTAZEY5oNINZhXQ9Mw6vCpZfAlJkB7g?=
 =?us-ascii?Q?L3PJ0Nrr2CVa1TRm2uXobkQPwnY5xWwQcVVGbXJpioxG0L5TrAMdjcZwwikX?=
 =?us-ascii?Q?Ai4PtHO5sd10v4U7Q0E07NNIeDMDlkwIutzOtRtiGHthO7hh2A1pwoGl8YnM?=
 =?us-ascii?Q?iUHdNm/Rr7+5VZJzg2hl9C+jvcn2TmmwWvI1lN88G+0Ml3d7U4GD8PypZ1E/?=
 =?us-ascii?Q?gOzCFqhyi3avMBxs1oPE6rIyl4Ijx0RHob9+yPwCNQlyisCzAFqVEOYHeLT4?=
 =?us-ascii?Q?zQzRtsYYjnc7Dh/h1iEaqc9zSwVBQE2zdYVdvHxKvlBb/jq7JRt6vqkUmLiH?=
 =?us-ascii?Q?RWVIzZpBPAR0GDsrXPIHwUtqq0vKsRefe1/e17UD2we4avdrPUEbaiza+faW?=
 =?us-ascii?Q?TAa+cH7CDm4DmCOS7KI0Wb43fECLbBodgG+rG5lI34lY8/FIDbK0GU+ERVa4?=
 =?us-ascii?Q?F051jwJspP1IC2MLFj1nk6oTZDsl2Xj8cffblLzQdSxdptgAvgKVQT9NyG20?=
 =?us-ascii?Q?sE71ztE/AF8lHg9T0LGhcyZyk0mwXnEoGKDf5DH/JnxpM2ucqUu7jFYMhKY4?=
 =?us-ascii?Q?2xd2Q8dNfFPBfIMvV+plfWr/UBAyNk8GBjEaiAtbyZ5PSP3EluJExx5hEynN?=
 =?us-ascii?Q?uGssLx/MdPLZtD6fpDuJV97bllen/kd2sBo8JAyW+nMysGS0OPt9o5XEzcjN?=
 =?us-ascii?Q?JZpm6srViYazPpTxydcXM5OsiOgyReHQUO/+M99hEWMWRmntsyM5PtldMjfU?=
 =?us-ascii?Q?ZyffQLrZFn2a6VhGrCa4DEQW74+5pHuKo6DDePHq7U7XS00apaU8eFCGGu7R?=
 =?us-ascii?Q?2N5SbeCggQq6+KdB4nwBZ6kF342dNm3iaxJF46bk9ljsRNCUBwKyJ9vQ3eW4?=
 =?us-ascii?Q?OdpRmk/C9nFgrnq0iFIH4lTCF4mmC4WVRQtDXyjcvytygEPmiiZEqhysrBki?=
 =?us-ascii?Q?qA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bb9d657a-e6a5-402e-07a0-08dbda23e702
X-MS-Exchange-CrossTenant-AuthSource: CWLP265MB4817.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2023 15:13:13.8697
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0d5fd8bb-e8c2-4e0a-8dd5-2c264f7140fe
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0Q+qRis1JlA6Hx0n5xUaztT5M7CmdLZDnVCTz04KndIQIHBNF25CN7T/cCHlFi1FxlS5o+/ZdEjn0CibGDJC4Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO4P265MB6572
X-OriginatorOrg: imgtec.com
X-EXCLAIMER-MD-CONFIG: 15a78312-3e47-46eb-9010-2e54d84a9631
X-Proofpoint-GUID: yfYyzTRkdHN4eWD5wtxsufvpSC20sKxB
X-Proofpoint-ORIG-GUID: yfYyzTRkdHN4eWD5wtxsufvpSC20sKxB
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 31 Oct 2023 08:14:17 -0700 (PDT)

From: Donald Robson <donald.robson@imgtec.com>

Determining the start and range of the unmap stage of a remap op is a
common piece of code currently implemented by multiple drivers. Add a
helper for this.

Changes since v7:
- Renamed helper to drm_gpuva_op_remap_to_unmap_range()
- Improved documentation

Changes since v6:
- Remove use of __always_inline

Signed-off-by: Donald Robson <donald.robson@imgtec.com>
Signed-off-by: Sarah Walker <sarah.walker@imgtec.com>
---
 include/drm/drm_gpuvm.h | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/include/drm/drm_gpuvm.h b/include/drm/drm_gpuvm.h
index c7ed6bf441d4..c64585dc4e8e 100644
--- a/include/drm/drm_gpuvm.h
+++ b/include/drm/drm_gpuvm.h
@@ -702,4 +702,32 @@ void drm_gpuva_remap(struct drm_gpuva *prev,
 
 void drm_gpuva_unmap(struct drm_gpuva_op_unmap *op);
 
+/**
+ * drm_gpuva_op_remap_to_unmap_range() - Helper to get the start and range of
+ * the unmap stage of a remap op.
+ * @op: Remap op.
+ * @start_addr: Output pointer for the start of the required unmap.
+ * @range: Output pointer for the length of the required unmap.
+ *
+ * The given start address and range will be set such that they represent the
+ * range of the address space that was previously covered by the mapping being
+ * re-mapped, but is now empty.
+ */
+static inline void
+drm_gpuva_op_remap_to_unmap_range(const struct drm_gpuva_op_remap *op,
+				  u64 *start_addr, u64 *range)
+{
+	const u64 va_start = op->prev ?
+			     op->prev->va.addr + op->prev->va.range :
+			     op->unmap->va->va.addr;
+	const u64 va_end = op->next ?
+			   op->next->va.addr :
+			   op->unmap->va->va.addr + op->unmap->va->va.range;
+
+	if (start_addr)
+		*start_addr = va_start;
+	if (range)
+		*range = va_end - va_start;
+}
+
 #endif /* __DRM_GPUVM_H__ */
-- 
2.42.0