Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
From:   "Miclaus, Antoniu" <Antoniu.Miclaus@analog.com>
To:     Alexandre Belloni <alexandre.belloni@bootlin.com>
CC:     Guenter Roeck <linux@roeck-us.net>,
        Alessandro Zummo <a.zummo@towertech.it>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Jean Delvare <jdelvare@suse.com>,
        "linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>
Subject: RE: [PATCH 2/2] drivers: rtc: max31335: initial commit
Thread-Topic: [PATCH 2/2] drivers: rtc: max31335: initial commit
Thread-Index: AQHaCyeLjVRbnUBr8Uu9pZ9Nut/xb7BioqKAgAEesVCAACvqAIAADU+A
Date:   Tue, 31 Oct 2023 14:43:24 +0000
Message-ID: <CY4PR03MB3399C30F209B2061EFC804C49BA0A@CY4PR03MB3399.namprd03.prod.outlook.com>
References: <20231030115016.97823-1-antoniu.miclaus@analog.com>
 <20231030115016.97823-3-antoniu.miclaus@analog.com>
 <ce07d951-f492-4137-9588-1d55001e0003@roeck-us.net>
 <CY4PR03MB339979DBB7ADBFC3872156019BA0A@CY4PR03MB3399.namprd03.prod.outlook.com>
 <202310311354329a21a9d0@mail.local>
In-Reply-To: <202310311354329a21a9d0@mail.local>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Q7HAkNgSjMKaNmRpWaEGiPaL2T7vJc2KA1ewk8foXkDzK+qkHRG5kOBgw+X7?=
 =?us-ascii?Q?UIh0I9a2T+cv1T8ThhhEGKCPUzTj9cY/fUKxB9AMoSNPc3IUgnB7sFu2mnlR?=
 =?us-ascii?Q?a+Zvx8wupdMgdcaId7chKSLiBghzaByVB2R3DWX72sX/NguLih8aP2tiXCJW?=
 =?us-ascii?Q?ErhDw04grrT2xVLWyfHhCVxjAVTw5Vtww7cJBRoEPKtDdkQUe0tQ1Vlc381z?=
 =?us-ascii?Q?mHk+/VfQJEsoeUebo5YV4Y/I8DbMuwVpVGvEGFow+fpzdA+nKsD+pUgjaHxJ?=
 =?us-ascii?Q?vLPE81eASUepj0Nzz/hnvvZF3Eup59tT6XB5y2hdDA5KpWztdZDXrDuof94L?=
 =?us-ascii?Q?jhMfZnYX9DV20tq2ip1FH+tp3frTKtb9G3LYyT26TBC3Rk2vF62dc2InU1DT?=
 =?us-ascii?Q?oHdjREnERF9O1CMzEDKEreGVID3/n78M/gCu0tPosJLQ56SkLin+5eHNGoyF?=
 =?us-ascii?Q?098zui+EZ+2yXCnHApVA0A+6g7YMbUrU3KGQD+P6RuCVpQ21QGv/z2TuiRss?=
 =?us-ascii?Q?SHQziC41ubOVpi/1NKF9M8auApnUafyOTj/cqPsLwvREUgKiFENiw/hnVUCX?=
 =?us-ascii?Q?dX9xVDaUaZR9OR3YSmTd2wkIBIQFrfdf15r+Z3F3bGr2Gxk02wqT1l4wwDNi?=
 =?us-ascii?Q?6FfBFEpIIJJwESQhVUDtMlFh4CaYEPJTvqIAlg7Fvd5C752WEcgQmlqbDB5G?=
 =?us-ascii?Q?tPb27QZBl0HV7Ch1MwMPZSFafzf6gdhI3TnDZIhYOigL3Nroo/SE4ihG6vD7?=
 =?us-ascii?Q?ccFNRO4f2SFR25csbLStoG7O6vFpn/ykVdqgSr6vRnZV57/x2TCBXx5lnXyN?=
 =?us-ascii?Q?ZIKElBpWHha+Fgp21saXEqaT9KxWtGwCoUOPn4thiCOGOzqKmfmqd/zXeEos?=
 =?us-ascii?Q?LhGhMzzcHH/VnfcsE3rPgGl5TH0kOoksLGA80l5lOaV6NqUZULVjnW0iGp/H?=
 =?us-ascii?Q?whkHC9NzSDiEtCRcOpHfFlW95/vfMnP134W0UgzEycvk6NnHSWQOwjodeTM8?=
 =?us-ascii?Q?9fK7iOOrUsTtEQcJf+VaxZOzF2E18YgwsCJKzTeJt8Q6NVrBUvAWfSaln+jP?=
 =?us-ascii?Q?Aw+u3FRkozq4FBum7tBRRcHcKTg+UmWw4A19z9vjQ8k1sE6MFt4UgmTWrAV6?=
 =?us-ascii?Q?l34Y14q7QYxyLX5vMLB6syPWAxMNUBOMz7BSZ6qWj6+dWOvyWttGqHI7LsKA?=
 =?us-ascii?Q?jh0n1tt0px2lV254nU5Lao8DZbMIyRfNOUFiGdTH+EDUOMho/rHXICD5vzzM?=
 =?us-ascii?Q?jKKSDgCBPHRTvutcs+ZrybE2Xh61t6ccTjBznzkKmDFAq5wcIBw69CAFgsHZ?=
 =?us-ascii?Q?2xRR1FgKxOMHykEIfkhhKRa+1hJaLs6Gt+DW/Wvok94Q4A2niIpdQRUzO+ET?=
 =?us-ascii?Q?bLyqED91fweaUgqYkJEJUEBa9EJOlYGgoUzhClJ1rkeL0Y572tk77nUa8/WE?=
 =?us-ascii?Q?A3cpD0H0D+jMnNF5eogorH9wP5yXfxVSHwk/GTcjYUtWosJJbKWm2ewMQVGC?=
 =?us-ascii?Q?Oe/aIkPWn8GyyuJsFS2ZKPwfuog5Xtz6vRSgDYLFpOKM0UAU8YYitZ2bTh+y?=
 =?us-ascii?Q?MKf0fmay4lzc8GNhuFxVuRVQPYue8dw5Py4W3OWIwdOaSo3YBwMZGLmp0HVP?=
 =?us-ascii?Q?9A=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CY4PR03MB3399.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dca74c4a-c3c4-42a5-6159-08dbda1fbc9e
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2023 14:43:24.5913
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: pd0lX3yz/i1ugxMtuL4CSdbC1rLEkEKpaqHRNMDlzt65qJruBlJcuJ+0UzbS1f118QYDUBq7Eb0XG5W/Es0HuaY5/Vwpc975S2+x5+iVZog=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR03MB6750
X-Proofpoint-GUID: eO4ssr_kcYR3acBc0e-FLF_H2ZOiMWp0
X-Proofpoint-ORIG-GUID: eO4ssr_kcYR3acBc0e-FLF_H2ZOiMWp0
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-31_02,2023-10-31_03,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015
 lowpriorityscore=0 mlxscore=0 phishscore=0 impostorscore=0 malwarescore=0
 priorityscore=1501 suspectscore=0 spamscore=0 bulkscore=0 mlxlogscore=645
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.19.0-2310240000 definitions=main-2310310120
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 31 Oct 2023 08:20:42 -0700 (PDT)
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email

> On 31/10/2023 11:23:49+0000, Miclaus, Antoniu wrote:
> > > > +	if (status !=3D MAX31335_STATUS1_DEFAULT)
> > > > +		dev_err_probe(&client->dev, -EINVAL,
> > > > +			      "Unable to read from device.\n");
> > > > +
> > >
> > > That is misleading. The device returned an unexpected status.
> > > I don't know if this really reflects a problem, but it is not
> > > "Unable to read from device".
> > >
> >
> > Since the device lacks an ID register, I found this as a suitable
> > replacement for checking that the communication with the
> > device actually works before the probe function finishes
> > successfully.
> >
> > I will be more specific in the dev_err_probe message in the
> > upcoming patch version.
> >
>=20
> What if this is a transient bus error and the device is actually present
> and working?
>  don't like this kind of check, they are not usually useful.
>=20

Got it. Will drop the check in the next patch version.

> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://urldefense.com/v3/__https://bootlin.com__;!!A3Ni8CS0y2Y!9HB62f
> 1sSispWlqUtpamRif0eXxFGCqLzQD3KSwVl9t97YNev9s6akJCbWJ71dcIettiLkqz
> xyFpR_e8H_tCWl82OcBdHjBG$