Received: by 2002:a05:7412:f589:b0:e2:908c:2ebd with SMTP id eh9csp320548rdb; Tue, 31 Oct 2023 08:23:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGfA5B3NwRVsNzkDslF51thGsYZFz2qibOv52/GuoZNjgGIZoHUpoxP4P3v9r1CVifglxkV X-Received: by 2002:a05:6a20:e192:b0:13d:ee19:7727 with SMTP id ks18-20020a056a20e19200b0013dee197727mr9043486pzb.18.1698765782838; Tue, 31 Oct 2023 08:23:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698765782; cv=none; d=google.com; s=arc-20160816; b=z8R68lXHoRgOUJrYhRzUT0woEr7pq3iiD2BrHv9tY94mYnLdvb0RjwuH9djBvY2Fh1 WDasd9UKx8O8+jIsWJGjcONMl/QkdIjIXZ4de8GKoxugm7zheO3OjO7ktOEw3AKcKEqp miGKv3sei7eHW690S5UWq1uaoZoq7HRkhbad2ylbRxRBRobXiwoARipLaFBU6ysiQDW7 YO+xbyJMO8wuZRCtMM/uMc2ZQPOCrBHsPymjnGBQSrvHU+4p+ZVb5S+0D6bEnmC9B4JH A6gYOgniUC+40SxPiMJuHEUP5mNN4ndNzNdaNxMiOYsHfzqzveWMnSrnR3u5b6guS8e2 AlCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=gpn7ZRGOxLcov2CDlO4PfFlt+o93I0rAjoSFkpnD3iY=; fh=ZUgu6LhcX34GyGXnd2mEA4J/V9jNCNf27fY36hzyG3w=; b=oRoquTMB28AlOPcDHraXqAZ3Nkt1PHF3lfMQGOcN5e9p80HfSBHT5lxuiau0lCVMmc 1LTDX7x8cZO9aErpvFQoJAF7GQDgL2gOntD+WDn1mVdLRqDpwcNRT0Dsmv0uND9t2q6v c8LWn3e4EZtM9lHmciMGxVg4273GwkBaQPdU1GxPUAHzaRMY9wDCqa10lcZ1wr+eawBB 2+Wg1UF8nwuYkS+BRMQqz0g8Zs973XfWDQjNdeq4BYTZM4M97r1ehpXDMhS500oTfLmQ AT7BeLF5TwY/dzA7BZkqvT/ndwhRe/JKziPGxH6hXLiI+lCAfk9Vw9Z1XJ8DpcgxyI56 0pZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=Xl2J3rBt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id m11-20020a656a0b000000b0057d7cff25b8si1156723pgu.198.2023.10.31.08.22.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Oct 2023 08:23:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=Xl2J3rBt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 36679802A63B; Tue, 31 Oct 2023 08:22:51 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344814AbjJaPWJ (ORCPT + 99 others); Tue, 31 Oct 2023 11:22:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344795AbjJaPWE (ORCPT ); Tue, 31 Oct 2023 11:22:04 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F39B6173B; Tue, 31 Oct 2023 08:20:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=gpn7ZRGOxLcov2CDlO4PfFlt+o93I0rAjoSFkpnD3iY=; b=Xl2J3rBtNVfsn1qHeQLmQ6IiVf aJ174kGIp45ZnBLQFyfM5NzQhjRla82feOHpDSBb0SP+/qNlxKjWNtY19TIT0EmaZWDLbqTrGzi5n 9bTEE9Pw51B3LIWQIzVct1DTRjv6ZdhrddGv6+C+UtHGT+zLojSBZkecZgfPFlRR8/BIIAavyGGqb +gAH6/U0Hk6EzB8KAQeVVwnrtBdsNTEjyb69NaM1oxluQzZjRdQ7oH74O/MU9m/vbakB7XanHhf2e goHqvYAZJu4K8ryr1mgi5vycSwzpLupPvFOAh7rJoR1l04BkobsK6TYc3SgvhE+KhItzzu2C7Vvqg 0Jb1r3kA==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qxqXh-004toP-3A; Tue, 31 Oct 2023 15:20:34 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 9F105300473; Tue, 31 Oct 2023 16:20:33 +0100 (CET) Date: Tue, 31 Oct 2023 16:20:33 +0100 From: Peter Zijlstra To: "Paul E. McKenney" Cc: Frederic Weisbecker , LKML , Boqun Feng , Joel Fernandes , Josh Triplett , Mathieu Desnoyers , Neeraj Upadhyay , Steven Rostedt , Uladzislau Rezki , rcu , Zqiang , "Liam R . Howlett" , matz@suse.de, ubizjak@gmail.com Subject: Re: [PATCH 2/4] rcu/tasks: Handle new PF_IDLE semantics Message-ID: <20231031152033.GC15024@noisy.programming.kicks-ass.net> References: <20231027144050.110601-1-frederic@kernel.org> <20231027144050.110601-3-frederic@kernel.org> <20231027192026.GG26550@noisy.programming.kicks-ass.net> <2a0d52a5-5c28-498a-8df7-789f020e36ed@paulmck-laptop> <20231027224628.GI26550@noisy.programming.kicks-ass.net> <200c57ce-90a7-418b-9527-602dbf64231f@paulmck-laptop> <20231030082138.GJ26550@noisy.programming.kicks-ass.net> <622438a5-4d20-4bc9-86b9-f3de55ca6cda@paulmck-laptop> <20231031095202.GC35651@noisy.programming.kicks-ass.net> <58c82a9d-f796-4585-b392-401b8b9dbc2e@paulmck-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <58c82a9d-f796-4585-b392-401b8b9dbc2e@paulmck-laptop> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 31 Oct 2023 08:22:51 -0700 (PDT) On Tue, Oct 31, 2023 at 07:24:13AM -0700, Paul E. McKenney wrote: > So, at least until GCC catches up to clang's code generation, I take it > that you don't want WRITE_ONCE() for that ->nvcsw increment. Thoughts on > ->on_rq? I've not done the patch yet, but I suspect those would be fine, those are straight up stores, hard to get wrong (famous last words).