Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <50ac3b6b-7d96-ca7e-637a-109e29e74911@intel.com>
Date:   Tue, 31 Oct 2023 11:23:14 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v4 2/2] dmaengine: idxd: Fix incorrect descriptions for
 GRPCFG register
Content-Language: en-US
To:     'Guanjun' <guanjun@linux.alibaba.com>, <dave.jiang@intel.com>,
        <dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <vkoul@kernel.org>, <tony.luck@intel.com>, <fenghua.yu@intel.com>
CC:     <jing.lin@intel.com>, <ashok.raj@intel.com>,
        <sanjay.k.kumar@intel.com>, <megha.dey@intel.com>,
        <jacob.jun.pan@intel.com>, <yi.l.liu@intel.com>,
        <tglx@linutronix.de>
References: <20231031025511.1516342-1-guanjun@linux.alibaba.com>
 <20231031025511.1516342-3-guanjun@linux.alibaba.com>
From:   Lijun Pan <lijun.pan@intel.com>
In-Reply-To: <20231031025511.1516342-3-guanjun@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dTVjVFh3OXpGbkNEcFp3Q0hkWllzeXlxTXBQM1J6Yk05dXhlQVZKNWZqTXl1?=
 =?utf-8?B?ZHdIR0NOYm4vdHZ1ckMxZTI2dXVMVTRrSEhkOStMeFVCMDFZZ0M1RVRtT2Nr?=
 =?utf-8?B?R2JGT3ZZSjdpaERjYnoxZkhpNlYrZmZJeUJWSytmVDBVZVhhVFNuZ3lHdlMw?=
 =?utf-8?B?aXVCUlA0dkRHbWdkb3JZWFFsUThZOUtuYTA5cFc3TzRCNDJxck5LZVhmanQr?=
 =?utf-8?B?eW9pSTdWZGVhWTY2MGc0czR4VE9TWDdXeTVZZ3dsejgwTmpiM0dna0h5Z1Yy?=
 =?utf-8?B?Qy90L3Joc09DcS9FVDQ5ZWhkM2V4ZWI0VE9QWTZ1WHFxZlZYRVhpOXJWNU9h?=
 =?utf-8?B?Vm91TVVTeHNqNi9NWmh0UWhma1pNaTh1enNYYkErdWt0Z0JrYk5wZ2FXZmxV?=
 =?utf-8?B?cUhFV2FaWThFUk9WeFNHcmJ5SEdkSUo3SGN6ZnlXN3ViSk45aGE0TFlFcG9w?=
 =?utf-8?B?YVEzYUNxa1k3YVVKL2pTd3JXcmtOVk9VNFI2MkNkV3Y3RmRYcVdQVmdkaGZi?=
 =?utf-8?B?STIvaDV6ZlZ2eGNKNVBvQlhEMkY3RFVSaHoyMHlaOThSbUplZ1FxRXZSdHI4?=
 =?utf-8?B?bE9ETUF0M1B3cW5oQzM1bGtpOTdBdFJvZXZJOWV2cDF0VkQrTEJVRGRORElO?=
 =?utf-8?B?Q09hTFZjN2k4c2w5N3BzVXZIcDZ6dXlpUjBOZmIzNFg5SmozMHVvZ3U5V1RD?=
 =?utf-8?B?UFE3bytXallYRXlZd1ozc2V6ajgrRnBCc21RSXhOL3ZPeWpMR2lBeGZpblRJ?=
 =?utf-8?B?d3UrVkt0b3QyR2ZYTHRzS2NDSlVTSS91OVNQWXV0WmZRbzV4bmpFcDVJVVhW?=
 =?utf-8?B?YjUxdG9Sd29ONUtNRk5TbTBuM1pDVHJKdVNXZm5FZ0Q0SkpmdVE1dmRvMFRW?=
 =?utf-8?B?d0FJMmc5UUZrZ0FjZ2dFQ3I2OXJndU03bXNqSE9MNjBuYjhPK3UrREtsc0R6?=
 =?utf-8?B?MDUxaUFNSjRIOHNLSGRCNStjVHFmdTVkbjlYaWM4dWR2c0thQk16djBnR0FJ?=
 =?utf-8?B?TDdmMnR3TWVIQ0lMUTBzTTFaSUJBYTlnT3ViTnpJb1VnVTFjQzNuQjdCV0Nj?=
 =?utf-8?B?YlFScll6NjZqSnNPODVvQXgvUHB0REVzV1NPNmZZYTZtTGk1b2F5MVlUWlJM?=
 =?utf-8?B?citWSTUyU2tyNTJPT29Kb1hKcVhRaWhZMWY2Tkw2cUMyMjJmdnNFZnl6ZWla?=
 =?utf-8?B?aytmc1E3ZFFiYXlhb3JHVjkvVGo5RDFaSTFwZElYaUlITmh3LzAxeXMvMFFL?=
 =?utf-8?B?d0s4UFlEQXEreHZFVngzS1JGYzdnNlVUZHhXVCtTS1NBRk1oZ0RxRnBLTHhM?=
 =?utf-8?B?dUFRS0lCQUs4Wk5xRnJWUmRHamxNdVVBWnNxWmk3TVVWUlE0TzB1U1VRYXVm?=
 =?utf-8?B?U3pFZjdvUkxlYTRHWEtSVDMvN3BTNGswWHlweTl2eFp0YmdvRDI4NzZ2UVN4?=
 =?utf-8?B?Z1hpZG9oQ0JlVE1IVThQMm9NblNCQmxVNktrYWFGQmVZT0JyMDVWcDZtanps?=
 =?utf-8?B?WFQ5NklQUm1iM0V0L05YTkdxZ1Y3RFR4V2t6c0Z2RXMzdXZnMkJZUG5lT1Va?=
 =?utf-8?B?QjhzZnNIcHFNc2s4R2E0UDBFWEZnWkhGc0ljQmppeWtyQXR5T29GS2RNZ3VQ?=
 =?utf-8?B?OU9hQi9LRVlseDRqY1hSZzllYXduMmlYZ1k5bVNrOTBmb1RqMGpucFppMzM2?=
 =?utf-8?B?SzVQU3pnRytuUzRyVWVRejMxYzU5WHNqQ3hmUjlpZXlrL1lXeSszVjhGNU5i?=
 =?utf-8?B?VXliajczbERpeTl3WlBZZWppd0s2MDBtVVcySEQrUkt5bE9odkdrbmF6Mms3?=
 =?utf-8?B?SnZ3a0VoOW11NGMwcGJscUtoYjJleEdCQm5oQ2s3cjYrMG9KRnh0YmJPK1dM?=
 =?utf-8?B?cElHdVlNYXU4a1lMeFFJVmg0c1YzMlIzeGNOb0tlUUdGUS96VFA0bGNBdGVO?=
 =?utf-8?B?WUMyYldia2pOcklFT3BFNmdLc0k4S2o0dFl6ZXBLTGcxUW1CS2xRNlJlWTlN?=
 =?utf-8?B?aXRlTlFPcjFMa0ZVSkQrbGNvNkpQVm5mclYyYVdMUEVyN3hNZGsxUzNPUlZh?=
 =?utf-8?B?bnZCVEtuUDB1TGV6ck9LUW1veERMdjdpSGVpdkd6a2ZwL0tsM0duaVJ5Mks5?=
 =?utf-8?Q?nMGYawPZXUJsXZHET4mlcVjNF?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6d96a1ce-d04d-42ac-1469-08dbda2db0f5
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB7141.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2023 16:23:18.7008
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dElLkD2U7I1ldrJsQaKGQuscZ3m6Rv6QV9GoLadKRK4/KXEzEyi3JLfwCQJEUQ4i/dt0nUaeZ4Z0apx1gOVsAQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5228
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 31 Oct 2023 09:24:08 -0700 (PDT)


On 10/30/2023 9:55 PM, 'Guanjun' wrote:
> From: Guanjun <guanjun@linux.alibaba.com>
> 
> Fix incorrect descriptions for the GRPCFG register which has three
> sub-registers (GRPWQCFG, GRPENGCFG and GRPFLGCFG).
> No functional changes
> 
> Signed-off-by: Guanjun <guanjun@linux.alibaba.com>
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>
> ---

Acked-by: Lijun Pan <lijun.pan@intel.com>

>   drivers/dma/idxd/registers.h | 12 +++++++-----
>   1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/dma/idxd/registers.h b/drivers/dma/idxd/registers.h
> index 7b54a3939ea1..315c004f58e4 100644
> --- a/drivers/dma/idxd/registers.h
> +++ b/drivers/dma/idxd/registers.h
> @@ -440,12 +440,14 @@ union wqcfg {
>   /*
>    * This macro calculates the offset into the GRPCFG register
>    * idxd - struct idxd *
> - * n - wq id
> - * ofs - the index of the 32b dword for the config register
> + * n - group id
> + * ofs - the index of the 64b qword for the config register
>    *
> - * The WQCFG register block is divided into groups per each wq. The n index
> - * allows us to move to the register group that's for that particular wq.
> - * Each register is 32bits. The ofs gives us the number of register to access.
> + * The GRPCFG register block is divided into three sub-registers, which
> + * are GRPWQCFG, GRPENGCFG and GRPFLGCFG. The n index allows us to move
> + * to the register block that contains the three sub-registers.
> + * Each register block is 64bits. And the ofs gives us the offset
> + * within the GRPWQCFG register to access.
>    */
>   #define GRPWQCFG_OFFSET(idxd_dev, n, ofs) ((idxd_dev)->grpcfg_offset +\
>   					   (n) * GRPCFG_SIZE + sizeof(u64) * (ofs))