Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755095AbXKWAeX (ORCPT ); Thu, 22 Nov 2007 19:34:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751429AbXKWAeN (ORCPT ); Thu, 22 Nov 2007 19:34:13 -0500 Received: from ozlabs.org ([203.10.76.45]:48487 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751376AbXKWAeM (ORCPT ); Thu, 22 Nov 2007 19:34:12 -0500 From: Rusty Russell To: Andi Kleen Subject: Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro. Date: Fri, 23 Nov 2007 11:29:25 +1100 User-Agent: KMail/1.9.6 (enterprise 0.20070907.709405) Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, sam@ravnborg.org References: <20071122343.446909000@suse.de> <200711221456.22297.rusty@rustcorp.com.au> <200711221246.23994.ak@suse.de> In-Reply-To: <200711221246.23994.ak@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200711231129.25982.rusty@rustcorp.com.au> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1177 Lines: 25 On Thursday 22 November 2007 22:46:23 Andi Kleen wrote: > On Thursday 22 November 2007 04:56, Rusty Russell wrote: > > This is an interesting idea, thanks for the code! My only question > > is whether we can get most of this benefit by dropping the indirection of > > namespaces and have something like "EXPORT_SYMBOL_TO(sym, modname)"? It > > doesn't work so well for exporting to a group of modules, but that seems > > a reasonable line to draw anyway. > > That would explode quickly already even for my example "inet" namespace. > It already has several modules. I don't think so much duplication would be > a good idea. Yes, and if a symbol is already used by multiple modules, it's generically useful. And if so, why restrict it to in-tree modules? If your real intent is to bias against out-of-tree modules, let's just generate a list of in-tree module names, and restrict some or all exports to that set. Rusty. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/