Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
MIME-Version: 1.0
References: <20231030135411.776744-1-robh@kernel.org> <20231031034551.iiroxfz7qoz5r7yn@vireshk-i7>
In-Reply-To: <20231031034551.iiroxfz7qoz5r7yn@vireshk-i7>
From:   Rob Herring <robh@kernel.org>
Date:   Tue, 31 Oct 2023 11:34:12 -0500
Message-ID: <CAL_JsqJ=ceJpboLA+UjRVhSiN73RhVhh-zrUz8-Xv99LomCUjQ@mail.gmail.com>
Subject: Re: [RESEND PATCH] opp: ti: Use device_get_match_data()
To:     Viresh Kumar <viresh.kumar@linaro.org>
Cc:     Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
        Stephen Boyd <sboyd@kernel.org>, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Oct 30, 2023 at 10:45=E2=80=AFPM Viresh Kumar <viresh.kumar@linaro.=
org> wrote:
>
> Hmm, somehow I didn't receive the direct mail last time to my Linaro acco=
unt
> (alias of kernel.org). I do see the message being posted to LKML though.

That was an issue on my side.

>
> On 30-10-23, 08:54, Rob Herring wrote:
>
> Isn't it is compulsory to add some details in the commit log ?

Sigh, I missed adding it on this one. It should be:

Use preferred device_get_match_data() instead of of_match_device() to
get the driver match data. With this, adjust the includes to explicitly
include the correct headers.

As this driver only does DT based matching, of_match_device() will never
return NULL if we've gotten to probe(). Therefore, the NULL check and
error return for it can be dropped.

Will fix and repost.

Rob