Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <6cf7459aa0332d6fc3c4764f66a83c6a3825348f.camel@linux.intel.com>
Subject: Re: [PATCH drm-misc-next v7 4/7] drm/gpuvm: add an abstraction for
 a VM / BO combination
From:   Thomas =?ISO-8859-1?Q?Hellstr=F6m?= 
        <thomas.hellstrom@linux.intel.com>
To:     Danilo Krummrich <dakr@redhat.com>,
        Jani Nikula <jani.nikula@linux.intel.com>, airlied@gmail.com,
        daniel@ffwll.ch, matthew.brost@intel.com, sarah.walker@imgtec.com,
        donald.robson@imgtec.com, boris.brezillon@collabora.com,
        christian.koenig@amd.com, faith@gfxstrand.net
Cc:     nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org
Date:   Tue, 31 Oct 2023 17:50:41 +0100
In-Reply-To: <1e2acafb-fbc3-4256-b1e1-3fe6c47b1ef2@redhat.com>
References: <20231023201659.25332-1-dakr@redhat.com>
         <20231023201659.25332-5-dakr@redhat.com>
         <f00a4975cf32c3ae28124343a2c994acda083829.camel@linux.intel.com>
         <87zfzz3thp.fsf@intel.com>
         <1e2acafb-fbc3-4256-b1e1-3fe6c47b1ef2@redhat.com>
Organization: Intel Sweden AB, Registration Number: 556189-6027
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2023-10-31 at 17:30 +0100, Danilo Krummrich wrote:
> On 10/31/23 12:45, Jani Nikula wrote:
> > On Tue, 31 Oct 2023, Thomas Hellstr=C3=B6m
> > <thomas.hellstrom@linux.intel.com> wrote:
> > > On Mon, 2023-10-23 at 22:16 +0200, Danilo Krummrich wrote:
> > > > + * Returns: a pointer to the &drm_gpuvm_bo on success, NULL on
> > >=20
> > > Still needs s/Returns:/Return:/g
> >=20
> > FWIW, both work to accommodate the variance across the kernel,
> > although
> > I think only the latter is documented and recommended. It's also
> > the
> > most popular:
> >=20
> > =C2=A0=C2=A0 10577 Return
> > =C2=A0=C2=A0=C2=A0 3596 Returns
>=20
> I'd like to keep "Returns", since that's what GPUVM uses already
> everywhere else.

Ok. It looks like the Returns: are converted to Return in the rendered
output so I guess that's why it's the form that is documented.

I pointed this out since in the last review you replied you were going
to change it, and also when the code starts seeing updates from other,
it might become inconsistent if those patches follow the documented
way.

But I'm OK either way.

/Thomas


>=20
> > =C2=A0=C2=A0=C2=A0 1104 RETURN
> > =C2=A0=C2=A0=C2=A0=C2=A0 568 return
> > =C2=A0=C2=A0=C2=A0=C2=A0 367 returns
> > =C2=A0=C2=A0=C2=A0=C2=A0 352 RETURNS
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 1 RETURNs
> >=20
> > BR,
> > Jani.
> >=20
> >=20
>=20