Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Tue, 31 Oct 2023 18:31:25 +0100
Message-ID: <87lebiwvf6.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc:     James Schulman <james.schulman@cirrus.com>,
        David Rhodes <david.rhodes@cirrus.com>,
        Richard Fitzgerald <rf@opensource.cirrus.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Stefan Binding <sbinding@opensource.cirrus.com>,
        alsa-devel@alsa-project.org, patches@opensource.cirrus.com,
        linux-kernel@vger.kernel.org, dan.carpenter@linaro.org,
        kernel-janitors@vger.kernel.org, error27@gmail.com
Subject: Re: [PATCH next] ALSA: hda: cs35l41: Fix missing error code in cs35l41_smart_amp()
In-Reply-To: <20231030070836.3234385-1-harshit.m.mogalapalli@oracle.com>
References: <20231030070836.3234385-1-harshit.m.mogalapalli@oracle.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Mon, 30 Oct 2023 08:08:36 +0100,
Harshit Mogalapalli wrote:
> 
> When firmware status is invalid, assign -EINVAL to ret as ret is '0' at
> that point and returning success is incorrect when firmware status is
> invalid.
> 
> Fixes: a51d8ba03a4f ("ALSA: hda: cs35l41: Check CSPL state after loading firmware")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>

Thanks, applied now.


Takashi


> ---
> This is found using smatch and only compile tested.
> ---
>  sound/pci/hda/cs35l41_hda.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c
> index 496ff6a9d300..09f8d8fa4c71 100644
> --- a/sound/pci/hda/cs35l41_hda.c
> +++ b/sound/pci/hda/cs35l41_hda.c
> @@ -1042,6 +1042,7 @@ static int cs35l41_smart_amp(struct cs35l41_hda *cs35l41)
>  	default:
>  		dev_err(cs35l41->dev, "Firmware status is invalid: %u\n",
>  			fw_status);
> +		ret = -EINVAL;
>  		goto clean_dsp;
>  	}
>  
> -- 
> 2.39.3
>