Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Tue, 31 Oct 2023 10:46:02 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Thorsten Leemhuis <linux@leemhuis.info>,
        Randy Dunlap <rdunlap@infradead.org>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        "Linux Next Mailing List" <linux-next@vger.kernel.org>
CC:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
        Dan Williams <dan.j.williams@intel.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Jonathan Cameron <jonathan.cameron@huawei.com>,
        Davidlohr Bueso <dave@stgolabs.net>
Subject: Re: linux-next: Tree for Oct 30 [drivers/cxl/core/cxl_core.ko]
Message-ID: <65413d5ae720c_244c782942a@dwillia2-xfh.jf.intel.com.notmuch>
References: <20231030163344.5a39a625@canb.auug.org.au>
 <dc312544-6070-4299-b9ee-903b34d7cf21@infradead.org>
 <e3e9bcc3-e026-43d3-964c-5f5b51916782@leemhuis.info>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <e3e9bcc3-e026-43d3-964c-5f5b51916782@leemhuis.info>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?31gXISXVnFu9cOHbNCiXk3k8GYQkKdvhRPC2USZVcY6LyDfkV5EQvT1tFZxK?=
 =?us-ascii?Q?0IelxKy2YsmAZJd1QwjoL3/oNhbHSmn2Gb+6MmEFLIPli6L4PVhTrPoO7wQE?=
 =?us-ascii?Q?0EZctwNOjnaCYbbrrCIKqRILLtO0zChS7lKMrupXahGjI5hE7un9+hfECz5S?=
 =?us-ascii?Q?u4GFSD3jgBFp/hydctctZo8yb8wZBUIWhpqPr2A1LVlnB6pZPNZtFX7gOoAW?=
 =?us-ascii?Q?2lC3KV7pcidoCgl4cbuQpJO/oEfBhdpgFddmk5TobSfHEq1RQ1CT3vwSLlLN?=
 =?us-ascii?Q?gwfwADBylx3ZWnlGH8GvO8sO3sEr7q5uTdjlt3arbpMwH5aCL3wjuRF1eQ7e?=
 =?us-ascii?Q?CeWihK8/IDCMm2GQ4pIdJJzMFJY3iymgWeckxUv323ApNrDcr5Qk24b6CUfn?=
 =?us-ascii?Q?X9QvAPG4XcrVCSLmNhlhtQFX5XXKcF5OGvo7bYhW/v6K+nnWTdsGx08BOZmg?=
 =?us-ascii?Q?iBJq6iNePTEEeURy4dqZZWLoBr8V6xc9mInfb7RivDNPQGR2PSuVWZeV7GbP?=
 =?us-ascii?Q?tdGikrDqLpIO+UM/uZ9Lwhug23RZuerCYytIuaMDZSth9AXc3OEqKO46KSrx?=
 =?us-ascii?Q?p3dRKHvuoNb84Wc4xAiupt5CVp2RBmzhJJmWKSoqb79AsJCMqtug9M1kUeJq?=
 =?us-ascii?Q?CrYX68C0fixo/vF69pnWiWdOPPgXoLHd0Dsne15vh1URZz8fRjIfSF3HZZC4?=
 =?us-ascii?Q?5iWvh+DcFKfnJ1Zlw467y2VKzOjjUqGTGL9MZ1xfr2AXS7YiubIi7o0Q+FuK?=
 =?us-ascii?Q?tHSb1liprnAWNo1CWpFvPoBJCA8KYIUgjlNou9FMbHVO1CbxkL1rne4Y1leS?=
 =?us-ascii?Q?l3tBA7uzlMrC4J2GyU3BkC9HPhXJQD1epu/ZWuVmX6YEtsI9iKnKnCfVagHB?=
 =?us-ascii?Q?aIhV/GgSQ8VF+820n2Ccqx+pDQuXwuwxdTzRfh0Jt4NhGh/x5+7Az3w89wwo?=
 =?us-ascii?Q?7Y2Hb5vzoGqt27fdqs3/nBdGoTXjs9r5dqhNVYozp1P3Yi7nGU4esHXAZzYV?=
 =?us-ascii?Q?zZ7hs7LXbIJK3+gnfcj4kATvxmGD0LnvD3jAstEW5PTjyGeV2A5cvvDJaT3D?=
 =?us-ascii?Q?lODf92ecqPJxsXeEWoMA2cA+LNFjXheqqv8APo/uFdJELmF9LneRbRtnHfjC?=
 =?us-ascii?Q?q14v4DITOO4jaA6T4VZsEPOFKCPTRgv+d1Q2FgjG8PnlmTwxmUm9BkB2p91R?=
 =?us-ascii?Q?X9768gbgFE9mSF9Eflf2dw3n4Mo9olvyrpvOOvvNy9QaR88z9Rl9KiVJSyMl?=
 =?us-ascii?Q?iNmZToh6GoPDAoatxpjmKflClwp8ydYUhYBEMtAcdMmwBYsAIyHAUCY4eb61?=
 =?us-ascii?Q?M0NWM05wBzUol651Z6UF2LRAq4R1HeXxbX6xzsvzIIRsi2LOZF4CfSFaORsH?=
 =?us-ascii?Q?bsd4TKaHYXxIz2Mbl767R89yl2npbQvwIE5IIfIL15Wj37tKc41vm2twIDJo?=
 =?us-ascii?Q?M14SUeVWxnNNDC0Zjrra4JkwItHD7XfznenFMqiRp9VVwDiflitqBrhl73vF?=
 =?us-ascii?Q?0MU0tAdoO7m9AcVgUkmb7I+6jo3ANKgHIq+ACWln+PdsqIdzrzMJq18WY3Ke?=
 =?us-ascii?Q?9XdYng4wr/Mruir+dAYizmOeD3bYu3CsVdVoIItxYOrjbCCOWTIRwMZca1iN?=
 =?us-ascii?Q?2Q=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ae870514-3dcd-4872-11b4-08dbda3941b9
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2023 17:46:05.5310
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 13v5AMnM6cB6DF/sT/Gc+D72sCgtNy5vWHgNvGREDBr/TF5+zxueBtnjALlQymXbJWgObmp+/dJkxm+dUWLnu9efBbmaUpjRIjI1gkF3OHU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8162
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 31 Oct 2023 10:46:32 -0700 (PDT)

Thorsten Leemhuis wrote:
> [CCing the CXL maintainers]
> 
> On 31.10.23 06:04, Randy Dunlap wrote:
> > On 10/29/23 22:33, Stephen Rothwell wrote:
> >>
> >> Please do not add any material not destined to be merged before v6.7-rc1
> >> into your linux-next included branches until after v6.7-rc1 has been
> >> released.
> >>
> >> Changes since 20231027:
> > 
> > when CONFIG_ACPI is not set (on various ARCH):
> > 
> > ERROR: modpost: "pci_print_aer" [drivers/cxl/core/cxl_core.ko] undefined!
> > 
> > Already fixed?
> 
> Doesn't seem so, I saw that yesterday and today in my ppc64le builds for
> Fedora (based on the Fedora rawhide config). Build log, in case anyone
> cares:
> https://copr-be.cloud.fedoraproject.org/results/@kernel-vanilla/next/fedora-38-ppc64le/06583955-next-next-all/builder-live.log.gz
> 
> Seems 0day ran into this, too:
> 
> https://lore.kernel.org/all/202310281921.W9lzomPk-lkp@intel.com/
> https://lore.kernel.org/all/202310290131.Z10R00pk-lkp@intel.com/
> https://lore.kernel.org/all/202310302206.Pkr5eBDi-lkp@intel.com/
> https://lore.kernel.org/all/202310310457.5LusQqF6-lkp@intel.com/

Yes, apologies for the thrash. This fixes it for me. I will append this
to the cxl/next branch:

diff --git a/include/linux/aer.h b/include/linux/aer.h
index f6ea2f57d808..3db310c19ab7 100644
--- a/include/linux/aer.h
+++ b/include/linux/aer.h
@@ -43,16 +43,20 @@ struct aer_capability_regs {
 #if defined(CONFIG_PCIEAER)
 int pci_aer_clear_nonfatal_status(struct pci_dev *dev);
 int pcie_aer_is_native(struct pci_dev *dev);
+void pci_print_aer(struct pci_dev *dev, int aer_severity,
+                   struct aer_capability_regs *aer);
 #else
 static inline int pci_aer_clear_nonfatal_status(struct pci_dev *dev)
 {
        return -EINVAL;
 }
 static inline int pcie_aer_is_native(struct pci_dev *dev) { return 0; }
+static inline void pci_print_aer(struct pci_dev *dev, int aer_severity,
+                                struct aer_capability_regs *aer)
+{
+}
 #endif
 
-void pci_print_aer(struct pci_dev *dev, int aer_severity,
-                   struct aer_capability_regs *aer);
 int cper_severity_to_aer(int cper_severity);
 void aer_recover_queue(int domain, unsigned int bus, unsigned int devfn,
                       int severity, struct aer_capability_regs *aer_regs);