Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
MIME-Version: 1.0
References: <20231031144339.121453-1-sgarzare@redhat.com>
In-Reply-To: <20231031144339.121453-1-sgarzare@redhat.com>
From:   Eugenio Perez Martin <eperezma@redhat.com>
Date:   Tue, 31 Oct 2023 18:51:22 +0100
Message-ID: <CAJaqyWfr123zWdM8E+H4bnfrdvv-KEvZ7r5eN+fY428G6v95Hg@mail.gmail.com>
Subject: Re: [PATCH] vdpa_sim_blk: allocate the buffer zeroed
To:     Stefano Garzarella <sgarzare@redhat.com>
Cc:     virtualization@lists.linux-foundation.org,
        Jason Wang <jasowang@redhat.com>,
        Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        linux-kernel@vger.kernel.org, Qing Wang <qinwang@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Oct 31, 2023 at 3:44=E2=80=AFPM Stefano Garzarella <sgarzare@redhat=
.com> wrote:
>
> Deleting and recreating a device can lead to having the same
> content as the old device, so let's always allocate buffers
> completely zeroed out.
>
> Fixes: abebb16254b3 ("vdpa_sim_blk: support shared backend")
> Suggested-by: Qing Wang <qinwang@redhat.com>

Acked-by: Eugenio P=C3=A9rez <eperezma@redhat.com>

> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
> ---
>  drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c b/drivers/vdpa/vdpa_sim=
/vdpa_sim_blk.c
> index b3a3cb165795..b137f3679343 100644
> --- a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
> +++ b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
> @@ -437,7 +437,7 @@ static int vdpasim_blk_dev_add(struct vdpa_mgmt_dev *=
mdev, const char *name,
>         if (blk->shared_backend) {
>                 blk->buffer =3D shared_buffer;
>         } else {
> -               blk->buffer =3D kvmalloc(VDPASIM_BLK_CAPACITY << SECTOR_S=
HIFT,
> +               blk->buffer =3D kvzalloc(VDPASIM_BLK_CAPACITY << SECTOR_S=
HIFT,
>                                        GFP_KERNEL);
>                 if (!blk->buffer) {
>                         ret =3D -ENOMEM;
> @@ -495,7 +495,7 @@ static int __init vdpasim_blk_init(void)
>                 goto parent_err;
>
>         if (shared_backend) {
> -               shared_buffer =3D kvmalloc(VDPASIM_BLK_CAPACITY << SECTOR=
_SHIFT,
> +               shared_buffer =3D kvzalloc(VDPASIM_BLK_CAPACITY << SECTOR=
_SHIFT,
>                                          GFP_KERNEL);
>                 if (!shared_buffer) {
>                         ret =3D -ENOMEM;
> --
> 2.41.0
>