Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <988c1d61-ac0b-452c-9a99-04f59145598a@intel.com>
Date:   Tue, 31 Oct 2023 12:47:57 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net v3] net: stmmac: xgmac: Enable support for multiple
 Flexible PPS outputs
Content-Language: en-US
To:     Furong Xu <0x1207@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Joao Pinto <jpinto@synopsys.com>,
        Simon Horman <horms@kernel.org>,
        Serge Semin <fancer.lancer@gmail.com>
CC:     <netdev@vger.kernel.org>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <xfr@outlook.com>,
        <rock.xu@nio.com>
References: <20231031022729.2347871-1-0x1207@gmail.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20231031022729.2347871-1-0x1207@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R2pIK0d3SlhHOUt2OFhEU3lqVkVvZnUwcFZHeXBKdDZrSkhzVkF2emRMeGRN?=
 =?utf-8?B?OXRhc0JqZjlEbHNIajQrVDhQU3QyNUNYZmJjSjU5RkFmMTNaMDZoekVIZU43?=
 =?utf-8?B?MEEzYzFjVk9BT25NK1h2WWZEYXlMc1puMm1jTWN2Wi9wcEh5VmYyZW02ZWNv?=
 =?utf-8?B?NThqbkZjYk5yenVOQWRPTjE5RnJ3R24rY1JjYklqU3dBdlU4dE5UWEZnYm1s?=
 =?utf-8?B?czRXVVEvdmt3cTQvQjBnZXlhejZ6OHl5cTg5dzJENmovaHJ4VVBia3pSdVpz?=
 =?utf-8?B?RytMNU84ZzlaZ1QzaTlINmJoMGMvM3FMcXl6bkpyZVl2VUVQWGl0aFFWWEt4?=
 =?utf-8?B?SUQ3OHpJbEFMZ2QzVGlMZnpkemw3dDJwRkVtRGtTTzMyY3J1U2RBYmlJcDBU?=
 =?utf-8?B?Mk8rVTFiV2JCbTRySHgzd3NWTGZLZDY5VnlBNFdTR290UzFBUzVpa3ZGQUlQ?=
 =?utf-8?B?N0p1WmNzc0RPM0YrZk9SWlRQclc5Zi9uVDB3a1U1QjZCWlJPTmlTSEZGRWZx?=
 =?utf-8?B?YUxWanNYbnFsYlZvTlBvc2RiRzFmeGxYVm84dEJiOXhoYW0zYmZ2RlI4aHBY?=
 =?utf-8?B?VUcxWUJ4alBHK1BqWkNscU5MeG5FcEtqQ3NHODRNODJxU0o4b3Y0VkRhaGtT?=
 =?utf-8?B?b2Evcm1uU0p5MEJubXVlajlMb2VwU2JoSmVXWjhLQko2ekJWT0RoQzVSVWtY?=
 =?utf-8?B?MFZRMDA5YWlkMFRibllZcUJUeGtZdy9PZTlQWTgwUWx6NVV4ZldoNHJXTWNY?=
 =?utf-8?B?VVpBSW00QkMrbFBSdlhqMlM3ZGlGSTFUYU5hUDFCdmFFSHV5VjB4UThKdzVF?=
 =?utf-8?B?UVB1UjdpcjFWL3h3dG9nVTJyVjZaRVhlbHpTdVQ3NzA4ZnFGaFhHb1JPb3RQ?=
 =?utf-8?B?RFplK21RbGRwMzVrazl0Rlkrbi9ycXlFYjZLeFpIRWs5azNxT29naTBubVRY?=
 =?utf-8?B?dE9BeWtCbVNrNDFQVFRmVXkwUi9heEVUTk9NMHQ0YnltZ3VLK0U2Nmw4R2VH?=
 =?utf-8?B?aUhrT2ZhK29lWkJqSytZZlBmdmJUREttVWNMdkJRVHIxaEx6WU93TTVVWFlt?=
 =?utf-8?B?RlF2aVBvU3hKb3c3QVNzbkFSMkxlZzJHcU9lS3M2ai9XVjFSdXJaemcva0xV?=
 =?utf-8?B?V0dnVUxuZjJ1bFVNdGsvc3drWjBTWGRvQXpNMUEwdUFrV0ZXS2s1K3FINlJp?=
 =?utf-8?B?UG5RQTNOaytnTDF4UGpSb05xdStHeHpRaXh4VXdoSC8rWnVtaUQzRll1d0FZ?=
 =?utf-8?B?L1FraWcveGNyLzlZSXZ1SlU3R2FOMDFPdkZZU2NPMFRNUjZPM3ZFVWt5R2tF?=
 =?utf-8?B?YTNPVFpsTFR5cmU2Und6Yi9nTlh3OWl0NDhwME5sTDdLYU9YR2ZBaWdUUWpC?=
 =?utf-8?B?Yk9ndkJBU0piSk0va2hKWVBXaVpvRzhGd1Y4dWNSSDBEUUNQRkdMbm1JVjd6?=
 =?utf-8?B?MnJmdnJtTkdQYUZOdVhGNEorR0xaT0RWNzNidWJ1M2hEM3RhV09jeTFwQWlJ?=
 =?utf-8?B?N0hSVHlYWlJzbmV5ZkI1VFhiUTJocno0VldPenluajAvaHpLd1lUK0ZEcGNp?=
 =?utf-8?B?cjRmcWgxUWc2ejRPM0ZFT2VXTVNBNHhTcTFxZXRWOFpUNDhwOGtnaGN4OC8w?=
 =?utf-8?B?eUQvWG43ZUJiUDB1a2VRSWpNbDJtb2tvdFNZbzNpeUFtTUhmT0xvYW52ZjJw?=
 =?utf-8?B?Qm5mV0swYTdzd1FvMitRbXpWY3NUZTNNR0ErTVl5RU1RS3d5V1VjTkE4YVlR?=
 =?utf-8?B?WUxpM1ZKT29yTzRzYXIvNkhzbTQ4VEMrU0NQQSsxdk1LcDJLZFpCUE1kR3Bz?=
 =?utf-8?B?b25pQVd6Y1E1d3pJZFpCemJmOWdjbzN5WnRoQXN4WHZ1TDgvWWw4TTlzVERH?=
 =?utf-8?B?cGh5SVRKbytXMUNRZlNieEhzbTQwYzFrM3pBNXlQNm40KzBVeFR6RkNVZHI2?=
 =?utf-8?B?Mk1NaDZHeUl0b3Zmb0xsaHByNG92cnVXb1V0cGpleGFlS2JSWVNJNHBRTHhG?=
 =?utf-8?B?MmRMd3RpcTEvbXp5UnFTNTZUS0lYY1lKYklpMzZaZFFxQzRLMjRNdWpMSlpO?=
 =?utf-8?B?dm8yRyt4QmNrTTh0dVJZMVhIbHVtOXV0V2drcVRQaHlGeG1YaFVrNlkzWVpL?=
 =?utf-8?B?aXJlQWZEV3Rmc3NnR2VQVExtdnRJUVBIcjcvZlZIRjU0OGVDVkdaTzYrREdl?=
 =?utf-8?B?UXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 97eea8b8-f817-4f5d-31b8-08dbda4a489b
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2023 19:47:58.4594
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0aLu8GrrpMZ3GjNSGmhWM1bd0Ya1OI89nB48BjxMcwSIZ1YuHzl4k1F3WCStpgA7ItUzCf+BPGlMtmC1+ix8bFHn20fhXF3JFjqzoiVsDZk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7639
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 31 Oct 2023 12:48:14 -0700 (PDT)


On 10/30/2023 7:27 PM, Furong Xu wrote:
> From XGMAC Core 3.20 and later, each Flexible PPS has individual PPSEN bit
> to select Fixed mode or Flexible mode. The PPSEN must be set, or it stays
> in Fixed PPS mode by default.
> XGMAC Core prior 3.20, only PPSEN0(bit 4) is writable. PPSEN{1,2,3} are
> read-only reserved, and they are already in Flexible mode by default, our
> new code always set PPSEN{1,2,3} do not make things worse ;-)
> 
> Fixes: 95eaf3cd0a90 ("net: stmmac: dwxgmac: Add Flexible PPS support")
> Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> Signed-off-by: Furong Xu <0x1207@gmail.com>
> ---
> Changes in v3:
>   - Tagged Fixes: and sent through net instead of net-next, thanks Jacob Keller.
> 

Thanks!

-Jake