Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Feedback-ID: i68a1478a:Fastmail
Date:   Tue, 31 Oct 2023 21:27:08 -0500
From:   Patrick Williams <patrick@stwcx.xyz>
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>,
        Jean Delvare <jdelvare@suse.com>, linux-hwmon@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] hwmon: emc1403: Add support for EMC1442
Message-ID: <ZUG3fOnw8RE7JHsh@heinlein.vulture-banana.ts.net>
References: <20231031085807.618827-1-Delphine_CC_Chiu@wiwynn.com>
 <7d92d8ae-c247-4a71-a84d-4f9639a43fb8@roeck-us.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="1WgzJp/BygG6uQK0"
Content-Disposition: inline
In-Reply-To: <7d92d8ae-c247-4a71-a84d-4f9639a43fb8@roeck-us.net>
Precedence: bulk


--1WgzJp/BygG6uQK0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Oct 31, 2023 at 04:01:10PM -0700, Guenter Roeck wrote:
> On Tue, Oct 31, 2023 at 04:58:06PM +0800, Delphine CC Chiu wrote:
> > Add support for EMC1442 which is compatible with EMC1403.
> >=20
>=20
> Unfortunately, almost no information is available about this chip
> except that it ships in an 8-pin package. Are you sure the chip
> supports two external temperature sensors like EMC1403 ?
> The chip numbering and the number of pins would suggest that
> it only supports a single external temperature sensor,
> which would make it compatible to emc1402/emc1422.
>=20
> Guenter

The datasheet I've seen says:

>> The EMC1442 monitors two temperature channels (one
>> external and one internal).

Based on this, I agree that emc1403 seems wrong.  The datasheet also
says:

>> Pin compatible with EMC1412

>=20
> > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
> > ---
> >  	{ "emc1422", emc1402 },
> >  	{ "emc1423", emc1403 },
> >  	{ "emc1424", emc1404 },
> > +	{ "emc1442", emc1403 },

So, emc1402?

> >  	{ }

--=20
Patrick Williams

--1WgzJp/BygG6uQK0
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEBGD9ii4LE9cNbqJBqwNHzC0AwRkFAmVBt3kACgkQqwNHzC0A
wRk+jw//VVmJXshZwt3N+ypEYxo6K6shKaloSoiCAbe+07PIgfmI8kfqWjqPfeYf
fZZ80rh7NgtX1qrKXVtFxZgRI3wgpKxDYXqlzkUcGRVdrlMtKg/c7kHXUMgHzGoO
infqGsQbodYk13nxIEKwD1Wl1d6c+nP1yIESK+PKsNFthctucFNgTNpPJS/EgEdv
g03fucNe6uU2tt2nxb5UHqgLJidRCzSRdQiKdnTmcpEbKjwtHHS4CKmXQcxmj0pg
Z9zbzm2uZgyKGPgUxpRUS5T1HEF82ut4hSzRYkAD7Cc4dCiUohJMdjKnz5mm6ua4
c9Gq1SKpImk7uNLMaDkZYJITdNvb+Cg3T4QtGtNfasBgKLO731nfXo4fZMRgYmaw
Lyyr/gEuXw+2iFXin47tl4Ig32yy3r9rcoDyfjMcWsWQn5RVi0Tb4b6jVpfHxulK
qPbKHQcTyB5al+fyG1FpjDetAfJDGcBqZcPwalwCYilQFrbUa9NEB3hS4+y+vssX
NI8c5mz5/knsXF1QOVOPID+Suh+zu1EGTdBMrnZdfAlu/bvfHNcOPEU8zBSbtGCy
OVSXsO3PHiXwehg9pmImfwJ7Fwlnvd4ZaoeKH+NWfG6/Xx8qbWe1qLJqoIt3DV1D
ffRCDGH5ffLWzw/2Le2779CHyyS8HaodHi/CmdxRcGyCDR5bKE8=
=okqw
-----END PGP SIGNATURE-----

--1WgzJp/BygG6uQK0--