Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Sender: Guenter Roeck <groeck7@gmail.com>
Date:   Tue, 31 Oct 2023 21:03:20 -0700
From:   Guenter Roeck <linux@roeck-us.net>
To:     Kees Cook <keescook@chromium.org>
Cc:     Mark Rutland <mark.rutland@arm.com>,
        Li zeming <zeming@nfschina.com>, gor@linux.ibm.com,
        hca@linux.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] stackleak: Remove unnecessary '0' values from ret
Message-ID: <fe84bc23-03a3-4783-86c7-bd2323269b8b@roeck-us.net>
References: <20231017060824.10434-1-zeming@nfschina.com>
 <ZS5ek5RrW3XaBph9@FVFF77S0Q05N>
 <202310181704.F1089D5B@keescook>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202310181704.F1089D5B@keescook>
Precedence: bulk

On Wed, Oct 18, 2023 at 05:39:21PM -0700, Kees Cook wrote:
> On Tue, Oct 17, 2023 at 11:14:43AM +0100, Mark Rutland wrote:
> > On Tue, Oct 17, 2023 at 02:08:24PM +0800, Li zeming wrote:
> > > ret is assigned first, so it does not need to initialize the assignment.
> > > 
> > > Signed-off-by: Li zeming <zeming@nfschina.com>
> > 
> > Does this actually need to change? It's not harmful, and deleting the
> > assignment doesn't save any lines of code.
> 
> I prefer explicit initialization. Any unused initialization will be
> optimized away by the compiler during Dead Store Elimination, so all
> removing the initialization does is make the code more fragile in the
> future.
> 

Also, be careful with those submissions, and do not take the claim
in the commit message at face value. Several of them introduce
uninitialize variable errors. I had two submissions for the watchdog
subsystem, and both of them were wrong.

Guenter