Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
From:   Wu Bo <bo.wu@vivo.com>
To:     linux-kernel@vger.kernel.org
Cc:     Alasdair Kergon <agk@redhat.com>,
        Mike Snitzer <snitzer@kernel.org>, dm-devel@lists.linux.dev,
        Wu Bo <wubo.oduw@gmail.com>, Wu Bo <bo.wu@vivo.com>
Subject: [PATCH 1/1] dm verity: don't verity if readahead failed
Date:   Tue, 31 Oct 2023 22:26:10 -0600
Message-Id: <20231101042610.606136-1-bo.wu@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PzYBzm+JNiYZqowyWLEkIbeL4BFai12I2ezfcTEgDMlceN6p4QjBNRmMbq5f?=
 =?us-ascii?Q?J8bjH+t+EDeumpJAc9oujzstATr5qEnyF3d4D3ELVSdPUPWjZLMcZ9SVS6KV?=
 =?us-ascii?Q?SbAkUvTAzVx0se/AJBXcajwWGI0v17UUK47m/z4m0/vUSY7ptD/KWWlqmcjM?=
 =?us-ascii?Q?HlaNsfBzl6trHgcG+30aML5iCSv9oD/Y+Q6ItDM6trzwGLmg3UBbFke+nMn9?=
 =?us-ascii?Q?DWaCK6fxqcJW0EPaN3PNWjnqnRC14WZsRojTcmB5IU/ytSMzWVjhX8Ez8Mb4?=
 =?us-ascii?Q?M4+GXbefRA60mUSx7pMk3V/oZO8CvxVSs40RoEcGQOmROfsuLiooDBkH0eEx?=
 =?us-ascii?Q?uaAHSeYgsQXXUYC1At2PecQJdR/q5Ex5mOHRNMej+cQYxDy5mYhfdk5k4N1M?=
 =?us-ascii?Q?/zvLCCO5/R2XkhsXGhKskKyLm9W6YBr+faUgi5cZXyBtujfV3n3AvLeVsSaL?=
 =?us-ascii?Q?MbEwMbYQw3im7tHgZIzPIQolDgBU28C+fNVJYV2op939XvgPElfNwqIUgpgc?=
 =?us-ascii?Q?b9zX1KCuDXtnxdBpPOYuC3dKxzR2CKyDHejOoHg2ugR5oWlM7fYDrSmqBR0n?=
 =?us-ascii?Q?xpWUFPrYzvmIrPZ07ObdNIoPD12Itv2jgOCvB7oU1OJVBkyRCtE73i4RX3DT?=
 =?us-ascii?Q?Tj5ZC4EF2RZE9liaVNtplSx/OcN+HNcVIc4O4SzWlEfcVJB71SspMfwXvlty?=
 =?us-ascii?Q?MOiD/zDfhH90tCHlXteszAQL64dn4jedvg5HSIKDT9rbh7MYPbY/9aCV8J9T?=
 =?us-ascii?Q?BrpW5olnsHDFi/UosNFQJmlk4nGT5V1Hjrrku1sHm82KFxUvjXkE1AzT9KqG?=
 =?us-ascii?Q?DmlE+yQlMz7Wx3SYWDZVJv+fV2T2ue0t/A0XMsOnxuR0TDKFPiBVgpxTpoov?=
 =?us-ascii?Q?kCA9J82vOECTr2CbzTelT3E3yQm2bjiLUo/yQWfmqJoV4QPVT+TDWCCGH+zg?=
 =?us-ascii?Q?LvJoEkItpRz2+FFzGXxNiEwmiUw0/odl3gOX+7YHtLF+di9aIaDIzW60KdCf?=
 =?us-ascii?Q?Vc2KRgMWE0IzYMgw8jZTrAZpNvJMA3biAel4aMYuJKS7d8exqHN/BJRzr9L/?=
 =?us-ascii?Q?6iHyRyKLa/EM6X3J4d8kC8JJPTjZtMypCZOxmxfMW/15B4ZUlJjPtKB/Xlxt?=
 =?us-ascii?Q?YL3rBkxxHJEx+HosAwR2bQ3NEHwkBvJwgyyH+HIQI427+vKCloAo5UqIE4Tl?=
 =?us-ascii?Q?CIa/Ypgh1ja6fiNtIq0c+nJhx4X/wtmZT0fE4ZyBNn6lum3WHibWCrMVsDS+?=
 =?us-ascii?Q?K0u6BKH0XPTvRWyjUpEmUnu3jbgSvjmjtjv4cG1Wj9saOCVWDdTSQjrd0XAK?=
 =?us-ascii?Q?Nlw5t4TxBYr4WbJ4UycsrmzOajbIZIvYfufLyF6QZBYA5cmCQVt1Mq43YDQu?=
 =?us-ascii?Q?F9u68rcJkMDl524NoZyXSzzoa5tyB4hOyR3ej9WT20Ev/z07u0kEnWI6YutF?=
 =?us-ascii?Q?iVOY/bLFYnoHEx8kGQXONfjVj0ycfDUwQQncfQ9mIodF2EOhptYx67EoP4un?=
 =?us-ascii?Q?WD9jhe9Bt8weEk/8yoje3K2fmiDqlAGrGvSsRh0lrxTTXF/4TPlbIkqNTYMw?=
 =?us-ascii?Q?W/Z74CS+uALn71X5qjOSyzRRk0lrLnruHfZlIWDQ?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2de90c4a-5df9-42cd-4307-08dbda9175d8
X-MS-Exchange-CrossTenant-AuthSource: TY2PR06MB3520.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2023 04:17:28.8305
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mSWgYGTB1VNuWhGeSnUM42/YjBfOFg5GK5/RpfdapoAD9sm46AtJETd/23qycsZrasc9N0f9xeyidtBx0yTcug==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY0PR06MB5594
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 31 Oct 2023 21:17:50 -0700 (PDT)

If the IO is marked as readahead. When it is failed, it would better
to pass it to upper layer to handle it.

Consender the following situation:
dm-verity is built over a dm device.
'dm_submit_bio()' will return IO error when dm device is suspended.
And IO get nothing, but it will goto FEC, and trigger more IO on the
suspended device. It's a vicious circle.

Signed-off-by: Wu Bo <bo.wu@vivo.com>
---
 drivers/md/dm-verity-target.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/md/dm-verity-target.c b/drivers/md/dm-verity-target.c
index 26adcfea0302..253e65b4160e 100644
--- a/drivers/md/dm-verity-target.c
+++ b/drivers/md/dm-verity-target.c
@@ -667,7 +667,9 @@ static void verity_end_io(struct bio *bio)
 	struct dm_verity_io *io = bio->bi_private;
 
 	if (bio->bi_status &&
-	    (!verity_fec_is_enabled(io->v) || verity_is_system_shutting_down())) {
+	    (!verity_fec_is_enabled(io->v) ||
+	     verity_is_system_shutting_down() ||
+	     (bio->bi_opf & REQ_RAHEAD))) {
 		verity_finish_io(io, bio->bi_status);
 		return;
 	}
-- 
2.25.1