Received: by 2002:a05:7412:f589:b0:e2:908c:2ebd with SMTP id eh9csp726132rdb; Wed, 1 Nov 2023 00:04:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGSfcQ9U9DWmZRDmtLMZFaLIcCJ5GYOSye/lo65ZVty9uXJj6H+57PxNQEVvyaivkJZ+XTO X-Received: by 2002:a05:6870:d88f:b0:1e9:f9e5:d353 with SMTP id oe15-20020a056870d88f00b001e9f9e5d353mr18758073oac.12.1698822295059; Wed, 01 Nov 2023 00:04:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698822295; cv=none; d=google.com; s=arc-20160816; b=cnwzoedrVs0az0MeCyY4LWmJLCotgI04qxg25uaQnmtviY3ZEJgDGfqzuqyMW1KHNd /r6fFs232WjgqQKCn9ciRoD4NPePX0eDOYrJJrUqgRn3Qp37rAdhIzj2KMT4RaXWV36n 9qNHdoKjfBHY3aTc3FQpXZD8XYbYpQ+bU5vXh0edMypawHOitBqbqd9EHEM0fJtMaeGT msh1gPcEuRqYmSBzz6XdLk2qFOsvfnNF7lkFp+wEfxJfQuLecXRYbV0bsw5elRfA/K4c wo+H7X4zSv85gJM5Mf/8mcvP9KZvmw4VJPHuPWHZyHOQsphiLtUbhk3aonNAicPx1/Hw fu2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from; bh=GS1noib5OU0tB0D7uL5u0Ycz6U9SCgs/Jnjv2F+Cl2Q=; fh=HHCL3E2CBgX9o0KpipNmKjQfzCZGwhklQJbm7oMzI+c=; b=b8lbHtjsDEBkqBJbBqPbFw8z/HBin+IB0mljNwlCU5Vv3hHSX6sZtUUj5Iw/WLAzSI pqCplgar9WPVyWLoFldQ2PNx3ZF3eSxvOTDqqwWyvEy1gCcuDW57xZZy4Wf4e8vRGb8H Koe9OanRRxhlyqE/ZFcKszVC0H44CBncznuV3xZ/CvIPOsVwf0GO/dysUZr425aDdzvv yxx+LYVWeIsftGqt0f1BVL9Of7m79seh9qy450j0yOr3K+4qfYQmOuPFtYYHz72sByTg RZbl+BHMTnIYIPW8+vLrdX43Ffo7ITf3mMZfG6rgD+onl6DRObtnbvYF9smfxIEJPdOc V3pw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id a16-20020a63e410000000b005b55df27b44si2434143pgi.340.2023.11.01.00.04.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Nov 2023 00:04:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 215C980FA9C8; Wed, 1 Nov 2023 00:04:54 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229573AbjKAHEr (ORCPT + 99 others); Wed, 1 Nov 2023 03:04:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbjKAHEq (ORCPT ); Wed, 1 Nov 2023 03:04:46 -0400 Received: from out28-49.mail.aliyun.com (out28-49.mail.aliyun.com [115.124.28.49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FCD9E4; Wed, 1 Nov 2023 00:04:41 -0700 (PDT) X-Alimail-AntiSpam: AC=CONTINUE;BC=0.1066366|-1;CH=green;DM=|CONTINUE|false|;DS=CONTINUE|ham_system_inform|0.00441527-0.000454537-0.99513;FP=0|0|0|0|0|-1|-1|-1;HT=ay29a033018047188;MF=wangweidong.a@awinic.com;NM=1;PH=DS;RN=8;RT=8;SR=0;TI=SMTPD_---.VCY3.ex_1698822275; Received: from ubuntu-VirtualBox..(mailfrom:wangweidong.a@awinic.com fp:SMTPD_---.VCY3.ex_1698822275) by smtp.aliyun-inc.com; Wed, 01 Nov 2023 15:04:37 +0800 From: wangweidong.a@awinic.com To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, wangweidong.a@awinic.com, nathan@kernel.org, inux-sound@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] ASoC: codecs: Modify the wrong judgment of re value Date: Wed, 1 Nov 2023 15:04:12 +0800 Message-ID: <20231101070413.162708-2-wangweidong.a@awinic.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231101070413.162708-1-wangweidong.a@awinic.com> References: <20231101070413.162708-1-wangweidong.a@awinic.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 01 Nov 2023 00:04:54 -0700 (PDT) From: Weidong Wang An error code should be return when the re is greater than the maximum value or less than the minimum value Signed-off-by: Weidong Wang --- sound/soc/codecs/aw88399.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/aw88399.c b/sound/soc/codecs/aw88399.c index 47fe38d0def5..936d7d3767f3 100644 --- a/sound/soc/codecs/aw88399.c +++ b/sound/soc/codecs/aw88399.c @@ -486,8 +486,8 @@ static int aw_dev_update_cali_re(struct aw_cali_desc *cali_desc) u32 cali_re; int ret; - if ((aw_dev->cali_desc.cali_re <= AW88399_CALI_RE_MAX) || - (aw_dev->cali_desc.cali_re >= AW88399_CALI_RE_MIN)) + if ((aw_dev->cali_desc.cali_re >= AW88399_CALI_RE_MAX) || + (aw_dev->cali_desc.cali_re <= AW88399_CALI_RE_MIN)) return -EINVAL; cali_re = AW88399_SHOW_RE_TO_DSP_RE((aw_dev->cali_desc.cali_re + -- 2.41.0