Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Wed, 1 Nov 2023 10:30:02 +0300
From:   Dan Carpenter <dan.carpenter@linaro.org>
To:     Syed Saba Kareem <Syed.SabaKareem@amd.com>
Cc:     broonie@kernel.org, alsa-devel@alsa-project.org,
        Vijendar.Mukunda@amd.com, Basavaraj.Hiregoudar@amd.com,
        Sunil-kumar.Dommati@amd.com, mario.limonciello@amd.com,
        venkataprasad.potturu@amd.com, arungopal.kondaveeti@amd.com,
        mastan.katragadda@amd.com, juan.martinez@amd.com,
        amadeuszx.slawinski@linux.intel.com,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] ASoC: amd: acp: fix for i2s mode register field
 update
Message-ID: <8b61e318-7734-4bcf-ae17-59128058e5b7@kadam.mountain>
References: <20231031135949.1064581-1-Syed.SabaKareem@amd.com>
 <20231031135949.1064581-3-Syed.SabaKareem@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231031135949.1064581-3-Syed.SabaKareem@amd.com>
Precedence: bulk

On Tue, Oct 31, 2023 at 07:29:34PM +0530, Syed Saba Kareem wrote:
> I2S mode register field will be set to 1 when tdm mode is enabled.
> Update the I2S mode field based on tdm_mode flag check.
> 
> This will fix below smatch checker warning.
> 
> sound/soc/amd/acp/acp-i2s.c:59 acp_set_i2s_clk()
> 	warn: odd binop '0x0 & 0x2'
> 
> Fixes: 40f74d5f09d7 ("ASoC: amd: acp: refactor acp i2s clock
> 	generation code")

I saw this yesterday but didn't comment because I didn't want you to
have to redo the patch.  Mark, of course, also saw it and didn't ask you
to redo it.  And now it's applied.

But for the future, these Fixes tags should be on one line and in the
tags section of the commit message.  (It's in chronological order).

Fixes: 40f74d5f09d7 ("ASoC: amd: acp: refactor acp i2s clock generation code")
Reported-By: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Syed Saba Kareem <Syed.SabaKareem@amd.com>
Signed-off-by: Mark Brown

regards,
dan carpenter