Received: by 2002:a05:7412:f589:b0:e2:908c:2ebd with SMTP id eh9csp769811rdb; Wed, 1 Nov 2023 02:02:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHQ+aU4IaStdmFgAcqWQmLkfVEYmZyErYpoQ+XCsN3ku/UJqgF0zWp6EzkPzInmF23ouRw1 X-Received: by 2002:a17:902:6b07:b0:1ca:8b74:17ff with SMTP id o7-20020a1709026b0700b001ca8b7417ffmr15190569plk.26.1698829365828; Wed, 01 Nov 2023 02:02:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698829365; cv=none; d=google.com; s=arc-20160816; b=kfW17FhuGjQnWB9GJv6bH395RXKqwGLQDmRxszicQdOyI3eHmzZaziMO1nRBjoovRd dS4jVdexBzvgRUyV0UGi23w9I6whGmIKuv3s85tNIYypR/e6Me3jECqNyMSqQqPa5Qau gfC2xaTKerjhZBUp8KMpvBWegklG9kEqQdoU8kC2NT9k5qoQ8BQNJFWo+EfOsG58jSQ+ NE4AJIjNL4g8vm1jnNirpkYV0OokITctn9GfNxydU8/Ff9AOKZG4rw9PUyrm/7qDirRg gcllE3LcuxrtctIFEhl0Mx01n/vcfMpeqdt9FjeQAAr3eQzs5MdW8h0LOEWmZ/CkeuT5 O9FQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from; bh=IgYzuh9w+cWp3niU7Ip8v8YS3iKooHOSQhNY7IqOd04=; fh=zPlwH+wkmYMn3P2tacn/gCIH2uyRgYUaqJI/QOP+5Io=; b=JTQGuYUa1GBVQu2ZIGou9J77sV6pmLwzkcVJBCIT2lW/C4lf1RDj2SkWPfxT5s/Qcv QcvMM4exyK+U3AnnyUdpbt2x2Oonf7YmIIVmWaNOAxNVCJjFwUd/D13Ejh8ihSD/aPqb VNV+dSTCNbo9tkrGs93KJcb7O8hK+zlBAEGzhVIoUiE6ZZB8d1199sNDx3l+S/SSVDxM mgVdqSs1CBxyZ2edxtZ0wbkJLlvWWpemgRxsHete/OL9/z1mA180vMLdgTyzxcSD4Llc RQFaC2JYeCv7oV5OPe/zRog9IS5uR22KK/7XaBcjuVf2ojw+cyZHtIHUj23tsqAXv9Zu Jm3Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id q9-20020a170902f34900b001b895572179si2440130ple.184.2023.11.01.02.02.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Nov 2023 02:02:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 626668028D70; Wed, 1 Nov 2023 02:02:42 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234413AbjKAJCh (ORCPT + 99 others); Wed, 1 Nov 2023 05:02:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234424AbjKAJCe (ORCPT ); Wed, 1 Nov 2023 05:02:34 -0400 Received: from out28-4.mail.aliyun.com (out28-4.mail.aliyun.com [115.124.28.4]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0C88F7; Wed, 1 Nov 2023 02:02:30 -0700 (PDT) X-Alimail-AntiSpam: AC=CONTINUE;BC=0.1092362|-1;CH=green;DM=|CONTINUE|false|;DS=CONTINUE|ham_system_inform|0.00441527-0.000454537-0.99513;FP=0|0|0|0|0|-1|-1|-1;HT=ay29a033018047206;MF=wangweidong.a@awinic.com;NM=1;PH=DS;RN=11;RT=11;SR=0;TI=SMTPD_---.VCeegrp_1698829343; Received: from ubuntu-VirtualBox..(mailfrom:wangweidong.a@awinic.com fp:SMTPD_---.VCeegrp_1698829343) by smtp.aliyun-inc.com; Wed, 01 Nov 2023 17:02:26 +0800 From: wangweidong.a@awinic.com To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, wangweidong.a@awinic.com, liweilei@awinic.com, u.kleine-koenig@pengutronix.de, yang.lee@linux.alibaba.com, nathan@kernel.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH V2 2/3] ASoC: codecs: Modify the wrong judgment of re value Date: Wed, 1 Nov 2023 17:02:09 +0800 Message-ID: <20231101090211.177125-3-wangweidong.a@awinic.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231101090211.177125-1-wangweidong.a@awinic.com> References: <20231101090211.177125-1-wangweidong.a@awinic.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 01 Nov 2023 02:02:42 -0700 (PDT) From: Weidong Wang An error code should be return when the re is greater than the maximum value or less than the minimum value Signed-off-by: Weidong Wang --- sound/soc/codecs/aw88399.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/aw88399.c b/sound/soc/codecs/aw88399.c index 1d6228cb1cc2..54f8457e8497 100644 --- a/sound/soc/codecs/aw88399.c +++ b/sound/soc/codecs/aw88399.c @@ -486,8 +486,8 @@ static int aw_dev_update_cali_re(struct aw_cali_desc *cali_desc) u32 cali_re; int ret; - if ((aw_dev->cali_desc.cali_re <= AW88399_CALI_RE_MAX) || - (aw_dev->cali_desc.cali_re >= AW88399_CALI_RE_MIN)) + if ((aw_dev->cali_desc.cali_re >= AW88399_CALI_RE_MAX) || + (aw_dev->cali_desc.cali_re <= AW88399_CALI_RE_MIN)) return -EINVAL; cali_re = AW88399_SHOW_RE_TO_DSP_RE((aw_dev->cali_desc.cali_re + -- 2.41.0