Received: by 2002:a05:7412:f589:b0:e2:908c:2ebd with SMTP id eh9csp786078rdb; Wed, 1 Nov 2023 02:42:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGjsLB8iB8M99oRF7BR7Kh8QkOQHxj/U+pPcCIM+gFzr3b292HGT5m7VepeSkAdcVDhUJ6N X-Received: by 2002:a05:6808:219a:b0:3a7:550c:635d with SMTP id be26-20020a056808219a00b003a7550c635dmr15295512oib.56.1698831744830; Wed, 01 Nov 2023 02:42:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698831744; cv=none; d=google.com; s=arc-20160816; b=AktiK71j/mjBHeUa30UcMeE5YEvr6AjaaRYSJ8+/miZtIOqxMlMmYqUrxxy6bsJVMK GJWoBCP3taZS/Pfj1nroBhLDhR/+00fARVe6Tftf/w8nSiEtQvF2einlwVPuHELxEjzU SzRDAx+zBWIo4nPpHoBHPL6fZvgzGlpLMyD/NgTBVMiLnfs8QwRrs0e/rULo6yEYaFf3 NT2z0zc0U9jWBhjsPocKcoX/aZwEesfajk5xPy2QzXq1VqFDn5yXXuYJzKJcRbMMjJTQ ucxxAEpzM5BM2bnSDCSpPR4R2voxuTeanPWP3J1u08ENjeklOaEH/kovrSFgNhRUst12 fu7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=gNzKW+x1c0UZzbPukaEOwSLPVJ3mDtKgT9KmOp+APUs=; fh=Hz527dI7KAmVlzIVo7AFeCzPLI5tIWwRB0zQcknP7sY=; b=RVtaeWaUVkHKAqnIiM1j1kSDeV3/I0vowFuw8E0u/P+EzW5nrlHrHPXunctw2L+zQl zIplOD9UCpWpseXDPIiYjP5+5OKq5mEOCpnc1gQ1kghoM7YT5EjEvvhkI8VZBkdKESM+ oapqKOZRjWj3s6YaxR5PHBc/NOENcs3yFlDJN2ewMUy6fUI1OSPtaTS5+9GroIVV4uAr oWW1TBFv7NaBKIlWbEOHAeL/F2rJIs9uZJnKa3AWwvHUuPNfekZYHYOpoi15PVJMporu Wvu7jXEIOKlTbfLbICTxzvqCfNzB15+SPMK4gbv+hE345/ALkPapttGnWUEkPr/sXq+J DtaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=mATHxiyl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id s12-20020a65644c000000b005b90e67f441si2558798pgv.34.2023.11.01.02.42.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Nov 2023 02:42:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=mATHxiyl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id B863E8083DF0; Wed, 1 Nov 2023 02:42:15 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231902AbjKAJlz (ORCPT + 99 others); Wed, 1 Nov 2023 05:41:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231411AbjKAJlx (ORCPT ); Wed, 1 Nov 2023 05:41:53 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 758FEE4 for ; Wed, 1 Nov 2023 02:41:47 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 35A9E21A34; Wed, 1 Nov 2023 09:41:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1698831706; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gNzKW+x1c0UZzbPukaEOwSLPVJ3mDtKgT9KmOp+APUs=; b=mATHxiyl0jyzlQq1mEMQ1Vf9cG7e8R78/0Fg62j2oA5mxSItZFmh+/2+y/MO0xxPhK7If8 1NU2e1kMm0UsMXYdbehYvMYQa4Ugff/Vxvghqsv6zUabsZ929/4TUaOwcex51GQ9UbxOZO sJQlpgZZ6t7pvksUd25n1OoZLxCNkiM= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0FB8013460; Wed, 1 Nov 2023 09:41:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id PRrnAFodQmU9DAAAMHmgww (envelope-from ); Wed, 01 Nov 2023 09:41:46 +0000 Date: Wed, 1 Nov 2023 10:41:45 +0100 From: Michal Hocko To: Charan Teja Kalla Cc: Pavan Kondeti , akpm@linux-foundation.org, mgorman@techsingularity.net, david@redhat.com, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: page_alloc: unreserve highatomic page blocks before oom Message-ID: References: <1698669590-3193-1-git-send-email-quic_charante@quicinc.com> <2a0d2dd8-562c-fec7-e3ac-0bd955643e16@quicinc.com> <37c58833-1953-42c3-98c6-ee0ac75508ce@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 01 Nov 2023 02:42:16 -0700 (PDT) On Wed 01-11-23 12:23:24, Charan Teja Kalla wrote: [...] > > Also, add below Fixes tag if it makes sense. > > > > Fixes: 04c8716f7b00 ("mm: try to exhaust highatomic reserve before the OOM") > I should be adding this. I do not think this Fixes tag is really correct. 04c8716f7b00 was rather an incomplete fix than something that has caused this situation. I think we would need to reference the commit which adds highatomic reserves. -- Michal Hocko SUSE Labs