Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <70e6cc10-4300-e9c2-daea-ae5b09923d30@quicinc.com>
Date:   Wed, 1 Nov 2023 16:11:53 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v3] firmware: qcom_scm: Clear download bit during reboot
Content-Language: en-US
To:     Robert Marko <robimarko@gmail.com>,
        Sricharan Ramabadhran <quic_srichara@quicinc.com>
CC:     <agross@kernel.org>, <andersson@kernel.org>,
        <konrad.dybcio@linaro.org>, <linux-arm-msm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <1678979666-551-1-git-send-email-quic_mojha@quicinc.com>
 <76943268-3982-deaf-9736-429dd51e01b0@gmail.com>
 <0e645486-f0be-4468-18ad-9e49088dee0b@quicinc.com>
 <CAOX2RU4xPNq4-OHUoMZtfZu05QEdpk1UtawZb1xQMrtc5ao84Q@mail.gmail.com>
 <a6c48095-179a-7e72-a282-fbc28af374cb@quicinc.com>
 <CAOX2RU6S-x-KrQ-qQLW-qxu4bph79d+Yq9Vj=PQwWW4o-yG2xA@mail.gmail.com>
 <CAOX2RU6rv0jcnTRAa=kiWHPk1A=DW=smS72df_t+tufOZ9XGfA@mail.gmail.com>
 <cd2c808c-bcb8-85fe-2c56-7accd4853160@quicinc.com>
 <CAOX2RU50+iR0jfyQqzRoTLn0Jydd_c+Ue88rDdhL6PbOKPDMVA@mail.gmail.com>
 <00b49050-5b9b-c16d-bd8f-8604ea993a26@quicinc.com>
 <CAOX2RU6EtRVmezcHhvTJF6Kc69_9dvzUHeoXQ1F1=ctnqhkmrw@mail.gmail.com>
From:   Mukesh Ojha <quic_mojha@quicinc.com>
In-Reply-To: <CAOX2RU6EtRVmezcHhvTJF6Kc69_9dvzUHeoXQ1F1=ctnqhkmrw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

+@Sricharan

On 11/1/2023 3:21 PM, Robert Marko wrote:
> On Thu, 26 Oct 2023 at 17:16, Mukesh Ojha <quic_mojha@quicinc.com> wrote:
>>
>> Hey Robert,
>>
>> Just remembered this thread again,
>>
>> is this issue got fixed with
>>
>> https://lore.kernel.org/lkml/20230816164641.3371878-1-robimarko@gmail.com/
> 
> Sadly no, as this issue is affecting all IPQ4019 boards and not just
> the ones that have SDI enabled.

unless, enabling CONFIG_QCOM_SCM_DOWNLOAD_MODE_DEFAULT has problem in 
your SoC, i don't think why current patch can cause issue in your
board.

Can you please help with some debug as i don't have this target but
interested in fixing this issue if it is indeed due to kernel.

whether, CONFIG_QCOM_SCM_DOWNLOAD_MODE_DEFAULT works on your target 
basically if qcom_scm_set_download_mode(true); return success and
reboot works with that.

Or may be only writing qcom_scm_set_download_mode(false); has some
unknown affect in the firmware and later causing a problem in reboot.


-Mukesh