Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Feedback-ID: i68a1478a:Fastmail
Date:   Wed, 1 Nov 2023 09:43:56 -0500
From:   Patrick Williams <patrick@stwcx.xyz>
To:     Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com>
Cc:     Guenter Roeck <linux@roeck-us.net>,
        Krish Skandakumaran <krishskanda@meta.com>,
        Jean Delvare <jdelvare@suse.com>,
        "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] hwmon: emc1403: Add support for EMC1442
Message-ID: <ZUJkLJEpwji6czHJ@heinlein.vulture-banana.ts.net>
References: <20231031085807.618827-1-Delphine_CC_Chiu@wiwynn.com>
 <7d92d8ae-c247-4a71-a84d-4f9639a43fb8@roeck-us.net>
 <ZUG3fOnw8RE7JHsh@heinlein.vulture-banana.ts.net>
 <aa00e20a-03ee-4092-a477-6d952cdacf4e@roeck-us.net>
 <PSAPR04MB459864E8447A97985FA303FAA5A7A@PSAPR04MB4598.apcprd04.prod.outlook.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="8L9HAZp0EqKU6PIc"
Content-Disposition: inline
In-Reply-To: <PSAPR04MB459864E8447A97985FA303FAA5A7A@PSAPR04MB4598.apcprd04.prod.outlook.com>
Precedence: bulk


--8L9HAZp0EqKU6PIc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Nov 01, 2023 at 08:45:15AM +0000, Delphine_CC_Chiu/WYHQ/Wiwynn wrot=
e:
> > >>> ---
> > >>>     { "emc1422", emc1402 },
> > >>>     { "emc1423", emc1403 },
> > >>>     { "emc1424", emc1404 },
> > >>> +   { "emc1442", emc1403 },
> > >
> > > So, emc1402?
> > >
> >=20
> > At the very least, if you are willing to confirm that formally if/when =
v2 is
> > submitted.
> >=20
> > I previously rejected a similar patch adding emc1444 because it was imp=
ossible
> > to get a datasheet to confirm that the chips are really register compat=
ible. No
> > idea why that has to be so secretive. It is a temperature sensor, for h=
eaven's
> > sake :-(
> >=20
> > Guenter
>=20
> Hi Krish,
> Would need your confirmation of the device on the NIC.

I don't think we need additional feedback from Krish.  Please change to
emc1402 from emc1403.

The datasheet for EMC1442 even has a section titled "Functional Delta
=66rom EMC1412 to EMC1442", which is effectively all non-software related.
Therefore, the compatibility here should match what was done for
"emc1412" which was `emc1402`.

I will send my Reviewed-by with a v2 using emc1402.

--=20
Patrick Williams

--8L9HAZp0EqKU6PIc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEBGD9ii4LE9cNbqJBqwNHzC0AwRkFAmVCZCsACgkQqwNHzC0A
wRnCGQ/5ASfFYBrozj5GVQx8szBklXA/qLO1EMCICOxRx68qEaSrlt1fjzlFnx4G
hfrSA/Er4jbC1Iw8xqVwi4g1drim5XjYZI28F26u+oICnkia2VY/5jbYIhiMjIcc
qI0GaAduP2a76U92bHaxLKKDDdBw3mK/v/2nFzTYibLkyrm/PiK1E+9UC0YStmqB
X5KdlkcVd3rXzPHIQj/4HR0wCb4A8Sfmf/eUgtDPjn4eSZ0lhbWnIF+NQE4X/aNT
8VxT1BhcITkhiJRxLVnhTAiV3tn7WSAZsKA9FF0y6CbvyBwZawc8/ntYw1yTfNr9
lzGTtMhxBMdvWRMD4AlJFMxXWAY0q32cfsMS8eE92KZBCSO6Ea1ZCBxdgovIxWXE
4O7iOF/rRafRPZrrGYYaEuFyZ19qRMl4GaTepO3lOcAKnYyDqRBUHVyNSTECqqB8
QumOscE3aos5z7WNXarWLzkNqYbgAni8+4k6Pvb/oZwtu/lL0Ts4apH1mIc/DzDb
8h/EhdKmjUpmL2teqULpKCb2SBHef8TgkT+NN62dBzsLaeL64g/e0NKHWNgD3dFH
vY27NwK46b955IbgkWok53pxGGGQmhgHWxPO1xL1qk9RqrBxrZWlPzt57Rqfs7B6
L+Jjq9Q8GVKbdQOjophVG+EMyd06VZ9HvnrWSoY0dRjp+30/G1s=
=hAMh
-----END PGP SIGNATURE-----

--8L9HAZp0EqKU6PIc--