Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
MIME-Version: 1.0
References: <20231030145540.pjkggoiddobyjicq@moria.home.lan>
 <CAMuHMdXpwMdLuoWsNGa8qacT_5Wv-vSTz0xoBR5n_fnD9cNOuQ@mail.gmail.com>
 <20231031144505.bqnxu3pgrodp7ukp@moria.home.lan> <CAMuHMdVKi=ShPUwTHrX0CEN2f9+jRXWymnKH=BiXTpmg857AJQ@mail.gmail.com>
In-Reply-To: <CAMuHMdVKi=ShPUwTHrX0CEN2f9+jRXWymnKH=BiXTpmg857AJQ@mail.gmail.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Wed, 1 Nov 2023 16:02:25 +0100
Message-ID: <CAMuHMdVfj5q_06cM3dXvNyfdNZQM=M=ocbG5XFpCp2UhVjjJ9w@mail.gmail.com>
Subject: Re: [GIT PULL] bcachefs for v6.7
To:     Kent Overstreet <kent.overstreet@linux.dev>
Cc:     Linus Torvalds <torvalds@linux-foundation.org>,
        linux-bcachefs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hi Kent,

On Tue, Oct 31, 2023 at 4:00 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Tue, Oct 31, 2023 at 3:45 PM Kent Overstreet
> MEAN_AND_VARIANCE_UNIT_TEST should depend on BCACHEFS_FS, as the actual
> mean_and_variance code is only compiled if BCACHEFS_FS is enabled.

And I really meant "should depend on BCACHEFS_FS", not "should select
BCACHEFS_FS", like is done in today's linux-next:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/fs/bcachefs/Kconfig?h=next-20231101&id=487ed6712ae1bf2311197bd41ae572ff8da5e966

> On m68k (ARAnyM), it fails with:

[...]

> # Totals: pass:7 fail:2 skip:0 total:9
> not ok 1 mean and variance tests
>
> Haven't tried the test on any other platform yet, so this could be a
> big-endian, 32-bit, m68k-specific, or even a generic problem.

It fails in the exact same way on arm32 and arm64...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds