Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Wed, 1 Nov 2023 15:10:58 +0000
From:   Conor Dooley <conor@kernel.org>
To:     Vincent Knecht <vincent.knecht@mailoo.org>
Cc:     Tianshu Qiu <tian.shu.qiu@intel.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Yassine Oudjana <y.oudjana@protonmail.com>,
        linux-media@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] media: dt-bindings: ak7375: Add ak7345 support
Message-ID: <20231101-wise-childless-ed44729657c6@spud>
References: <20231101102257.1232179-1-vincent.knecht@mailoo.org>
 <20231101102257.1232179-2-vincent.knecht@mailoo.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="pODw/iX2UkMAb4/N"
Content-Disposition: inline
In-Reply-To: <20231101102257.1232179-2-vincent.knecht@mailoo.org>
Precedence: bulk


--pODw/iX2UkMAb4/N
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Nov 01, 2023 at 11:22:56AM +0100, Vincent Knecht wrote:
> Document AK7345 bindings.

The commit message should mention why this device is incompatible with
the 7375. Something like

"Document the ak7345 voice coil motor actuator. Similar to the ak7375,
this model has 4 unilateral phase detractors instead of 8."

Otherwise,
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

>=20
> Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org>
> ---
>  .../devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml     | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak73=
75.yaml b/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.ya=
ml
> index 22a810fc7222..fe312cc6a873 100644
> --- a/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml
> @@ -15,7 +15,9 @@ description:
> =20
>  properties:
>    compatible:
> -    const: asahi-kasei,ak7375
> +    enum:
> +      - asahi-kasei,ak7345
> +      - asahi-kasei,ak7375
> =20
>    reg:
>      maxItems: 1
> --=20
> 2.41.0
>=20
>=20
>=20

--pODw/iX2UkMAb4/N
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZUJqggAKCRB4tDGHoIJi
0slyAP9VpcF5IzeE9i4pnc3z2Dl/ml0Sd6jvPoRkLEufandUYwD+IC8ffkg6jBmB
NHs9lJ26+uz0K/TlXllzodqhGmmjvQs=
=tXf/
-----END PGP SIGNATURE-----

--pODw/iX2UkMAb4/N--