Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <e1ec475e-1c98-4437-8152-66487e1ef29b@oracle.com>
Date:   Wed, 1 Nov 2023 10:20:40 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH-v2] jfs: fix slab-out-of-bounds Read in dtSearch
Content-Language: en-US
To:     Manas Ghandat <ghandatmanas@gmail.com>, dan.carpenter@linaro.org,
        shaggy@kernel.org
Cc:     Linux-kernel-mentees@lists.linuxfoundation.org,
        jfs-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org,
        lkp@intel.com, oe-kbuild-all@lists.linux.dev,
        oe-kbuild@lists.linux.dev
References: <20231025060907.115675-1-ghandatmanas@gmail.com>
From:   Dave Kleikamp <dave.kleikamp@oracle.com>
In-Reply-To: <20231025060907.115675-1-ghandatmanas@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NVpCZUpaWkRtUTJwMUhRVXhTdUx5UGJmWW8wbklQajhzZzZvUEhqb21rWTFH?=
 =?utf-8?B?ZkcrbUlyNWVOaW5FV1c4VWZycnllMkZ0R2RCUVlVS1FWdTZneHNNWGpPUEZR?=
 =?utf-8?B?bnluZDIyM1ZNSFZBNVEvSkl2Wmp3L2c1Yll5RjE0cUNoL2JJc2lIOUhiSHBR?=
 =?utf-8?B?eEZvcDNxSE5KV0t3aTY0SzFaOUJHQU5rbmRJZmUxS0cyZGZ3UklhN0xXVDdq?=
 =?utf-8?B?SEtpaGFvK3NSWEUyR1lBY0pHZDlTWE41SExETzZuRFBmcTJXVU13ZC8wTGo2?=
 =?utf-8?B?clBKZjlhMC9GSGN4akNUVWF1SXVvY0pXRWlCOVo1VUFFVTJ5MU01Um5lZmxG?=
 =?utf-8?B?dGpZOWxFRXhQLzMwVTdtaWlIT1ExMHBKVmJhOXcyVWc4aVJWM0txTWpKN3NP?=
 =?utf-8?B?NEVQVitTWEMySW1hL2d5dDZ3dVUzb3k4V3lVSVFhYS94QVhnbmJNLzE2U1NZ?=
 =?utf-8?B?V2FhOG1pK0pKdWVXT3NYa1E5Tnkzd1BaY1BsVCt6TzA0L0pHRkFTNjYxS05W?=
 =?utf-8?B?b3UyeEdoS3hYVmhTNmsyYUkzaGs2V0xvMjlDVHJpeXdzY2JBbVV0OVVEVGZx?=
 =?utf-8?B?dWlKN3NGYTFmVzZvb2M0NjlSdGlEVEJCeWgvR1hGbG96L25WVndId2M3ODlC?=
 =?utf-8?B?amE5V20vRWF2WVVnRlpYcHlJeWovNkRLM1lCckk5L1ZUdkE0cll5WjUyT2xu?=
 =?utf-8?B?RXRjT01SVlh2eUx3VU9YM09CdVU2UW52aG1iWUhoYktMdFRkOUpHNndpZXN2?=
 =?utf-8?B?ZmxTMC9ibUFqQnp2TjV5MVdqUmdjU3ZmOTR1MWxtMVlvVk1oZVlJc0FSa0dk?=
 =?utf-8?B?RU1hR1pQOGhNaXhuYVcxelFsdFdmcExwVnRLMzU3SVA3SUhsMElsZjVUUlVw?=
 =?utf-8?B?L1Z1MHdBQlkxRTF5VitZNVBJMjNmOGpYQ0p4QkdRdWlhVTJQdEVDN3pBWXpt?=
 =?utf-8?B?b0FVK3lSZjNrNEI2NEVSMGdkNWZtVnJSWUFubXlFZ2tERks1bXplbytDcTdx?=
 =?utf-8?B?bnU0b1A1a1ZDeWx2M0xOK3R5YU53Vk9SOWc0R0UzZGxqVWR0TzdMSTVxQjk0?=
 =?utf-8?B?ajAvTWRNMTZiZ21zNHRiQ1pIOExHMStiU0daZnpVc242ZWxZNXJSRzR6TUNR?=
 =?utf-8?B?VjdUa2FpWmpiTmsyQmdXN0V0QSt1QmhCYWxIakZoZWpnRGhFYUtNZEJOci9F?=
 =?utf-8?B?bkh3L05idHQ1TGpFMnR2cG5heTZlZ1pxYTBabVJaVmpINTlhT0FFZnJXOXo5?=
 =?utf-8?B?VXpBSW5oNGY0bjFwNUlOS2FjWVNYa2J4VXNyditVZ01mUzAzK2RBT09yOENr?=
 =?utf-8?B?VitsTDJGR1RVYlYzWnhOdjVoNnpuSXVZSE1jb3htSE9MUjUwRGFCbDJCbUxB?=
 =?utf-8?B?aWNaUTkzYkJKTVFFbk9vNXFKaklaUzJOT2d1NHNaZTcvUnVONVZkcnlvdTZ4?=
 =?utf-8?B?VjlzcGV5UnUzek8xVU94MG1EdDNRV0NwdFdHT2FpMW1JM2h5U2ZyaUdKVVlt?=
 =?utf-8?B?MHBhWkYvTHl5amxHNzBaRkQwTzRxU050eHNyanhodzZRNlptWnpiMENKWDhC?=
 =?utf-8?B?dW9tZy9LbFRyNWc5ZnlKbmV1ZHNYL3lJVklaN0xCYWNRd1BrQTFwQTR1WFVv?=
 =?utf-8?B?bUgvdlNUQWc3bEZhVmkyQldiTURoZldyNXF2ZXowb2UvVU0wbW5uNmpSMnhi?=
 =?utf-8?B?L2RJQTNtL0J5Yk9kWXJ2TEQreGVzb3FwMjlKeEtsdG1nYVhBM2U1WnU3Tit2?=
 =?utf-8?B?aW1yOGxLYjNlai9rT1N2MDBqM2l1djdlZ2ptdndNaXhIY3pma2l1eHZReFcv?=
 =?utf-8?B?V0VRRVJzZ0paU0pHamhvUUFuTkZ2dGlCcXl4RjJ1RDg4d0ZTMkhmNkwyb2FB?=
 =?utf-8?B?S2RzaXgvQVdYS0hETEpNUm1NclpUUGpFeFlJYnpSVTdURTZmNWk2UGJVOVEv?=
 =?utf-8?B?NktyZXNjYjJ3WEVFb2xydnZnemIwZzU3NEk0dDhjRGxrWUNmVktDZzRqb0Zz?=
 =?utf-8?B?YThTRlVXZXFvM1JtR3ZhZTgzY0FCcVlWYU5wb1VnZHQrQU1FSlJ2UWRaZzFJ?=
 =?utf-8?B?akVJWXNnNkhZQS9CM0J2TFkvT3pKTWRUMSs1YzBxZ0pqWWRDUlR3djBuN3pR?=
 =?utf-8?B?eCttT0kzcWZwaWFlamU3SGVIQVJqMFEvMHVZMEZVWlA2SzJrR0tKcnpoQTFm?=
 =?utf-8?B?WXc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?QjZpWGIzeHprNXlhekpsWW1KYk9TRzFreWM2elB2b0NZeVIvSjFNdWRWSDVw?=
 =?utf-8?B?TkYyVUJtS2RHY3VjVnNvNlFiWThPZWN6V2QrKytCNjNxWUt3NUcrUEVjS1U5?=
 =?utf-8?B?S1Q1VGpLN013S1NsQWRrVUFCNlh2cVhmNUJtbjZFTlBFamtQQkh3MnJ3QjNT?=
 =?utf-8?B?SUNzWDVSTGtWaE03ZENmcTdWa09qbFA1VVZCVVd3bE9xNlZOSUxtbnVFanN1?=
 =?utf-8?B?VGg4Nm9VbUtTWWhES0Y0TXE5Wm44TWs3aTU2OSt6WWFEOGNEMExJY2Vnb201?=
 =?utf-8?B?M0JqanpCNnZ4RVFuOUNIVzN6VCthMFExTU5iVDN3S29jenNlVjRtQVFnTEtD?=
 =?utf-8?B?YkxNWkVKMnFsQnFlN0N4bC9KM2p5MDQxSXpqZWhDTVpiWlByeVM1VjBqendK?=
 =?utf-8?B?SXBKQXo5QTJjYjR5eUU5K3dITzV1T0Ftd0RFdjg0Ti9IN0xyVTBueFhVSTBw?=
 =?utf-8?B?Y0dxRDBER3pXbnNVUFJzaVZMSUJ6MGo3N2k0SzBkakdCQXpNekR6K0NCTUp3?=
 =?utf-8?B?RngyY2JQbVVodmJpL2g5YURMYkwrbDY4OWlFQkdiUmc2YktQT1F1UjU0SUl4?=
 =?utf-8?B?eEYvQmtIQVduaVRVblVsSENKUDJHc21aeXJsTk9KMUZFNFcvakpZbU9WdHFM?=
 =?utf-8?B?Y3A1dmtHVURiSE5zaUZ4MzRiVG1uZFpEUlFXZ1FldHBvVlZ3S2oyUDkxTDBN?=
 =?utf-8?B?NzFvVXNpTU0wSVptOWZURGJlQXcyc1J6UElDL1BHYkNUZ2FOcWY5UklRZGZk?=
 =?utf-8?B?RHBYMWNDVFk0bzRHc1NZdmNqRDVPV1hBb3FtWHRPc1hMVlhWMlR5OUpqSUtV?=
 =?utf-8?B?RElwVndyMVFJcFkrUlFlMXJqbmVjVnRGWGRYMEJSbkN0SXlibVRZMllzUmxO?=
 =?utf-8?B?VWN6K2RLdFdnaWxhSmxZZ2FqSy9pREFFT2cyL2V0RDY4TWlkcE9hVzNBdUZX?=
 =?utf-8?B?ZzhzWmpxbHNoK0NYWDZxSDJ4Znl4a3VxOFRlaXRQN2V2R0ozOGtZUVVmaXk3?=
 =?utf-8?B?bVJDSXY5NDdDZm12dm9EbTRWS2I4eG5ZZ1RmQWRicUhBN0xDaDF0dlBPNzNl?=
 =?utf-8?B?dDBTMDVNcHZqdkxSNzFuem1ZZEJxVHhLK0FmN1M1VllnY0hlM2doOGRPbkZD?=
 =?utf-8?B?RCtqUndEakFBblVZNlZyTFAvM2J3d0NEaENyQlFHQ3hqUlpqa1ZSall4aExC?=
 =?utf-8?B?SHgwdXFzdlRSYkc0SDdNRUMzVVpPbmtPL1REekM5ZFBVaDU5TDdRc0xkT2Jx?=
 =?utf-8?B?Nm1jTWdCN0FNcmcvTEZjVlJDcXgzckVSd2xpY3NDSG4zbzVBOTk1Mk8yTHZ5?=
 =?utf-8?B?S3FmMjE4S05EOVhhUkRUK2RPOEpEVm1nWFBiNFZ3Ukh5UWxBb2xpR0JpVjhi?=
 =?utf-8?Q?vLsAwQtjuq/+EGgZNlJfm0+FVZq42QRE=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 34e20113-9f52-471c-7a0e-08dbdaee1cf3
X-MS-Exchange-CrossTenant-AuthSource: MW5PR10MB5738.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2023 15:20:42.8281
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YE+KPwX2/FOgM2HTqhHW9osb5+2tnEg+bTQ8DmxbHtAFBjmKeW6IiC2JgAXNKB5Qj1WpAgJg1jneVc/KBK8mmMsSZo9/sI0j7fY/HgiI0K0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7305
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-01_13,2023-11-01_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 spamscore=0
 phishscore=0 mlxlogscore=999 adultscore=0 mlxscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2310240000
 definitions=main-2311010126
X-Proofpoint-GUID: zBlwSLKCiaiSiHFvAFMdvNS2m2cgyEmR
X-Proofpoint-ORIG-GUID: zBlwSLKCiaiSiHFvAFMdvNS2m2cgyEmR
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 01 Nov 2023 08:21:36 -0700 (PDT)

On 10/25/23 1:09AM, Manas Ghandat wrote:
> Currently while searching for current page in the sorted entry table
> of the page there is a out of bound access. Added a bound check to fix
> the error.

Looks good. I made the small change of setting rc = -EIO in that case, 
so we know there is something wrong with the file system.

Thanks,
Shaggy

> 
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/r/202310241724.Ed02yUz9-lkp@intel.com/
> Signed-off-by: Manas Ghandat <ghandatmanas@gmail.com>
> ---
> V1 -> V2 : Removed redundant check on stbl
> 
>   fs/jfs/jfs_dtree.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/fs/jfs/jfs_dtree.c b/fs/jfs/jfs_dtree.c
> index 92b7c533407c..cf67d32d5b7f 100644
> --- a/fs/jfs/jfs_dtree.c
> +++ b/fs/jfs/jfs_dtree.c
> @@ -633,6 +633,9 @@ int dtSearch(struct inode *ip, struct component_name * key, ino_t * data,
>   		for (base = 0, lim = p->header.nextindex; lim; lim >>= 1) {
>   			index = base + (lim >> 1);
>   
> +			if (stbl[index] < 0)
> +				goto out;
> +
>   			if (p->header.flag & BT_LEAF) {
>   				/* uppercase leaf name to compare */
>   				cmp =