Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Wed, 1 Nov 2023 15:33:30 +0000
From:   Conor Dooley <conor@kernel.org>
To:     Vincent Knecht <vincent.knecht@mailoo.org>
Cc:     Tianshu Qiu <tian.shu.qiu@intel.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Yassine Oudjana <y.oudjana@protonmail.com>,
        linux-media@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] media: dt-bindings: ak7375: Add ak7345 support
Message-ID: <20231101-floss-mortified-452c96c9af46@spud>
References: <20231101102257.1232179-1-vincent.knecht@mailoo.org>
 <20231101102257.1232179-2-vincent.knecht@mailoo.org>
 <20231101-wise-childless-ed44729657c6@spud>
 <0f294695fdfed60c385deadc9d030c225816b4f9.camel@mailoo.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="GFXk9WplJkFov3Ct"
Content-Disposition: inline
In-Reply-To: <0f294695fdfed60c385deadc9d030c225816b4f9.camel@mailoo.org>
Precedence: bulk


--GFXk9WplJkFov3Ct
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Nov 01, 2023 at 04:29:20PM +0100, Vincent Knecht wrote:
> Le mercredi 01 novembre 2023 =E0 15:10 +0000, Conor Dooley a =E9crit=A0:
> > On Wed, Nov 01, 2023 at 11:22:56AM +0100, Vincent Knecht wrote:
> > > Document AK7345 bindings.
> >=20
> > The commit message should mention why this device is incompatible with
> > the 7375. Something like
> >=20
> > "Document the ak7345 voice coil motor actuator. Similar to the ak7375,
> > this model has 4 unilateral phase detractors instead of 8."
> >=20
> > Otherwise,
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> >=20
> > Cheers,
> > Conor.
>=20
> Thank you for the review!
>=20
> I don't know anything about phase detractors, nor any other details

hah, that was just me putting techobabble in the example text rather
than using foo. See also:
https://www.youtube.com/watch?v=3DRXJKdh1KZ0w

> (having found no datasheets for either of these ICs)
> apart what could be infered from vendor/downstream drivers
> like in the commit text for patch 3/3...
>=20
> So I guess I'll send a v2 with a commit text along these lines :
> Document AK7345 bindings.
> Compared to AK7375, it has only 9 bits position values (instead of 12),
> 20 ms power-up delay (instead of 10), and no known standby register setti=
ng.

Yah, that is the exact sort of information that is good to have, thanks.

--GFXk9WplJkFov3Ct
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZUJvygAKCRB4tDGHoIJi
0mr0AP9ua78lXwIJm7NKVVKFjyBrUIedY6NKHe0VwDp4fJi5HAD/V0b1ZNpChS1t
c/HKZTeESkrwatJfu376oALOkuZHbg8=
=9zv9
-----END PGP SIGNATURE-----

--GFXk9WplJkFov3Ct--